- 04 7月, 2018 1 次提交
-
-
由 Edouard CHIN 提交于
- When lazy load hooks were triggered we were using `Object.instance_eval` which evaluates the block in the context of the class being passed. Most of the time that class was a `Class`. If one wants to define a instance method on the class then it wasn't possible. ```ruby class A; end; A.instance_eval do def foo puts 'bar' end end A.new.foo #> NoMethodError: undefined method `foo` A.foo #> bar ``` - This PR checks what object is passed when triggering the hooks and either call `class_eval` or `instance_eval`. My rational and assumptions being that if an instance of a class is passed, then the blocks needs to evaluate in the context of that instance (i.e. defining a method should only define it on that instance). On the other hand, if a Class or Module is passed when triggering hooks, then defining a method should define it on the class itself - #32776 Pushed me to introduce this change
-
- 22 6月, 2018 3 次提交
-
-
由 Prem Sichanugrist 提交于
Add to docs mention about `:year_format` option of date select
-
由 bogdanvlviv 提交于
Follow up #32190 [ci skip]
-
由 Ryuta Kamizono 提交于
-
- 21 6月, 2018 7 次提交
-
-
由 George Claghorn 提交于
-
由 Yuji Yaginuma 提交于
Update fugit to latest version
-
由 utilum 提交于
[fugit 1.1.3](https://github.com/floraison/fugit/commit/03a3ee86f3cd5d929442dd25896b99acbd151947) fixes warnings that show up in ActiveJob tests. See [CI](https://travis-ci.org/rails/rails/jobs/394107740#L3764-L3778).
-
由 Ryuta Kamizono 提交于
Add `use_year_names` option to date_select tag
-
由 Ryuta Kamizono 提交于
Fix actionpack changelog typo [ci skip]
-
由 Yuji Yaginuma 提交于
Merge pull request #33172 from thomasdziedzic-pd/add-use_authenticated_message_encryption-documentation add documentation for config.active_support.use_authenticated_message_encryption
-
由 Thomas Dziedzic 提交于
related to https://github.com/rails/rails/issues/33170
-
- 20 6月, 2018 6 次提交
-
-
由 Ryuta Kamizono 提交于
Follow up of 15367a2c.
-
由 Ryuta Kamizono 提交于
Since `aliases` is a part of `JoinDependency` and already cached at 1a723c65.
-
由 Ryuta Kamizono 提交于
It was no longer used since d7ddaa53.
-
由 Genadi Samokovarov 提交于
I spotted it while working on a PR.
-
由 Kevin Sjöberg 提交于
* Convert hashes into parameters Ensure `ActionController::Parameters#transform_values` and `ActionController::Parameters#transform_values!` converts hashes into parameters. * fixup! Convert hashes into parameters [Rafael Mendonça França + Kevin Sjöberg]
-
由 Rafael França 提交于
Reduce Memory Allocation when using .pluck
-
- 19 6月, 2018 9 次提交
-
-
由 Ryuta Kamizono 提交于
Removed useless utility classes inside HABTM association builder
-
由 Ryuta Kamizono 提交于
Currently, column aliases which is used for eager loading are calculated before constructing all table aliases in FROM clause. `JoinDependency#join_constraints` constructs table aliases for `joins` first, and then always re-constructs table aliases for eager loading. If both `joins` and eager loading are given a same table association, the re-construction would cause the discrepancy between column aliases and table aliases. To avoid the discrepancy, the column aliases should be calculated after all table aliases are constructed. Fixes #30603.
-
由 Eileen M. Uchitelle 提交于
Add support for more HTTP cache controls
-
由 Bogdan Gusiev 提交于
-
由 Lachlan Sylvester 提交于
-
由 Rafael França 提交于
Fix Ruby version in `.ruby-version`
-
由 bogdanvlviv 提交于
Since #30016 Rails generates `.ruby-version` file in order to help Ruby version manager tools like `rbenv`, `rvm` determine which Ruby version should be used for the current Rails project. Since #32649 Rails sets Ruby version to the file compatible with MRI/JRuby by default. Pull Request #31496 reports that `.ruby-version` doesn't match ruby version other than stable version and recommends to use `ENV["RBENV_VERSION"]`, and `ENV["rvm_ruby_string"]` in order to set correct Ruby version to the file that `rbenv` or `rvm` can understand. Also, there is another similar issue that reports the same case if use JRuby https://github.com/jruby/jruby/issues/5144. Closes #31496, https://github.com/jruby/jruby/issues/5144.
-
由 Eileen M. Uchitelle 提交于
Add test case for the `|` token in Journey scanner
-
由 vaidehijoshi 提交于
Journey's scanner tokenizes the `|` (:OR) operator when scanning route urls such as `"/:foo|*bar"`. However, the current scanner test does not have any test cases for the `|` operator. This commit adds a test case for this particular token.
-
- 18 6月, 2018 4 次提交
-
-
由 Ryuta Kamizono 提交于
Add docs for ActiveRecord::Migration#say, #say_with_time, #suppress_messages [ci skip]
-
由 Ryuta Kamizono 提交于
`touch` option was added to `increment!` (#27660) and `update_counters` (#26995). But that option behaves inconsistently with `Persistence#touch` method. If `touch` option is passed attribute names, it won't update update_at/on attributes unlike `Persistence#touch` method. Due to changed from `Persistence#touch` to `increment!` with `touch` option, #31405 has a regression that `counter_cache` with `touch` option which is passed attribute names won't update update_at/on attributes. I think that the inconsistency is not intended. To get back consistency, ensure that `touch` option updates update_at/on attributes.
-
由 Naoki Nishiguchi 提交于
-
由 yuuji.yaginuma 提交于
`optparse` is unused since #26977.
-
- 17 6月, 2018 1 次提交
-
- 16 6月, 2018 1 次提交
-
-
由 yuuji.yaginuma 提交于
It is necessary to specify a value to `config.active_storage`.
-
- 15 6月, 2018 4 次提交
-
-
由 Yuji Yaginuma 提交于
Fix rubocop violations
-
由 bogdanvlviv 提交于
https://codeclimate.com/github/rails/rails/issues `bundle exec rubocop -a` Related to e4e1b620
-
由 Rafael França 提交于
Update example for whitelisting arbitrary hashes
-
由 Michael Holroyd 提交于
Since the ability to whitelist arbitrary hashes was added (https://github.com/rails/rails/issues/9454 was resolved by https://github.com/rails/rails/commit/e86524c0c5a26ceec92895c830d1355ae47a7034), this example is no longer outside of what strong_params can do. Moved this specific example out of the "Outside the Scope" section and into the regular "Examples" section, but left the "Outside the Scope" section as it was since the advice is still relevant for weirder whitelisting situations (maybe someone wants to add a new example that can't be handled natively).
-
- 14 6月, 2018 2 次提交
-
-
由 yuuji.yaginuma 提交于
-
由 Daniel Schierbeck 提交于
From <https://tools.ietf.org/html/rfc5861>: > The stale-if-error HTTP Cache-Control extension allows a cache to > return a stale response when an error -- e.g., a 500 Internal Server > Error, a network segment, or DNS failure -- is encountered, rather > than returning a "hard" error. This improves availability. > > The stale-while-revalidate HTTP Cache-Control extension allows a > cache to immediately return a stale response while it revalidates it > in the background, thereby hiding latency (both in the network and on > the server) from clients. These are useful, fully standardized parts of the HTTP protocol with widespread support among CDN vendors. Supporting them will make it easier to utilize reverse proxies and CDNs from Rails.
-
- 13 6月, 2018 2 次提交
-
-
由 Ryuta Kamizono 提交于
Allow prefix/suffix options for store accessors
-
由 Ryuta Kamizono 提交于
Update "Active Support Core Extensions" Guide [ci skip]
-