- 15 3月, 2016 1 次提交
-
-
由 Rafael Mendonça França 提交于
This reverts a334425c. The main reason is that now the workflow is inconsistent when using spring. When using spring `RAILS_ENV` is always set, so only one database is created. This means that in development `bin/rake db:create` and `bundle exec rake db:create` have different results. It also breaks the `bin/setup` script since `bin/rake db:setup db:test:prepare` will fail.
-
- 24 2月, 2016 1 次提交
-
-
由 Aaron Patterson 提交于
creating all databases mutates the connection pool. This patch restores the connection pool to the connection spec established before creating all databases. Fixes #23279
-
- 09 1月, 2016 2 次提交
-
-
由 yuuji.yaginuma 提交于
The error message has become a `DISABLE_DATABASE_ENVIRONMENT_CHECK`, modified to match the error message. ref: https://github.com/rails/rails/blob/master/activerecord/lib/active_record/migration.rb#L161
-
由 schneems 提交于
-
- 08 1月, 2016 3 次提交
-
-
由 schneems 提交于
Discussion: https://github.com/rails/rails/pull/22967#discussion_r49137035
-
由 schneems 提交于
Raise an error when a destructive action is made on a database where the current environment is different from the environment stored in the database.
-
由 schneems 提交于
This PR introduces a key/value type store to Active Record that can be used for storing internal values. It is an alternative implementation to #21237 cc @sgrif @matthewd. It is possible to run your tests against your production database by accident right now. While infrequently, but as an anecdotal data point, Heroku receives a non-trivial number of requests for a database restore due to this happening. In these cases the loss can be large. To prevent against running tests against production we can store the "environment" version that was used when migrating the database in a new internal table. Before executing tests we can see if the database is a listed in `protected_environments` and abort. There is a manual escape valve to force this check from happening with environment variable `DISABLE_DATABASE_ENVIRONMENT_CHECK=1`.
-
- 18 12月, 2015 1 次提交
-
-
由 David Heinemeier Hansson 提交于
Still more to do. Please assist!
-
- 21 10月, 2015 2 次提交
-
-
由 Jay Hayes 提交于
* If the drop task fails for a reason other than the database not existing, processing should end. This is indicated by a non-zero exit status. * Since the backtrace is already printed to screen, we forgo printing it again by using an explicit call to `exit`. *
⚠ This modifies the behavior of the db:create task slightly in that the stack trace is no longer printed by default. If the `--trace` option is used, it will print the trace _after_ the error message. -
由 Jay Hayes 提交于
* If the create task fails for a reason other than the database already existing, processing should end. This is indicated by a non-zero exit status. * Since the backtrace is already printed to screen, we forgo printing it again by using an explicit call to `exit`. *
⚠ This modifies the behavior of the db:create task slightly in that the stack trace is no longer printed by default. If the `--trace` option is used, it will print the trace _after_ the error message.
-
- 14 10月, 2015 2 次提交
-
-
由 Yves Senn 提交于
The focus of this change is to make the API more accessible. References to method and classes should be linked to make it easy to navigate around. This patch makes exzessiv use of `rdoc-ref:` to provide more readable docs. This makes it possible to document `ActiveRecord::Base#save` even though the method is within a separate module `ActiveRecord::Persistence`. The goal here is to bring the API closer to the actual code that you would write. This commit only deals with Active Record. The other gems will be updated accordingly but in different commits. The pass through Active Record is not completely finished yet. A follow up commit will change the spots I haven't yet had the time to update. /cc @fxn
-
由 Yves Senn 提交于
-
- 09 9月, 2015 1 次提交
-
-
由 Rafael Mendonça França 提交于
Usage was removed in 5c449553
-
- 07 9月, 2015 1 次提交
-
-
由 Tobias Bielohlawek 提交于
-
- 02 8月, 2015 1 次提交
-
-
由 starbelly 提交于
- Added run_cmd() class method to dry up Kernel.system() messages within this namespace and avoid shell expansion by passing a list of arguments instead of a string - Update structure_dump, structure_load, and related tests units to pass a list of params instead of using a string to avoid shell expansion
-
- 04 3月, 2015 1 次提交
-
-
由 James Cox 提交于
-
- 24 12月, 2014 1 次提交
-
-
由 Sean Griffin 提交于
This isn't Seattle.rb, @senny. ;)
-
- 23 12月, 2014 1 次提交
-
-
由 Yves Senn 提交于
-
- 18 12月, 2014 1 次提交
-
-
由 Yves Senn 提交于
Closes #17945 `db:test:prepare` still purges the database to always keep the test database in a consistent state. This patch introduces new problems with `db:schema:load`. Prior to the introduction of foreign-keys, we could run this file against a non-empty database. Since every `create_table` containted the `force: true` option, this would recreate tables when loading the schema. However with foreign-keys in place, `force: true` wont work anymore and the task will crash. /cc @schneems
-
- 01 11月, 2014 1 次提交
-
-
由 Sean Griffin 提交于
-
- 29 10月, 2014 1 次提交
-
-
由 Xavier Noria 提交于
The current style for warning messages without newlines uses concatenation of string literals with manual trailing spaces where needed. Heredocs have better readability, and with `squish` we can still produce a single line. This is a similar use case to the one that motivated defining `strip_heredoc`, heredocs are super clean.
-
- 04 9月, 2014 1 次提交
-
-
由 Yves Senn 提交于
[Joshua Cody & Yves Senn] Closes #16757. Prior to this patch schema loading rake tasks had the potential to leak a connection to a different database. This had side-effects when rake tasks operating on the current connection (like `db:seed`) were chained.
-
- 30 8月, 2014 2 次提交
-
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
This fixes random test failure in migrator_test.rb
-
- 29 8月, 2014 1 次提交
-
-
由 Godfrey Chan 提交于
Using heredoc would enforce line wrapping to whatever column width we decided to use in the code, making it difficult for the users to read on some consoles. This does make the source code read slightly worse and a bit more error-prone, but this seems like a fair price to pay since the primary purpose for these messages are for the users to read and the code will not stick around for too long.
-
- 06 8月, 2014 2 次提交
-
-
由 Yves Senn 提交于
The rake tasks and the `DatabaseTakss` adapter classes used to assume a configuration at some places. This forced the rake tasks to establish a specific connection before calling into `load_schema`. After #15394 this started to cause issues because it could `purge` the wrong database before loading the schema.
-
- 01 8月, 2014 1 次提交
-
-
由 Jack Danger Canty 提交于
This extracts the logic that was embedded in a Rake task into a static method. Bonus: the first test for `rake db:migrate`
-
- 28 7月, 2014 1 次提交
-
-
由 Kenn Ejima 提交于
-
- 02 7月, 2014 1 次提交
-
-
由 Rafael Mendonça França 提交于
Revert "Merge pull request #15394 from morgoth/fix-automatic-maintaining-test-schema-for-sql-format" This reverts commit 46139d33, reversing changes made to 8f247871. Conflicts: activerecord/CHANGELOG.md
-
- 27 6月, 2014 1 次提交
-
-
由 Viktar Basharymau 提交于
-
- 17 6月, 2014 1 次提交
-
-
由 Yves Senn 提交于
-
- 14 6月, 2014 1 次提交
-
-
由 Zachary Scott 提交于
-
- 12 6月, 2014 1 次提交
-
-
由 Wojciech Wnętrzak 提交于
Additionally: * It changes `purge` task on `sqlite3` adapter to recreate database file, to be consistent with other adapters. * Adds `purge` step when loading from `schema.rb`
-
- 15 4月, 2014 1 次提交
-
-
由 Robin Tweedie 提交于
rather than YAML.load(File.read(path)). YAML.load_file is also used in guides/rails_guides/helper.rb since 2011, the only other precedent I could find.
-
- 08 1月, 2014 1 次提交
-
-
由 Damien Mathieu 提交于
Closes #13625
-
- 02 1月, 2014 1 次提交
-
-
由 Jon Leighton 提交于
* Move check from generated helper to test_help.rb, so that all applications can benefit * Rather than just raising when the test schema has pending migrations, try to load in the schema and only raise if there are pending migrations afterwards * Opt out of the check by setting config.active_record.maintain_test_schema = false * Deprecate db:test:* tasks. The test helper is now fully responsible for maintaining the test schema, so we don't need rake tasks for this. This is also a speed improvement since we're no longer reloading the test database on every call to "rake test".
-
- 26 12月, 2013 1 次提交
-
-
由 Łukasz Strzałkowski 提交于
Warning: DEPRECATION WARNING: Passing a string to ActiveRecord::Base.establish_connection for a configuration lookup is deprecated, please pass a symbol (:development) instead.
-
- 24 12月, 2013 1 次提交
-
-
由 José Valim 提交于
This commit also cleans up the rake tasks that were checking for DATABASE_URL in different places. In fact, it would be nice to deprecate DATABASE_URL usage in the long term, considering the direction we are moving of allowing those in .yml files.
-
- 19 11月, 2013 1 次提交
-
-
由 Rafael Mendonça França 提交于
This reverts commit 22f80ae5. See https://github.com/rails/rails/commit/22f80ae57b26907f662b7fd50a7270a6381e527e#commitcomment-4640676 Conflicts: activerecord/CHANGELOG.md
-