- 27 5月, 2014 34 次提交
-
-
由 Sean Griffin 提交于
With ActiveRecord::Properties, we now have a reasonable path for users to continue to keep this behavior if they want it. This is an edge case that has added a lot of complexity to the code base.
-
由 Rafael Mendonça França 提交于
Add a public API to allow users to specify column types
-
由 Zachary Scott 提交于
-
由 Zachary Scott 提交于
-
由 Sean Griffin 提交于
As a result of all of the refactoring that's been done, it's now possible for us to define a public API to allow users to specify behavior. This is an initial implementation so that I can work off of it in smaller pieces for additional features/refactorings. The current behavior will continue to stay the same, though I'd like to refactor towards the automatic schema detection being built off of this API, and add the ability to opt out of automatic schema detection. Use cases: - We can deprecate a lot of the edge cases around types, now that there is an alternate path for users who wish to maintain the same behavior. - I intend to refactor serialized columns to be built on top of this API. - Gem and library maintainers are able to interact with `ActiveRecord` at a slightly lower level in a more stable way. - Interesting ability to reverse the work flow of adding to the schema. Model can become the single source of truth for the structure. We can compare that to what the database says the schema is, diff them, and generate a migration.
-
由 Rafael Mendonça França 提交于
Allow empty arrays in where predicates
-
由 Sean Griffin 提交于
-
由 Rafael Mendonça França 提交于
Extract types which don't require additional typecasting to a method
-
由 Sean Griffin 提交于
Database specific adapters shouldn't need to override `type_cast` to define types which are already in an acceptable state.
-
由 Zachary Scott 提交于
[ci skip] Add benchmark your code section to contributing to ruby on rails guide.
-
由 Juanito Fatas 提交于
I have seen many times that maintainers want people to use this gem to give a benchmark report. It would be nice to add it and refer to it later.
-
由 Rafael Mendonça França 提交于
Refactor reflections
-
由 Arthur Neves 提交于
Now the internal reflections will hold a reference to its public representation, so when the outside world calls `Account.reflection` we can build a list of public reflections.
-
由 Rafael Mendonça França 提交于
Refactor the handling of arrays in where predicates
-
由 Sean Griffin 提交于
Simplifies the code slightly, isolates non-nil non-range values into a single array, which will make it easier to do things like apply type casting to them in the future.
-
由 Rafael Mendonça França 提交于
Docs: Rename Posts to Articles in Guides' Getting Started App
-
由 Rafael Mendonça França 提交于
correct documentation for asset_path and image_path [ci skip]
-
由 Aditya Kapoor 提交于
-
由 Guillermo Iguaran 提交于
Skip individual tests upon Dalli::RingError
-
由 Rafael Mendonça França 提交于
correct docs for audio_tag and video_tag [ci skip]
-
由 Matthew Draper 提交于
Unlike the outer `rescue`, this one is much more precise about what we want to handle: a connection failure (`Dalli::RingError`) is not relevant to what we're testing here. But other Dalli errors may well be indicating an actual problem.
-
由 Rafael Mendonça França 提交于
This is not a security issue since this page is not present in production and user have to type something in the field but is better to escape the input.
-
由 Aditya Kapoor 提交于
-
由 Rafael Mendonça França 提交于
update the recommended ruby version.
-
由 Rafael Mendonça França 提交于
print generators on failed generate
-
由 Rafael Mendonça França 提交于
Correct Documentation for asset_tag_helpers
-
由 ShunsukeAida 提交于
-
由 Aditya Kapoor 提交于
-
由 Rafael Mendonça França 提交于
Refactor the type casting of booleans in MySQL
-
由 Sean Griffin 提交于
-
由 Matthew Draper 提交于
Remove checks against `column.type` in abstract adapter quoting
-
由 Rafael Mendonça França 提交于
Add missing test case for quoting behavior
-
由 Sean Griffin 提交于
The intention is to eventually remove `column` from the arguments list both for `quote` and for `type_cast` entirely. This is the first step to that end.
-
- 26 5月, 2014 6 次提交
-
-
由 schneems 提交于
Let's say we just ran: ``` $ rails g migrate add_click_to_issue_assignment ``` We will get an error that looks like: ``` Could not find generator migrate. ``` This patch adds all existing migrations to the output to make it easier for a developer to find a valid migration. ``` Could not find generator "migrate". Please select a valid generator: Rails: assets controller generator helper integration_test mailer migration model resource scaffold scaffold_controller task ``` It would be nice to do some spelling detection and suggest alternatives, but for now this should help.
-
由 Sean Griffin 提交于
It appears that the only time that `quote` is called with a column, but without first calling `type_cast` is when where is called with an array. My previous pull request broke this behavior, without failing tests. This adds a test for the only case I can think of that exercises the `if column.type == :integer` branch of `quote` effectively.
-
由 Yves Senn 提交于
Add an interface for type objects to control Ruby => SQL
-
由 Sean Griffin 提交于
Adds the ability to save custom types, which type cast to non-primitive ruby objects.
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
-