- 05 5月, 2020 22 次提交
-
-
由 Ryuta Kamizono 提交于
In the past, we sometimes hit missing `Symbol#start_with?` and `Symbol#end_with?`. https://github.com/rails/rails/commit/63256bc5d7dd77b2cce82df46c53249dab2dc2a8 https://github.com/rails/rails/commit/a8e812964d711fa03843e76ae50f5ff81cdc9e00 So I proposed `Symbol#start_with?` and `Symbol#end_with?` to allow duck typing that methods for String and Symbol, then now it is available in Ruby 2.7. https://bugs.ruby-lang.org/issues/16348 Using `String#starts_with?` and `String#ends_with?` could not be gained that conveniency, so it is preferable to not use these in the future.
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Ryuta Kamizono 提交于
PERF: Improve performance of where when using an array of values
-
由 Ryuta Kamizono 提交于
More concise Arel `Or` ast and make `Or` visitor non recursive
-
由 Ryuta Kamizono 提交于
Fix `rewhere` to truly overwrite collided where clause by new where clause
-
由 Ryuta Kamizono 提交于
```ruby steve = Person.find_by(name: "Steve") david = Author.find_by(name: "David") relation = Essay.where(writer: steve) # Before relation.rewhere(writer: david).to_a # => [] # After relation.rewhere(writer: david).to_a # => [david] ``` For now `rewhere` only works for truly column names, doesn't work for alias attributes, nested conditions, associations. To fix that, need to build new where clause first, and then get attribute names from new where clause.
-
由 Eugene Kenny 提交于
Include parallelize :threads option in template when fork not available
-
由 Brandon Fish 提交于
-
由 Eugene Kenny 提交于
This is a remnant of the auto-explain feature, which was removed in d3688e02.
-
由 Eugene Kenny 提交于
Fix flakey destroyed_by_association tests
-
由 Eugene Kenny 提交于
Inspect time attributes with subsec
-
由 Jonathan Hefner 提交于
Example failure: https://buildkite.com/rails/rails/builds/68661#84f8790a-fc9e-42ef-a7fb-5bd15a489de8/1002-1012 The failing `destroyed_by_association` tests create an author (a DestroyByParentAuthor) and a book (a DestroyByParentBook) that belongs to that author. If the database already contains books that refer to that author's ID from previous tests (i.e. tests that disabled `use_transactional_tests`), then one of those books will be loaded and destroyed instead of the intended DestroyByParentBook book. By loading the `:books` fixtures, we ensure the database does not contain such unexpected books. Co-authored-by: NEugene Kenny <elkenny@gmail.com> Co-authored-by: NRyuta Kamizono <kamipo@gmail.com>
-
由 akinomaeni 提交于
before ``` p Knot.create => #<Knot id: 1, created_at: "2016-05-05 01:29:47"> ``` after ``` p Knot.create => #<Knot id: 1, created_at: "2016-05-05 01:29:47.116928000"> ```
-
由 Aaron Patterson 提交于
Style fix for CachingKeyGenerator
-
由 Jack McCracken 提交于
-
由 Aaron Patterson 提交于
Add a separator to the cache key for ActiveSupport::CachingKeyGenerator
-
由 Jack McCracken 提交于
-
由 Aaron Patterson 提交于
Remove hashing from secure_compare and clarify documentation
-
由 Jack McCracken 提交于
-
- 04 5月, 2020 8 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Adds :inline option to Action Mailbox generator rails_command
-
由 Abhay Nikam 提交于
-
由 Kasper Timm Hansen 提交于
Support reentrant calls to RakeCommand.perform
-
由 Jonathan Hefner 提交于
Rake stores the current top-level task and arguments in global state. Invoking another top-level task within the same process requires overwriting this state. Doing so indiscriminately can cause incorrect behavior, such as infinitely repeating the original task. In particular, this is a problem when running one task from another via `rails_command "...", inline: true`. The solution is to save and restore the global state in each call to `RakeCommand.perform` using the `Rake.with_application` method. Fixes #39128.
-
由 Kasper Timm Hansen 提交于
[ActiveStorage] Rewrite Blob.unattached scope code using where.missing
-
由 fatkodima 提交于
-
- 03 5月, 2020 10 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Eugene Kenny 提交于
Allow associations to be autosaved multiple times
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Eugene Kenny 提交于
Since 901d62c5, associations can only be autosaved once: after a record has been saved, `@new_record_before_save` will always be false. This assumes that records only transition to being persisted once, but there are two cases where it happens multiple times: when the transaction that saved the record is rolled back, and when the persisted record is later duplicated.
-
由 Xavier Noria 提交于
Fix `modules_for_helpers` to will raise `MissingHelperError`
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Deprecate marshalling load from legacy attributes format
-
由 Ryuta Kamizono 提交于