1. 06 10月, 2018 1 次提交
  2. 29 9月, 2018 2 次提交
    • Y
      Add `Style/RedundantFreeze` to remove redudant `.freeze` · aa3dcabd
      Yasuo Honda 提交于
      Since Rails 6.0 will support Ruby 2.4.1 or higher
      `# frozen_string_literal: true` magic comment is enough to make string object frozen.
      This magic comment is enabled by `Style/FrozenStringLiteralComment` cop.
      
      * Exclude these files not to auto correct false positive `Regexp#freeze`
       - 'actionpack/lib/action_dispatch/journey/router/utils.rb'
       - 'activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb'
      
      It has been fixed by https://github.com/rubocop-hq/rubocop/pull/6333
      Once the newer version of RuboCop released and available at Code Climate these exclude entries should be removed.
      
      * Replace `String#freeze` with `String#-@` manually if explicit frozen string objects are required
      
       - 'actionpack/test/controller/test_case_test.rb'
       - 'activemodel/test/cases/type/string_test.rb'
       - 'activesupport/lib/active_support/core_ext/string/strip.rb'
       - 'activesupport/test/core_ext/string_ext_test.rb'
       - 'railties/test/generators/actions_test.rb'
      aa3dcabd
    • M
      Documentation clarity in ActiveJob::TestHelper [ci skip] (#33571) · 9fa43429
      Mohit Natoo 提交于
      * Documentation clarity in ActiveJob::TestHelper [ci skip]
      
      * Documentation for options
      
      [Mohit Natoo + Rafael Mendonça França]
      9fa43429
  3. 27 9月, 2018 1 次提交
    • E
      Add a way to check for subset of arguments when performing jobs: · 4d75f589
      Edouard CHIN 提交于
      - When calling `assert_performed_with`/`assert_enqueued_with`, the
        +args+ needs to match exactly what the job get passed.
      
        Some jobs can have lot of arguments, or even a simple hash argument
        has many key. This is not convenient to test as most tests doesn't
        need to check if the arguments matches perfectly.
      
        This PR make it possible to only check if a subset of arguments were
        passed to the job.
      4d75f589
  4. 26 9月, 2018 1 次提交
  5. 24 9月, 2018 1 次提交
  6. 22 9月, 2018 1 次提交
  7. 21 9月, 2018 1 次提交
  8. 17 9月, 2018 2 次提交
    • J
      Ignore psqlrc files when executing psql commands · 69e0e0ac
      J Smith 提交于
      psqlrc files can affect the execution of commands in ways that can hold
      up execution by blocking or otherwise cause unexpected side effects and
      should best be ignored when using psql programmatically.
      69e0e0ac
    • B
      Print correct rake command on running AJ integration tests · 237ef953
      bogdanvlviv 提交于
      Currently when executing `bundle exec rake test:integration` under `activejob/`
      derectory, it prints helpful info like:
      ```
      (snip)
      *** rake aj:integration:async ***
      (snip)
      *** rake aj:integration:delayed_job ***
      (snip)
       ```
      but  there is no defined `:aj` scope  in `activejob/Rakefile`,
      so I think output should be like:
      ```
      (snip)
      *** rake test:integration:async ***
      (snip)
      *** rake test:integration:delayed_job ***
      (snip)
       ```
      
      By the way `rake test:integration` doesn't work if execute it without
      prepending `bundle exec` to that command. It is probably what we should
      fix too.
      237ef953
  9. 16 9月, 2018 1 次提交
  10. 14 9月, 2018 1 次提交
  11. 13 9月, 2018 2 次提交
    • B
      Add changelog entries for #33849 [ci skip] · 5a212939
      bogdanvlviv 提交于
      Since these changes related to the public API, I think we should add
      changelog entries.
      
      Related to #33838, #33849
      5a212939
    • R
      Include test helpers when ActionDispatch::IntegrationTest is loaded · 64a9759a
      Ricardo Díaz 提交于
      As @dhh brings up, the point of `ActionDispatch::IntegrationTest` is to
      allow users to test the integration of all the pieces called by a
      controller. Asserting about the emails and jobs queued is part of that
      task.
      
      This commit includes the `ActionMailer::TestHelper` and
      `ActiveJob::TestHelper` modules when the ActionMailer and ActiveJob
      railties are initialized respectively.
      64a9759a
  12. 12 9月, 2018 1 次提交
  13. 09 9月, 2018 2 次提交
  14. 08 9月, 2018 1 次提交
  15. 31 8月, 2018 1 次提交
  16. 30 8月, 2018 1 次提交
  17. 29 8月, 2018 1 次提交
  18. 27 8月, 2018 1 次提交
  19. 25 8月, 2018 1 次提交
  20. 22 8月, 2018 1 次提交
    • U
      Remove duplicate test · 96ac7e4c
      utilum 提交于
      This patch corrects a duplicate method name introduced in #33635.
      
      Also fixes typo in method names.
      96ac7e4c
  21. 20 8月, 2018 9 次提交
  22. 18 8月, 2018 1 次提交
    • Y
      Increment execution count before deserialize arguments · e49fb792
      yuuji.yaginuma 提交于
      Currently, the execution count increments after deserializes arguments.
      Therefore, if an error occurs with deserialize, it retries indefinitely.
      
      In order to prevent this, the count is moved before deserialize.
      Fixes #33344.
      e49fb792
  23. 16 8月, 2018 2 次提交
  24. 10 8月, 2018 1 次提交
  25. 09 8月, 2018 1 次提交
  26. 24 7月, 2018 1 次提交
  27. 21 7月, 2018 1 次提交