add #23980 to release notes [ci skip]

Fix ActiveRecord::LogSubscriber edge case

This reverts commit 0ce7eae7.

Tests were broken https://travis-ci.org/rails/rails/jobs/131850726#L520

Remove magic comment in generated `schema.rb`

[Rafael Mendonça França + Nick Sutterer + thedarkone]

This way we don't have to make multiple calls on anonymous controllers

[Action View] Don't create middleman `DetailsKey` instance

Update comment for #retrieve_connection_pool

After PR https://github.com/rails/rails/pull/24844 the documentation for
`#retrieve_connection_pool` was out of date. This commit changes:

- the reference from `@class_to_pool` to `@owner_to_pool`.
- with newer Rubies, `#fetch` isn't significantly slower than `#[]`. Since Rails 5
requires Ruby >= 2.2.2, we can just use `#fetch` here.

fix module name [ci skip]

Add back in Oxford Comma

per [API documentation guidelines](http://edgeguides.rubyonrails.org/api_documentation_guidelines.html#oxford-comma)

[ci skip]

fix named route example [ci skip]

Ruby 2.4 unifies Fixnum and Bignum into Integer: https://bugs.ruby-lang.org/issues/12005

* Forward compat with new unified Integer class in Ruby 2.4+.
* Backward compat with separate Fixnum/Bignum in Ruby 2.2 & 2.3.
* Drops needless Fixnum distinction in docs, preferring Integer.

Fixes Inflector#titleize to work with SafeBuffer

Improve method description

Method description improved to reflect little bit more complicated scenario when names are camel-cased.

Removing redundant 'happens' in callbacks documentation

`md5` --> `MD5`

Sorry, I missed a few places in my last PR. This should be the last of
'em 😬

update to make it less obvious that this guide is from 2008/2009

Using locals will cause layouts to be cached multiple times in the
template cache.  This commit removes locals from consideration when
looking up the layout.

* Update documentation about Safari 4 supporting http only cookie

- Source: www.greebo.net/2009/06/09/httponly-in-safari-40-release/ via http://stackoverflow.com/questions/528405/which-browsers-do-support-httponly-cookies

Fix security guide capitalization errors

malicious ads are neither new nor unusual
live HTTP headers project is dead - see https://www.mozdev.org/bugs/show_bug.cgi?id=25944

All of this is `nodoc`'ed, so we shouldn't have to worry about breaking
changes, if there are any -- all internal API :).

Add Attributes API to release notes [ci skip]

Would have submitted to docrails, but this guide was just changed today,
and docrails doesn't have the most updated version 😬

cc @vipulnsward

[ci skip]

`md5` --> `MD5`

Update the Rails security guide [ci skip]

[ci skip]

Leftover from an earlier commit, chose to fix because I was
just down in this file.

Per request digest caches were added before we had hooks into
different units of work that Rails performs.

As such the most reliable way to prevent stale cache digests
was with a middleware. The middleware prevented staleness in
Action Controller requests.

However, the executor is superior because it should also prevent
staleness when running just Active Job jobs or broadcasting
through Action Cable's server.

Bring up-to-date the information about the session id in the
Sessions section. The guide currently says that the session
id is a md5 hash while the implementation uses a random hex
string.

Fixes #25032.

[ci skip]

Forward ActiveRecord::Relation#count to Enumerable#count if block given