- 26 2月, 2017 16 次提交
-
-
由 Andrew White 提交于
Remove useless `select_values += select_values`
-
由 Andrew White 提交于
Use released arel
-
由 yuuji.yaginuma 提交于
Follow up to ea9566f6
-
由 Ryuta Kamizono 提交于
`select_values` is a local variable defined at previous line. `select_values += select_values` is totally useless.
-
由 Nick Johnstone 提交于
It's common in test cases at my job to have code like this: let(:today) { customer_start_date + 2.weeks } let(:earlier_date) { today - 5.days } With this change, we can instead write let(:today) { 2.weeks.after(customer_start_date) } let(:earlier_date) { 5.days.before(today) } Closes #27721
-
由 Kasper Timm Hansen 提交于
Fix typo 'affect' -> 'effect' [ci skip]
-
由 Rebecca Skinner 提交于
-
由 Ryuta Kamizono 提交于
Currently `change_column` cannot drop default if `null: false` is specified at the same time. This change fixes the issue. ```ruby # cannot drop default change_column "tests", "contributor", :boolean, default: nil, null: false # we need the following workaround currently change_column "tests", "contributor", :boolean, null: false change_column "tests", "contributor", :boolean, default: nil ``` Closes #26582
-
由 Kasper Timm Hansen 提交于
AS CHANGELOG Pass
-
由 Vipul A M 提交于
-
由 Matthew Draper 提交于
Deprecate AbstractAdapter#verify! with arguments
-
由 Matthew Draper 提交于
Use ensure block for things we cleanup in tests
-
由 Ryuta Kamizono 提交于
`DISTINCT` clause is applied inside aggregate function by `operation_over_aggregate_column` if needed. Unneeded outside aggregate function. ```ruby # Before author.unique_categorized_posts.count # => SELECT DISTINCT COUNT(DISTINCT "posts"."id") FROM "posts" INNER JOIN "categorizations" ON "posts"."id" = "categorizations"."post_id" WHERE "categorizations"."author_id" = ? [["author_id", 2]] # After author.unique_categorized_posts.count # => SELECT COUNT(DISTINCT "posts"."id") FROM "posts" INNER JOIN "categorizations" ON "posts"."id" = "categorizations"."post_id" WHERE "categorizations"."author_id" = ? [["author_id", 2]] ``` Closes #27615
-
由 Kir Shatrov 提交于
-
由 Kir Shatrov 提交于
-
由 Andrew White 提交于
In ca324a0d the flash middleware was effectively removed by its constructor returning the app it was passed and the `commit_flash` call was moved to the `ActionController::Metal#dispatch` method. This broke any redirect routes that modified the flash because the redirect happens before `dispatch` gets called. To fix it, this commit adds a `commit_flash` call in the `serve` method of `ActionDispatch::Routing::Redirect`. Fixes #27992.
-
- 25 2月, 2017 21 次提交
-
-
由 Jon Moss 提交于
Improve docs for Rails::AppGenerator. [ci skip]
-
由 Andrew White 提交于
-
由 dixpac 提交于
Add example so its easier to understand how one can overide an app generator.
-
由 Ryuta Kamizono 提交于
-
由 Matthew Draper 提交于
-
由 Richard Schneeman 提交于
[close #24435] Send user_supplied_options to server
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
Closes #27429
-
-
由 John Hawthorn 提交于
In Ruby 2.4, BigDecimal(), as used by the Decimal cast, was changed so that it will raise ArgumentError when passed an invalid string, in order to be more consistent with Integer(), Float(), etc. The other numeric types use ex. to_i and to_f. Unfortunately, we can't simply change BigDecimal() to to_d. String#to_d raises errors like BigDecimal(), unlike all the other to_* methods (this should probably be filed as a ruby bug). Instead, this simulates the existing behaviour and the behaviour of the other to_* methods by finding a numeric string at the start of the passed in value, and parsing that using BigDecimal(). See also https://bugs.ruby-lang.org/issues/10286 https://github.com/ruby/bigdecimal/commit/3081a627cebdc1fc119425c7a9f009dbb6bec8e8
-
由 Matthew Draper 提交于
Soft-deprecate the `HashWithIndifferentAccess` constant
-
由 Rafael Mendonça França 提交于
Allow ActiveSupport::MarshalWithAutoloading#load to take a Proc
-
由 Rafael Mendonça França 提交于
-
由 Rafael França 提交于
Add missing gzip footer check in ActiveSupport::Gzip.decompress
-
由 Robin Dupret 提交于
This ensures that if we try to hard-deprecate it again in the future, we won't break these behaviors.
-
由 Robin Dupret 提交于
Since using a `ActiveSupport::Deprecation::DeprecatedConstantProxy` would prevent people from inheriting this class and extending it from the `ActiveSupport::HashWithIndifferentAccess` one would break the ancestors chain, that's the best option we have here.
-
由 Dylan Thacker-Smith 提交于
A gzip file has a checksum and length for the decompressed data in its footer which isn't checked by just calling Zlib::GzipReader#read. Calling Zlib::GzipReader#close must be called after reading to the end of the file causes this check to be done, which is done by Zlib::GzipReader.wrap after its block is called.
-
由 Jeff Latz 提交于
-
由 Eileen M. Uchitelle 提交于
Change `SystemTestCase.driven_by` to use `setup`/`teardown` hooks
-
由 Lucas Mazza 提交于
Previously, `driven_by` would change the Capybara configuration when the test case is loaded, and having multiple test classes with different `driven_by` configs would fail as the last loaded would be effective.
-
由 schneems 提交于
Currently when Puma gets a `:Port` it doesn't know if it is Rails' default port or if it is one that is specified by a user. Because of this it assumes that the port passed in is always a user defined port and therefor 3000 always "wins" even if you specify `port` inside of the `config/puma.rb` file when booting your server with `rails s`. The fix is to record the options that are explicitly passed in from the user and pass those to the Puma server (or all servers really). Puma then has enough information to know when `:Port` is the default and when it is user defined. I went ahead and did this for all values rails server exposes as server side options for completeness. The hardest thing was converting the input say `-p` or `--port` into the appropriate "name", in this case `Port`. There may be a more straightforward way to do this with Thor, but I'm not an expert here. Move logic for parsing user options to method Better variable name for iteration Explicitly test `--port` user input
✂ ️ Update array if environment variables are used
-
- 24 2月, 2017 3 次提交
-
-
由 Rafael França 提交于
does not show hidden namespaces in generator's help
-
由 Rafael França 提交于
Merge pull request #28062 from y-yagi/make_adding_gemfile_entry_work_even_if_specify_only_the_plugin_name Make adding gemfile entry work even if specify only the plugin name
-
由 Rafael França 提交于
Improve docs for ActiveRecord::Result. [ci skip]
-