- 18 3月, 2015 10 次提交
-
-
由 Alexander Leishman 提交于
Update link in comments to point to latest MySQL production version documentation. See here for reference: http://dev.mysql.com/doc/refman/5.0/en/choosing-version.html
-
由 Yves Senn 提交于
Fix NullRelation.update_all and .exists? signature to match the same on Relation
-
由 Ben Woosley 提交于
-
由 Abdelkader Boudih 提交于
Fix wrong model name for 'Articles', It should be 'Article' [ci skip]
-
由 Santosh Wadghule 提交于
- Also changed 'a' to 'an' for 'Article' word.
-
由 Rafael Mendonça França 提交于
Compare content_type with Mime::XML instead of regexp
-
由 Rafael Mendonça França 提交于
Skip the `:race_condition_ttl` branch if the option is 0 or nil.
-
由 Yves Senn 提交于
Add config.active_record.dump_schemas.
-
由 Ryan Wallace 提交于
Fixes db:structure:dump when using schema_search_path and PostgreSQL extensions. Closes #17157.
-
由 Rafael Mendonça França 提交于
Drop `references_eager_loaded_tables?` test from `has_include?`
-
- 17 3月, 2015 14 次提交
-
-
由 Ben Woosley 提交于
It is redundant with tests in `eager_loading?`, but for the difference between `includes_values.present?` and `includes_values.any?`, which is a difference without a distinction because `false` has no meaning for `includes`.
-
由 Yves Senn 提交于
Fix deprecation warning in rails_info_controller tests
-
由 Semyon Pupkov 提交于
Use keyword arguments in request methods
-
由 Arthur Nogueira Neves 提交于
Remove unused variable in activerecord reflection_test.
-
由 Juanito Fatas 提交于
-
由 Abdelkader Boudih 提交于
[ci skip] reflection doc fix about hierarchy
-
由 keepcosmos 提交于
-
由 Rafael Mendonça França 提交于
Materialize subqueries by adding `DISTINCT` to suport MySQL 5.7.6 and later
-
由 Rafael Mendonça França 提交于
Renaming transactional fixtures to transactional tests
-
由 Brandon Weiss 提交于
I’m renaming all instances of `use_transcational_fixtures` to `use_transactional_tests` and “transactional fixtures” to “transactional tests”. I’m deprecating `use_transactional_fixtures=`. So anyone who is explicitly setting this will get a warning telling them to use `use_transactional_tests=` instead. I’m maintaining backwards compatibility—both forms will work. `use_transactional_tests` will check to see if `use_transactional_fixtures` is set and use that, otherwise it will use itself. But because `use_transactional_tests` is a class attribute (created with `class_attribute`) this requires a little bit of hoop jumping. The writer method that `class_attribute` generates defines a new reader method that return the value being set. Which means we can’t set the default of `true` using `use_transactional_tests=` as was done previously because that won’t take into account anyone using `use_transactional_fixtures`. Instead I defined the reader method manually and it checks `use_transactional_fixtures`. If it was set then it should be used, otherwise it should return the default, which is `true`. If someone uses `use_transactional_tests=` then it will overwrite the backwards-compatible method with whatever they set.
-
由 Rafael Mendonça França 提交于
Move Adapter to private constant
-
由 Yasuo Honda 提交于
to support MySQL 5.7.6 `optimizer_switch='derived_merge=on'`
-
由 Abdelkader Boudih 提交于
Adds more clarity on how to use custom rake tasks with arguments passed to it [ci skip]
-
由 Mohnish G J 提交于
-
- 16 3月, 2015 6 次提交
-
-
由 Semyon Pupkov 提交于
-
由 Boris Peterbarg 提交于
Regexp is broken for both content types including charsets and for integration tests, where the content_type is a Mime::Type and not String
-
由 Xavier Noria 提交于
[skip ci] Fix typos in guides
-
由 Anton Davydov 提交于
-
由 Arun Agrawal 提交于
[skip ci] Fix typo in actionmailer documentation
-
由 Anton Davydov 提交于
-
- 15 3月, 2015 10 次提交
-
-
由 Arthur Nogueira Neves 提交于
[ci skip] Fix dead link
-
由 eileencodes 提交于
If there was a polymorphic hm:t association with a scope AND second non-scoped hm:t association on a model the polymorphic scope would leak through into the call for the non-polymorhic hm:t association. This would only break if `hotel.drink_designers` was called before `hotel.recipes`. If `hotel.recipes` was called first there would be no problem with the SQL. Before (employable_type should not be here): ``` SELECT COUNT(*) FROM "drink_designers" INNER JOIN "chefs" ON "drink_designers"."id" = "chefs"."employable_id" INNER JOIN "departments" ON "chefs"."department_id" = "departments"."id" WHERE "departments"."hotel_id" = ? AND "chefs"."employable_type" = ? [["hotel_id", 1], ["employable_type", "DrinkDesigner"]] ``` After: ``` SELECT COUNT(*) FROM "recipes" INNER JOIN "chefs" ON "recipes"."chef_id" = "chefs"."id" INNER JOIN "departments" ON "chefs"."department_id" = "departments"."id" WHERE "departments"."hotel_id" = ? [["hotel_id", 1]] ``` From the SQL you can see that `employable_type` was leaking through when calling recipes. The solution is to dup the chain of the polymorphic association so it doesn't get cached. Additionally, this follows `scope_chain` which dup's the `source_reflection`'s `scope_chain`. This required another model/table/relationship because the leak only happens on a hm:t polymorphic that's called before another hm:t on the same model. I am specifically testing the SQL here instead of the number of records becasue the test could pass if there was 1 drink designer recipe for the drink designer chef even though the `employable_type` was leaking through. This needs to specifically check that `employable_type` is not in the SQL statement.
-
由 Andrew White 提交于
add mailer suffix to comments for email previews
-
由 Claudio B. 提交于
[ci skip]Doc fix about association hierarchy
-
由 keepcosmos 提交于
-
由 yuuji.yaginuma 提交于
-
由 Carlos Antonio da Silva 提交于
Cleaning actionview tests
-
由 Arun Agrawal 提交于
Fix typo in Action Pack changelog
-
由 Mike Naberezny 提交于
-