- 18 7月, 2019 5 次提交
-
-
由 Ryuta Kamizono 提交于
Revert "Merge pull request #36676 from wjessop/change_activestorage_metadata_duration_to_bound"
-
由 Yuji Yaginuma 提交于
Add `skip-collision-check` option to generator
-
由 Rafael França 提交于
Don't include routes helpers inside System test class:
-
由 Eileen M. Uchitelle 提交于
Revert "Make UTF-8 string requirement explicit for `ActiveSupport::Inflector.transliterate`"
-
由 Cliff Pruitt 提交于
-
- 17 7月, 2019 14 次提交
-
-
由 Eileen M. Uchitelle 提交于
Make UTF-8 string requirement explicit for `ActiveSupport::Inflector.transliterate`
-
由 Ryuta Kamizono 提交于
Support beginless ranges in hash conditions.
-
由 Josh Goodall 提交于
Ruby 2.7 introduces beginless ranges (..value and ...value) and as with endless ranges we can turn these into inequalities, enabling expressions such as Order.where(created_at: ..1.year.ago) User.where(karma: ...0)
-
由 Kasper Timm Hansen 提交于
Merge pull request #36635 from abhaynikam/36332-fix-engine-documentation-to-remove-js-directory-mention Fixed the engine documentation to not mention of assets/javascript in directory structure [ci skip]
-
由 Ryuta Kamizono 提交于
This reverts commit a307c697, reversing changes made to f30f76af. Reason: This assertion is not failed even without this PR since both ffprobe versions (3.2.14 and 4.1.3) return the same duration 5.166648 for `video.mp4`. So there is no need to touch this assertion at this point.
-
由 Rafael França 提交于
[ActiveRecord] Superclass for aborted queries
-
由 Kir Shatrov 提交于
-
由 Edouard CHIN 提交于
- https://github.com/rails/rails/pull/36283 made a change to make SystemTest inherits from ActiveSupport::TestCase instead of ActionDispatch::IntegrationTest. With this change, the route helpers are now directly included inside the SystemTest class. This causes an edge case in case you have a routes whos name starts with `test_`, minitest will consider it as a test and will try to run it https://github.com/seattlerb/minitest/blob/ab39d35fb4e84eb866ed9c4ecb707cbf3889de42/lib/minitest/test.rb#L66 This PR uses a proxy and deleted missing method to a dummy class that has all the route helpers.
-
由 Rafael Mendonça França 提交于
-
由 Rafael França 提交于
Raise specific exception on Mysql2::Error::TimeoutError
-
由 Kir Shatrov 提交于
-
由 Rafael França 提交于
Update message verifier documentation [ci skip]
-
由 Cliff Pruitt 提交于
It's noted in #34062 that String#parameterize will raise an `Encoding::CompatibilityError` if the string is not UTF-8 encoded. The error is raised as a result of passing the string to `.unicode_normalize`. This PR raises a higher level `ArgumentError` if the provided string is not UTF-8 and updates documentation to note the encoding requirement.
-
由 Gannon McGibbon 提交于
Specify log subscribers need a logger set before they can receive events
-
- 16 7月, 2019 18 次提交
-
-
由 Rafael França 提交于
Fix Loadable.exclude_from to also reset Kernel#require
-
由 Rafael França 提交于
Move the `ActiveModel:Errors#full_message` method to the `Error` class:
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
Reduce log noise handling ActionController::RoutingErrors
-
由 Edouard CHIN 提交于
- Since `ActiveModel::Error` can now be inherited by `ActiveModel::NestedError`, when the latter generates a `full_message`, the `i18n_customize_full_message` accessor set in the parent class is not set. This commit fixes that by using a `class_attribute` instead.
-
由 Edouard CHIN 提交于
- One regression introduced by the "AM errors as object" features is about the `full_messages` method. It's currently impossible to call that method if the `base` object passed in the constructor of `AM::Errors` doesn't respond to the `errors` method. That's because `full_messages` now makes a weird back and forth trip `AM::Errors#full_messages` -> `AM::Error#full_message` -> `AM::Errors#full_message` Since `full_message` (singular) isn't needed by AM::Errors, I moved it to the `AM::Error` (singular) class. This way we don't need to grab the `AM::Errors` object from the base.
-
由 Jean Boussier 提交于
-
由 Matthew Draper 提交于
Fix problem with accessing deprecated constant proxy's subclass
-
由 Rafael França 提交于
Add hash method to ActionController::Parameters
-
由 Rafael França 提交于
Different versions of ffprobe can return subtly different video lengths
-
由 Rafael França 提交于
Return a copy of the cache entry when local_cache exists:
-
由 Ryuta Kamizono 提交于
-
由 Rafael França 提交于
Returns `nil` when `AM::Errors#delete` doesn't delete anything:
-
由 Rafael França 提交于
Fix `AM::Errors.added?` trying to generate a message:
-
由 Rafael França 提交于
Fix errors getting duplicated when passed validations options:
-
由 Ryuta Kamizono 提交于
In older Ruby, nil, Symbol, Fixnum, Rational, and Complex were not duplicable. In Ruby 2.5, all of them are duplicable.
-
由 Eileen M. Uchitelle 提交于
Delete mention of Ruby 1.9 [skip ci]
-
- 15 7月, 2019 3 次提交
-
-
由 Gannon McGibbon 提交于
The current example code for `ActiveSupport::LogSubscriber` mysteriously fails if you're using it outside of Rails. This helps clarify a logger needs to be set first before log subscribers can process events. [ci skip]
-
由 Gannon McGibbon 提交于
Empty array instead of nil for source_extract
-
由 David Heinemeier Hansson 提交于
This is the only use of it
-