- 24 10月, 2016 1 次提交
-
-
由 Jon Moss 提交于
[ci skip]
-
- 23 10月, 2016 7 次提交
-
-
由 प्रथमेश Sonpatki 提交于
- Followup of fda5afeb
-
由 Vipul A M 提交于
Add info about updating locking column value
-
由 bogdanvlviv 提交于
[ci skip] Follow #26050
-
由 Sean Griffin 提交于
This reverts commit 671eb742. This is not a change we would like moving forward.
-
由 Guillermo Iguaran 提交于
-
由 Guillermo Iguaran 提交于
-
由 Rafael França 提交于
Revert #26826 and add documentation
-
- 22 10月, 2016 20 次提交
-
-
由 claudiob 提交于
This reverts commit a01cf703 as explained in the comment to #26826: Realized that this PR caused the following warning in Travis CI: ``` /home/travis/build/rails/rails/activesupport/lib/active_support/dependencies.rb:293: warning: loading in progress, circular require considered harmful - /home/travis/build/rails/rails/activesupport/lib/active_support/core_ext/hash/indifferent_access.rb ``` Indeed, `active_support/core_ext/hash/indifferent_access.rb` **needs** to require `active_support/hash_with_indifferent_access.rb` in order to access the class `ActiveSupport::HashWithIndifferentAccess`. The other way around, though, is not _strictly_ required, unless someone tries (like I did in the [gist above](https://gist.github.com/claudiob/43cc7fe77ff95951538af2825a71e5ec)) to use `ActiveSupport::HashWithIndifferentAccess` by only requiring `active_support/hash_with_indifferent_access.rb` without first requiring `active_support/core_ext/hash/indifferent_access.rb`. I think the solution to this is to revert this PR and instead change the documentation to explicitly state that **developers should not require 'active_support/hash_with_indifferent_access'** if all they want is to use `ActiveSupport::HashWithIndifferentAccess` – instead they should require `active_support/core_ext/hash/indifferent_access.rb`.
-
由 Rafael França 提交于
Refactored ActiveModel::Type tests into their own files
-
由 Rafael Mendonça França 提交于
Convert ActionController::Parameters to a hash in button_to
-
由 Rafael França 提交于
Fix regression caused due to removal of select method from CollectionAssociation
-
由 Prathamesh Sonpatki 提交于
- CollectionAssociation#select was removed in https://github.com/rails/rails/pull/25989 in favor of QueryMethods#select but it caused a regression when passing arguments to select and a block. - This used to work earlier in Rails 4.2 and Rails 5. See gist https://gist.github.com/prathamesh-sonpatki/a7df922273473a77dfbc742a4be4b618. - This commit restores the behavior of Rails 4.2 and Rails 5.0.0 to allow passing arguments and block at the same time but also deprecates it. - Because, these arguments do not have any effect on the output of select when select is used with a block. - Updated documentation to remove the example passing arguments and block at the same time to `CollectionProxy#select`.
-
由 Rafael França 提交于
Fix `ActiveSupport::TimeZone#strptime` cannot parse timestamps (%Q, %s)
-
由 Claudio B 提交于
Add missing require in active_support/hash_with_indifferent_access.rb
-
由 Guillermo Iguaran 提交于
Lazy-load blade for actioncable tests; no blade on JRuby.
-
由 Charles Oliver Nutter 提交于
-
由 Kasper Timm Hansen 提交于
Soften this test since YAML.dump may produce keys in other orders.
-
由 Aaron Patterson 提交于
We need to use on_load so that plugins will get the same functionality
-
由 Charles Oliver Nutter 提交于
-
由 Aaron Patterson 提交于
The test framework should not be autoloaded in production mode. Before this commit, the testing railtie would extend AS::TestCase. This caused AS::TestCase to be preloaded regardless of the environment in which we were running. This commit just moves the code that adds line filtering support in to the test command where we actually execute the test runner. That allows us to maintain the line runner feature but only load the minimal amount of code we need.
-
由 Aaron Patterson 提交于
Skip test that depends on RubyVM when it is not available (JRuby).
-
由 Charles Oliver Nutter 提交于
-
由 Rafael Mendonça França 提交于
This reverts commit 5dde413e. Reason: The gem defines it so we don't need to remove
-
由 Rafael França 提交于
Add examples of queue_adapter and perform_enqueued jobs to API Docs.
-
由 Aaron Patterson 提交于
Fixed: Optimistic locking does not work correctly
-
由 bogdanvlviv 提交于
-
由 bogdanvlviv 提交于
-
- 21 10月, 2016 12 次提交
-
-
由 Gabi Stefanini 提交于
-
由 Aaron Patterson 提交于
Additional fix for argument-splat ordering differences.
-
由 Aaron Patterson 提交于
Explicitly unpack the expanded args to avoid execution order diff.
-
由 Charles Oliver Nutter 提交于
See #26854
-
由 Charles Oliver Nutter 提交于
In https://bugs.ruby-lang.org/issues/12860 I argue that MRI's execution order here is incorrect. The splatting of the 'c' args should happen before the shift, but it happens after. On JRuby, it behaves the way you would expect, leading to the 'c' args splat still containing the block and producing an error like "cannot convert proc to symbol" when the send attempts to coerce it. This patch makes the unpacking order explicit with a multi-assign, which behaves properly on all implementations I tested.
-
由 Guillermo Iguaran 提交于
don't create db directory when skip active_record
-
由 José Gomes Júnior 提交于
-
由 denisovlev 提交于
-
由 Andrew White 提交于
Fix copy_time_to: Copy nsec instead of usec
-
由 Yves Senn 提交于
This is a follow up to #25681, specifically this comment: https://github.com/rails/rails/pull/25681#issuecomment-238294002 The way the thread local variable is stored is an implementation detail and subject to change. It makes no sense to only generate a reader or writer as you'd have to know where to read from or where it writes to.
-
由 Yves Senn 提交于
[ci skip] This was pointed out on https://github.com/rails/rails/issues/15583#issuecomment-239212831 The comment was lost in the changes made by fcd0ac06 and 3e1373a7
-
由 Yves Senn 提交于
-