- 17 5月, 2014 5 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
We are using that code path in only one place so we should not add a conditional to all the other cases. This will avoid performance regressions on the old paths.
- 16 5月, 2014 3 次提交
-
-
由 Arthur Neves 提交于
-
由 Arthur Neves 提交于
Make sure when we clean the `@_start_transaction_state` var we do it in the same code-path. Also this makes `clear_transaction_record_state`, more consistent with `restore_transaction_record_state`
-
由 Aaron Nelson 提交于
-
- 15 5月, 2014 5 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
They should not be used on people application so they should not be present on the API documentation.
-
由 Rafael Mendonça França 提交于
parent_name is a string of nil, never a blank string so we don't need to use presence.
-
由 Nat Budin 提交于
ActiveRecord::Relation::Merger's filter_binds method does not filter out bind variables when one of the attribute nodes has a string name, but the other has a symbol name, even when those names are actually equal. This can result in there being more bind variables than placeholders in the generated SQL. This is particularly an issue for PostgreSQL, where this is treated as an error. This patch changes the filter_binds method to make it convert both attribute names to strings before comparing.
-
由 Kuldeep Aggarwal 提交于
-
- 14 5月, 2014 10 次提交
-
-
由 Jessica Yao 提交于
[Brad Bennett, Jessica Yao, & Lakshmi Parthasarathy]
-
由 kares 提交于
-
由 kares 提交于
-
由 kares 提交于
-
由 kares 提交于
... 'shared' OID, ArrayParser and Cast helpers, also re-arranged Column's dependencies
-
由 eileencodes 提交于
this change was unneccsary as nothing was gained from it
-
由 eileencodes 提交于
Rename delete_all_records because this name better describes what the method is doing. We can then remove :all from the hm:t version and pull out the unoptimized call to load_target in delete_records and pass it directly.
-
由 eileencodes 提交于
Refactor delete_count method to only handle delete_all or nullify/nil cases and not destroy and switch to if/else rather than case statement. This refactoring allows removal of :all symbol usage.
-
由 eileencodes 提交于
Refactor by creating two methods delete_all_records and delete_records to be called by delete_all and delete (or destroy) respectively. This reduces the number of conditionals required to handle _how_ records get deleted. The new delete_count method handles how scope is applied to which delete action. A delete_all_records method also has to be called in has_many_through association because of how the methods are chained. This will be refactored later on.
-
由 kares 提交于
-
- 13 5月, 2014 3 次提交
-
-
由 Yves Senn 提交于
-
由 Kassio Borges 提交于
Thank's for @laurocaetano for the help with tests.
😃 Fixes #14709 -
由 Yves Senn 提交于
-
- 12 5月, 2014 6 次提交
-
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
Closes #10802.
-
由 Innokenty Mihailov 提交于
Before this patch `Infinity`, `-Infinity` and `Nan` were read as `0`.
-
由 Patrick Robertson 提交于
In #10410 it was noted that you can no longer create PK's with the type of bigserial in PostgreSQL in 4.0.0.rc1. This is mostly because the newer adapter is checking for column type with the id column instead of just letting it pass through like it did before. Side effects: You may just create a PK column of a type that you really don't want to be your PK. As far as I can tell this was allowed in 3.2.X and perhaps an exception should be raised if you try and do something extremely dumb.
-
由 Guillermo Iguaran 提交于
Improve documentation
-
由 Chris Beer 提交于
-
- 11 5月, 2014 1 次提交
-
-
由 Yves Senn 提交于
-
- 10 5月, 2014 5 次提交
-
-
由 Vijay Dev 提交于
-
由 Yves Senn 提交于
Closes #15024. These operations happen before instances are created. The current behavior is misleading and can result in broken behavior.
-
由 schneems 提交于
-
由 Zac 提交于
When scanning the Enum API page I found it easy to miss that scopes are generated. Adding an example clarifies use and has more... *pop*...
-
由 Arthur Neves 提交于
We are reverting these commits, because there are other caveats related to dirty attributes not being restored when a transaction is rollback. For instance, nested transactions cannot proper restore the dirty attributes state after a rollback. At the moment, the dirty attributes are scoped by the transaction. When we call `.save` on a record, the dirty attributes will be reset even if the transaction gets rollback. [related #13166] [related #15018] [related #15016] [closes #15019] This reverts commits * bab48f0a * b0fa7cf3. * 73fb39b6 * 37c23892. * 8d8d4f15 Revert "Merge pull request #13166 from bogdan/transaction-magic"
-
- 09 5月, 2014 2 次提交
-
-
由 Vijay Dev 提交于
-
由 Aaron Patterson 提交于
I wanted the middle model to be anonymous, but we have to give it a name for marshal support. :'(
-