- 13 9月, 2013 29 次提交
-
-
由 Godfrey Chan 提交于
TL;DR The primary driver is to remove autoload surprise. This is related to #12106. (The root cause for that ticket is that json/add defines Regexp#to_json among others, but here I'll reproduce the problem without json/add.) Before: >> require 'active_support/core_ext/to_json' => true >> //.as_json NoMethodError: undefined method `as_json' for //:Regexp from (irb):3 from /Users/godfrey/.rvm/rubies/ruby-2.0.0-p195/bin/irb:16:in `<main>' >> //.to_json => "\"(?-mix:)\"" >> //.as_json => "(?-mix:)" After: >> require 'active_support/core_ext/to_json' => true >> //.as_json => "(?-mix:)" This is because ActiveSupport::JSON is autoloaded the first time Object#to_json is called, which causes additional core extentions (previously defined in active_support/json/encoding.rb) to be loaded. When someone require 'active_support/core_ext', the expectation is that it would add certain methods to the core classes NOW. The previous behaviour causes additional methods to be loaded the first time you call `to_json`, which could cause nasty surprises and other unplesant side-effects. This change moves all core extensions in to core_ext/json. AS::JSON is still autoloaded on first #to_json call, but since it nolonger include the core extensions, it should address the aforementioned bug. *Requiring core_ext/object/to_json now causes a deprecation warnning*
-
由 Rafael Mendonça França 提交于
Deprecate the delegation of Array bang methods in ActiveRecord::Delegation Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/relation_test.rb
-
由 Rafael Mendonça França 提交于
Make CollectionAssociation first/last with integer fetch with query Conflicts: activerecord/CHANGELOG.md
-
由 Rafael Mendonça França 提交于
[ci skip]
-
由 Rafael Mendonça França 提交于
Let the SQLite rake tasks run without rails
-
由 Rafael Mendonça França 提交于
Allow Relation#from to accept other relations with bind values. Conflicts: activerecord/CHANGELOG.md
-
由 Rafael Mendonça França 提交于
[ci skip]
-
由 Rafael Mendonça França 提交于
do not break params filtering on nil values
-
由 Rafael Mendonça França 提交于
Copy-edits [ci skip]
-
由 Rafael Mendonça França 提交于
[ci skip] Documentation on how to create custom rake tasks.
-
由 Rafael Mendonça França 提交于
Remove unnecessary loop
-
由 Vipul A M 提交于
-
由 Rafael Mendonça França 提交于
"generates" applies to "collection radio" so it should be singular
-
由 Waynn Lue 提交于
I accidentally pushed this change to docrails before realizing that it's technically a code change, so I'm opening this pull request (and rolling back my change to docrails).
-
由 Rafael Mendonça França 提交于
[ci skip]
-
由 Rafael Mendonça França 提交于
form_for - fix :namespace and :as options clash Conflicts: actionview/CHANGELOG.md
-
由 Rafael Mendonça França 提交于
Removed semicolon and added space
-
由 Anupam Choudhury 提交于
-
由 Rafael Mendonça França 提交于
[ci skip] Add missing setting locale code snippet.
-
由 Rafael Mendonça França 提交于
This reverts commit ab5cd54b, reversing changes made to cdc10c89. Reason: This way of defining root path is still supported. See https://github.com/rails/rails/blob/d262773ab7f0aae5de2d354ac2eca168e95b653d/actionpack/test/controller/routing_test.rb#L450-457
-
由 Vijay Dev 提交于
-
由 Rafael Mendonça França 提交于
remove outdated docs
-
由 Michael Hoy 提交于
-
由 Rafael Mendonça França 提交于
Fix FileStore#cleanup to no longer rely on missing each_key method
-
由 Rafael Mendonça França 提交于
Enabled quirks mode on JSON.parse, fixes broken test in af9caae9
-
由 Godfrey Chan 提交于
It turns out that ActionPack depends on the decoder to parse JSON "fragments" (e.g. '"a string"', '1', 'null', etc), so we need to enable quirks mode on JSON.parse. Also added coverage on the decoder side to prevent regression.
-
由 Rafael Mendonça França 提交于
[ci skip]
-
由 Rafael Mendonça França 提交于
Cleanup: replace String concatenation by joining for excerpt helper
-
由 Rafael Mendonça França 提交于
-
- 12 9月, 2013 11 次提交
-
-
由 Rafael Mendonça França 提交于
Update 4_0_release_notes.md
-
由 Harshad Sabne 提交于
Active support --> Deprecations Code highlighted.
-
由 Rafael Mendonça França 提交于
Added quotes when defining the precision for the `decimal` fields
-
由 Rafael Mendonça França 提交于
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
Remove unused raw email fixtures
-
由 mogetutu 提交于
before: ```bash $ rails generate migration AddDetailsToProducts price:decimal{5,2} supplier:references{polymorphic} ``` after: ```bash $ rails generate migration AddDetailsToProducts 'price:decimal{5,2}' supplier:references{polymorphic} ```
-
由 Jeremy Kemper 提交于
Replace JSON.load with JSON.parse
-
由 Aaron Patterson 提交于
sense. Let's load the object to ensure it's an array and count the array.
-
由 Rafael Mendonça França 提交于
At the point we want to add the reflection we already know the reflection is of the AggregateReflection type so we can call a specific method
-