- 07 8月, 2016 2 次提交
-
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
-
- 26 7月, 2016 2 次提交
-
-
由 Steven Harman 提交于
-
由 Steven Harman 提交于
An optimization was introduced in https://github.com/rails/rails/commit/27f4ffd11a91b534fde9b484cb7c4e515ec0fe77 which tried to `#to_ary` the collection to prevent unnecessary queries for ActiveRecord scopes/relations. If the given collection did not respond to `#to_ary`, and empty collection was returned. That meant you couldn't use collections built from `Enumerator` nor `Enumerable`. With this change, `#collection_from_options` will attempt the optimization, but fall back to passing along the given collection, as-is.
-
- 25 7月, 2016 1 次提交
-
-
由 Xavier Noria 提交于
Where appropriate, prefer the more concise Regexp#match?, String#include?, String#start_with?, or String#end_with?
-
- 20 7月, 2016 1 次提交
-
-
- 17 7月, 2016 1 次提交
-
-
由 Rafael Mendonça França 提交于
setup in ActiveSupport::LogSubscriber::TestHelper call set_logger that will change ActionController::Base.logger to the MockLogger so that logger will be always MockLogger
-
- 29 6月, 2016 1 次提交
-
-
由 Vipul A M 提交于
- Renamed test to be more descriptive
-
- 28 6月, 2016 2 次提交
-
-
由 Vipul A M 提交于
This is based on https://github.com/kangax/html-minifier/blob/6b2d4536d82819143b468b41a89c700b6c61631f/src/htmlminifier.js#L197 and spec from https://www.w3.org/TR/html51/single-page.html. Couple of other changes to tests due to support update: - autobuffer has been dropped in favour of preload attribute, ref: https://msdn.microsoft.com/en-us/library/ff974743(v=vs.85).aspx - pubdate attribute has been dropped from spec, ref: https://www.w3.org/html/wg/tracker/issues/185
-
由 Marek 提交于
-
- 22 6月, 2016 3 次提交
-
-
由 Herminio Torres 提交于
A change was made in the helper that renders the `datetime`, being now by default `datetime-local` and creating an alias of `datetime-local` for `datetime`, `datetime` tag and it passes to be an abstract class for all other tags that inherit from him. As a new specification of the HTML 5 the text field type `datetime` will no longer exist and will pass a `datetime-local`. Ref: https://html.spec.whatwg.org/multipage/forms.html#local-date-and-time-state-(type=datetime-local)
-
由 eileencodes 提交于
The reason we are reverting this commit is because it created breaking changes for file upload gems. For more information see discussion here: https://github.com/rails/rails/issues/17947#issuecomment-225154294 This reverts commit c4558178, reversing changes made to 8b3cd74b. Conflicts: actionview/CHANGELOG.md actionview/lib/action_view/helpers/form_helper.rb
-
由 eileencodes 提交于
In PR #24929 the changelog was updated to make note that while the new template handler was changed to raw this changed the behavior when outputting plain html or js files. Previously ERB would output the files unescaped. Changing the default handler to RAW meant that these same files would be rendered as escaped rather than as js or html. Because of this change in behavior and after the discussion #24949 in we decided to change the behavior of the Raw handler to output html_safe strings by default. Now files rendered with the default handler (raw) render the file unescaped.
-
- 16 6月, 2016 5 次提交
-
-
由 Javan Makhmali 提交于
-
由 Javan Makhmali 提交于
-
由 Javan Makhmali 提交于
-
由 Javan Makhmali 提交于
-
由 Javan Makhmali 提交于
Fix digesting templates with identical logical names when requesting a format other than the first default
-
- 08 6月, 2016 1 次提交
-
-
由 Sean Griffin 提交于
This test was broken by f650e032. It was added by https://github.com/rails/rails/pull/17978, and is adequately tested elsewhere. The reason that this breaks is that `Controller#process` is not going to set a new response object, and we now terminate in callbacks if the response has been sent. The only reason that this test was calling `get` in the first place was because the controller under test blows up if `request` was `nil`. The point being that the failure is invalid, and I don't think we need to fix the test in this location.
-
- 05 6月, 2016 1 次提交
-
-
由 Marek 提交于
-
- 02 6月, 2016 1 次提交
-
-
由 Ryuta Kamizono 提交于
-
- 21 5月, 2016 2 次提交
-
-
由 Vipul A M 提交于
Confirm with the specification when generating emtpy option for select with `include_blank: true` option. We now generate option with empty label, example: `<select id="places" name="places"><option value="" label=" "></option></select>` for include_blank: true. This is only done, if content is missing on the option, and we providing the value from this option. Fixes #24816
-
由 Rafael Mendonça França 提交于
[Rafael Mendonça França + Nick Sutterer + thedarkone]
-
- 19 5月, 2016 1 次提交
-
-
由 Jeremy Daer 提交于
Ruby 2.4 unifies Fixnum and Bignum into Integer: https://bugs.ruby-lang.org/issues/12005 * Forward compat with new unified Integer class in Ruby 2.4+. * Backward compat with separate Fixnum/Bignum in Ruby 2.2 & 2.3. * Drops needless Fixnum distinction in docs, preferring Integer.
-
- 18 5月, 2016 2 次提交
-
-
由 Aaron Patterson 提交于
Using locals will cause layouts to be cached multiple times in the template cache. This commit removes locals from consideration when looking up the layout.
-
由 Aaron Patterson 提交于
-
- 10 5月, 2016 2 次提交
-
-
由 Kasper Timm Hansen 提交于
Will be using this in later code.
-
由 Kasper Timm Hansen 提交于
Each test executes in another tmp folder, so there's no chance of polluting another test run.
-
- 20 4月, 2016 1 次提交
-
-
由 Jeremy Daer 提交于
Object#inspect recursively inspects instance variables, exposing all internal state, including sensitive internal cache objects. Override Cache#inspect to give a high-level summary that never interferes with concurrent cache writes.
-
- 17 4月, 2016 1 次提交
-
-
由 Vipul A M 提交于
-
- 05 4月, 2016 1 次提交
-
-
由 neumayr 提交于
`date_select` helper `:with_css_classes` option now accepts a hash of strings for `:year`, `:month`, `:day`, `:hour`, `:minute`, `:second` that will extend the select type with the given css class value. ```erb <%= f.date_select :birthday, with_css_classes: { month: "my-month", year: "my-year" } %> ``` ```html <select id="user_birthday_3i" name="user[birthday(3i)]">…</select> <select id="user_birthday_2i" name="user[birthday(2i)]" class="my-month">…</select> <select id="user_birthday_1i" name="user[birthday(1i)]" class="my-year">…</select> ``` Optional, add global `html_options` to modify every select tag in the set. ```erb <%= f.date_select :birthday, with_css_classes: { month: "my-month", year: "my-year" }, { class: "my-date optional" } %> ``` Supported DateHelper methods: `select_day`, `select_month`, `select_year`, `select_hour`, `select_minute`, `select_second`, `select_datetime`, `select_time`, `time_select`, `date_select` and `datetime_select`. `:with_css_classes` option was added to the `date_select` with #7975.
-
- 01 4月, 2016 1 次提交
-
-
由 Wojciech Wnętrzak 提交于
Datetime input type was removed from HTML specification. One can use `datetime_local_field` and `datetime_local_field_tag` instead.
-
- 16 3月, 2016 1 次提交
-
-
由 Neil Matatall 提交于
-
- 13 3月, 2016 1 次提交
-
-
由 yuuji.yaginuma 提交于
Follow up to #23980.
-
- 07 3月, 2016 1 次提交
-
-
由 Mehmet Emin İNAÇ 提交于
-
- 06 3月, 2016 1 次提交
-
-
由 Rafael Mendonça França 提交于
Revert "Merge pull request #22764 from stevenspiel/titleize_model_name_for_default_submit_button_value" This reverts commit 4158974c, reversing changes made to 3d590add. Reason: This break i18n in some languages. See https://github.com/rails/rails/issues/791#issuecomment-192724640
-
- 04 3月, 2016 1 次提交
-
-
由 Benjamin Quorning 提交于
When rendering a collection with a partial whose filename contains a dot, e.g. "customer.mobile", we would set a `locals[:'customer.mobile']` variable instead of, as in earlier versions of Rails, `locals[:customer]`. This bug was introduced in da9038ea.
-
- 01 3月, 2016 1 次提交
-
-
由 Godfrey Chan 提交于
`OptimizedFileSystemResolver` (which most Rails apps use), but did not implement the feature on the more generic `PathResolver`, which is often used in tests etc. Fixes #23881
-
- 28 2月, 2016 1 次提交
-
-
由 Arthur Neves 提交于
-
- 27 2月, 2016 1 次提交
-
-
由 Vipul A M 提交于
Added log "Rendering ...", when starting to render a template, to log that we have started to render something, at the very beginning. This helps to easily identify queries from controller vs views Fixes #23710
-