- 25 5月, 2014 3 次提交
-
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
Unwrap Constraints objects. I don't actually think it's possible to pass a Constraints object to this constructor, but there were multiple places that kept testing children of this object. I *think* they were just being defensive, but I have no idea.
-
- 24 5月, 2014 4 次提交
-
-
由 Aaron Patterson 提交于
I know, it's crazy.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
this also changes the constructor. We don't need to pass more options than "defaults" (whatever defaults are, ugh. probably another hash of stupid stuff).
-
- 23 5月, 2014 1 次提交
-
-
由 Aaron Patterson 提交于
-
- 14 5月, 2014 2 次提交
-
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
no need for redefine_method
-
- 05 5月, 2014 1 次提交
-
-
由 Rafael Mendonça França 提交于
-
- 02 5月, 2014 1 次提交
-
-
由 Robin Dupret 提交于
-
- 01 5月, 2014 1 次提交
-
-
由 Juan David Pastas 提交于
-
- 11 4月, 2014 1 次提交
-
-
由 Andrew White 提交于
Since `:shallow` may be set at any point in the resource nesting we should only make the new and collection routes shallow when the parent is shallow. This is a bit of a hack but until the mapper is refactored to an object graph instead of a hash of merged values it's the best we can do. Fixes #14684.
-
- 21 3月, 2014 1 次提交
-
-
由 Earl St Sauver 提交于
THe match documentation doesn't mention any requirement of the parameter name requirement for matches. However, including a bare glob character without a variable assignment causes a parse error.
-
- 16 3月, 2014 1 次提交
-
-
由 Andrew White 提交于
The method `shallow?` returns false if the parent resource is a singleton so we need to check if we're not inside a nested scope before copying the :path and :as options to their shallow equivalents. Fixes #14388.
-
- 09 3月, 2014 4 次提交
-
-
由 Andrew White 提交于
If the options :shallow_prefix and :shallow_path are not set in the scope options then copy them from the normal :as and :path options if they are set.
-
由 Andrew White 提交于
If a developer has specified either :path or :as in the options hash then these should be used as the defaults for :shallow_path and :shallow_prefix. Fixes #14241.
-
由 Andrew White 提交于
By tracking the depth of resource nesting we can push the need for nested shallow scoping to only those routes that are nested more than one deep. This allows us to keep the fix for #12498 and fix the regression in #14224. Fixes #14224.
-
由 Andrew White 提交于
Originally with_scope_level was exclusively for managing scope levels with resources, however it is now used for other things so it makes more sense to move the responsibility for setting the :scope_level_resource to the resource_scope method. This eliminates repeatedly setting it to the same resource as each resource method scope is evaluated.
-
- 10 2月, 2014 1 次提交
-
-
由 Andrew White 提交于
If we set :shallow_path when shallow is called it can result in incorrect paths if the resource is inside a namespace because namespace itself sets the :shallow_path option to the namespace path. We fix this by removing the :shallow_path option from shallow as that should only be turning shallow routes on and not otherwise affecting the scope. To do this we need to treat the :shallow option to resources differently to other scope options and move it to before the nested block is called. This change also has the positive side effect of making the behavior of the :shallow option consistent with the shallow method. Fixes #12498.
-
- 25 1月, 2014 1 次提交
-
-
由 Byron Bischoff 提交于
Fixes #13824
-
- 20 1月, 2014 2 次提交
-
-
由 Mikko Johansson 提交于
-
由 Amr Tamimi 提交于
-
- 06 1月, 2014 1 次提交
-
-
由 Andrew White 提交于
Fixes #12777
-
- 30 12月, 2013 1 次提交
-
-
由 Andrew White 提交于
-
- 11 12月, 2013 1 次提交
-
-
由 Piotr Sarnacki 提交于
When a route is mounted inside a resources block, it's automatically prefixed, so a following code: resources :users do mount Blog::Engine => '/blog' end will generate a user_blog path helper. In order to access engine helpers, we also use "mounted_helpers", a list of helpers associated with each mounted engine, so a path to blog's post can be generated using user_blog.post_path(user, post). The problem I'm fixing here is that mount used a raw :as option, without taking nestings into account. As a result, blog was added to a route set as a `user_blog`, but helper was generated for just `blog`. This commit applies the proper logic for defining a helper for a mounted engine nested in resources or resource block. (closes #8533)
-
- 15 11月, 2013 4 次提交
-
-
由 Carlos Antonio da Silva 提交于
Only set the value once after it's calculated.
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
-
由 Akshay Vishnoi 提交于
-
- 12 11月, 2013 1 次提交
-
-
由 Prem Sichanugrist 提交于
According to our guideline, we leave 1 space between `#` and `=>`, so we want `# =>` instead of `#=>`. Thanks to @fxn for the suggestion. [ci skip]
-
- 05 11月, 2013 1 次提交
-
-
由 Gaurish Sharma 提交于
These errors occur when, there routes are wrongly defined. example, the following line would cause a missing :action error root "welcomeindex" Mostly beginners are expected to hit these errors, so lets improve the error message a bit to make their learning experience bit better.
-
- 13 9月, 2013 2 次提交
-
-
由 Rafael Mendonça França 提交于
This reverts commit ab5cd54b, reversing changes made to cdc10c89. Reason: This way of defining root path is still supported. See https://github.com/rails/rails/blob/d262773ab7f0aae5de2d354ac2eca168e95b653d/actionpack/test/controller/routing_test.rb#L450-457
-
由 Michael Hoy 提交于
-
- 09 9月, 2013 2 次提交
-
-
由 Earl J St Sauver 提交于
The documentation in this section is referring to a profile, so the resource that's created should probably also be a profile of some sort.
-
由 Earl J St Sauver 提交于
The docs refference a blacklist, but really what's being described is a whitelist. Anything that matches the constraint gets through to the path.
-
- 31 8月, 2013 1 次提交
-
-
由 Earl St Sauver 提交于
This piece of documentation is out of date. The use of match without any via option is prevented, now the HTTP verbs have to be explicitly set. If they're not set then the error message in normalize_conditions! (around line 186) is shown.
-
- 28 6月, 2013 1 次提交
-
-
由 Xavier Defrang 提交于
Verify that route constraints respond to the expected messages instead of silently failing to enforce the constraint
-
- 25 6月, 2013 1 次提交
-
-
由 Andrew White 提交于
Merge `:action` from routing scope and assign endpoint if both `:controller` and `:action` are present. The endpoint assignment only occurs if there is no `:to` present in the options hash so should only affect routes using the shorthand syntax (i.e. endpoint is inferred from the the path). Fixes #9856
-