1. 25 5月, 2014 2 次提交
  2. 24 5月, 2014 8 次提交
  3. 23 5月, 2014 12 次提交
    • D
      Added force_reload to Auto-generated methods doc · 9dc8e773
      danielmbarlow 提交于
      Should make it a little easier to find the information. Also added note to look below for the definition of the generated methods.
      9dc8e773
    • B
      Bring the missing parameters back. · 36368eaa
      Bin Huang 提交于
      36368eaa
    • G
      Avoid slowing down AR object initialization · 28d52c59
      Godfrey Chan 提交于
      2d73f5ae forces AR to enter the `define_attribute_methods` method whenever it
      instantiate a record from the `init_with` entry point. This is a potential
      performance hotspot, because `init_with` is called from all `find*` family
      methods, and `define_attribute_methods` is slow because it tries to acquire
      a lock on the mutex everytime it is entered.
      
      By using [DCL](http://en.wikipedia.org/wiki/Double-checked_locking), we can
      avoid grabbing the lock most of the time when the attribute methods are already
      defined (the common case). This is made possible by the fact that reading an
      instance variable is an atomic operation in Ruby.
      
      Credit goes to Aaron Patterson for pointing me to DCL and filling me in on the
      atomicity guarantees in Ruby.
      
      [*Godfrey Chan*, *Aaron Patterson*]
      28d52c59
    • G
      Fixed serialization for records with an attribute named `format`. · 2d73f5ae
      Godfrey Chan 提交于
      * * *
      
      This bug can be triggered when serializing record R (the instance) of type C
      (the class), provided that the following conditions are met:
      
      1. The name of one or more columns/attributes on C/R matches an existing private
         method on C (e.g. those defined by `Kernel`, such as `format`).
      
      2. The attribute methods have not yet been generated on C.
      
      In this case, the matching private methods will be called by the serialization
      code (with no arguments) and their return values will be serialized instead. If
      the method requires one or more arguments, it will result in an `ArgumentError`.
      
      This regression is introduced in d1316bb1.
      
      * * *
      
      Attribute methods (e.g. `#name` and `#format`, assuming the class has columns
      named `name` and `format` in its database table) are lazily defined. Instead of
      defining them when a the class is defined (e.g. in the `inherited` hook on
      `ActiveRecord::Base`), this operation is deferred until they are first accessed.
      
      The reason behind this is that is defining those methods requires knowing what
      columns are defined on the database table, which usually requires a round-trip
      to the database. Deferring their definition until the last-possible moment helps
      reducing unnessary work, especially in development mode where classes are
      redefined and throw away between requests.
      
      Typically, when an attribute is first accessed (e.g. `a_book.format`), it will
      fire the `method_missing` hook on the class, which triggers the definition of
      the attribute methods. This even works for methods like `format`, because
      calling a private method with an explicit receiver will also trigger that hook.
      
      Unfortunately, `read_attribute_for_serialization` is simply an alias to `send`,
      which does not respect method visibility. As a result, when serializing a record
      with those conflicting attributes, the `method_missing` is not fired, and as a
      result the attribute methods are not defined one would expected.
      
      Before d1316bb1, this is negated by the fact that calling the `run_callbacks`
      method will also trigger a call to `respond_to?`, which is another trigger point
      for the class to define its attribute methods. Therefore, when Active Record
      tries to run the `after_find` callbacks, it will also define all the attribute
      methods thus masking the problem.
      
      * * *
      
      The proper fix for this problem is probably to restrict `read_attribute_for_serialization`
      to call public methods only (i.e. alias `read_attribute_for_serialization` to
      `public_send` instead of `send`). This however would be quite risky to change
      in a patch release and would probably require a full deprecation cycle.
      
      Another approach would be to override `read_attribute_for_serialization` inside
      Active Record to force the definition of attribute methods:
      
         def read_attribute_for_serialization(attribute)
           self.class.define_attribute_methods
           send(attribute)
         end
      
      Unfortunately, this is quite likely going to cause a performance degradation.
      
      This patch therefore restores the behaviour from the 4-0-stable branch by
      explicitly forcing the class to define its attribute methods in a similar spot
      (when records are initialized). This should not cause any extra roundtrips to
      the database because the `@columns` should already be cached on the class.
      
      Fixes #15188.
      2d73f5ae
    • A
      b89190f0
    • S
      Push limit to type objects · 11199051
      Sean Griffin 提交于
      Columns and injected types no longer have any conditionals based on the
      format of SQL type strings! Hooray!
      11199051
    • P
      Removed not-used code · 904dd5a2
      Paul Nikitochkin 提交于
      904dd5a2
    • S
      Push precision to type objects · 22c27ae3
      Sean Griffin 提交于
      22c27ae3
    • S
      Push scale to type objects · 57cc778f
      Sean Griffin 提交于
      Ideally types will be usable without having to specify a sql type
      string, so we should keep the information related to parsing them on the
      adapter or another object.
      57cc778f
    • D
      55400052
    • S
      Use the generic type map for all PG type registrations · 4826a4ab
      Sean Griffin 提交于
      We're going to want all of the benefits of the type map object for
      registrations, including block registration and real aliasing. Moves
      type name registrations to the adapter, and aliases the OIDs to the
      named types
      4826a4ab
    • S
      Allow additional arguments to be used during type map lookups · ecf4ad7c
      Sean Griffin 提交于
      Determining things like precision and scale in postgresql will require
      the given blocks to take additional arguments besides the OID.
      
      - Adds the ability to handle additional arguments to `TypeMap`
      - Passes the column type to blocks when looking up PG types
      ecf4ad7c
  4. 22 5月, 2014 2 次提交
  5. 21 5月, 2014 16 次提交