- 12 12月, 2017 9 次提交
-
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
This reverts commit a80f81af.
-
由 Rafael França 提交于
`create_fixtures` doesn't work since at least a94220b6
-
由 Edouard CHIN 提交于
- The namespacing should be `ActiveRecord::FixtureSet` - I might be missing something but I'm not sure why `create_fixtures` is useful for nowaday (unless for testing rails internal /shrug) and since it's been that long it wasn't working I think it should be fine to just fire it
-
由 George Claghorn 提交于
Return `nil` instead of `false` if raise `Azure::Core::Http::HTTPError`
-
由 George Claghorn 提交于
[ci skip] Update instrumentation guide for ActiveStorage
-
由 Yoshiyuki Hirano 提交于
* Added `service_delete_prefixed.active_storage`.
-
由 George Claghorn 提交于
Execute a single mogrify command with multiple options rather than one command per option. Permit the use of all mogrify options, not just the ones that fall through to MiniMagick::Image#method_missing.
-
由 Yoshiyuki Hirano 提交于
* If it raise error `Azure::Core::Http::HTTPError`, return `nil` instead of `false` in `ActiveStorage::Service::AzureStorageService#delete`. * Other services behave as same as this.
-
- 11 12月, 2017 3 次提交
-
-
由 Eileen M. Uchitelle 提交于
StreamingTemplateRenderer fails to forward I18n.locale in layouts
-
由 Javan Makhmali 提交于
`webpack` is assigned but never used in webpack.config.js
-
由 Eileen M. Uchitelle 提交于
Remove whitespace
-
- 10 12月, 2017 6 次提交
-
-
由 Lonre Wang 提交于
-
由 Yoshiyuki Hirano 提交于
* Removed webpack const, so it is assigned but never used in webpack.config.js.
-
由 yuuji.yaginuma 提交于
Currently, `test_copy_table_with_composite_primary_keys` test fails depending on execution order. The reproduction step is as follows. ``` $ ARCONN=sqlite3_mem bin/test -w -n "/^(?:CalculationsTest#(?:test_#skip_query_cache\\!_for_a_simple_calculation)|PrimaryKeyAnyTypeTest#(?:test_any_type_primary_key)|ActiveRecord::ConnectionAdapters::SQLite3AdapterTest#(?:test_copy_table_with_composite_primary_keys))$/" --seed 41545 ``` The column info is cached by `PrimaryKeyAnyTypeTest#test_any_type_primary_key`, and the test seems to have failed due to the influence. So clear cache after testing so as not to affect other tests. Related: https://travis-ci.org/rails/rails/jobs/313730163#L1788
-
由 Guillermo Iguaran 提交于
Change the system tests to set Puma as default server only when the user haven't specified manually another server.
-
由 Guillermo Iguaran 提交于
Change the system tests to set Puma as default server only when the user haven't specified manually another server.
-
由 Guillermo Iguaran 提交于
-
- 09 12月, 2017 8 次提交
-
-
由 Ryuta Kamizono 提交于
CI against JRuby 9.1.15.0
-
由 Claudio B 提交于
docs: add example for a nil name in link_to
-
由 Aaron Patterson 提交于
Fix Rails environment when running tests with Ruby
-
由 Aaron Patterson 提交于
Option parsing happens too late to have any impact on the Rails environment. Rails accesses the environment name and memoizes it too early in the boot process for a commandline option to have any impact on the database connection, so we'll change this test to set the environment from an environment variable (and ensure it still works when running tests with `ruby`)
-
由 Aaron Patterson 提交于
This reverts commit 9a80f525.
-
由 bogdanvlviv 提交于
JRuby 9.1.15.0 has been released: http://jruby.org/2017/12/07/jruby-9-1-15-0.html
-
由 Aaron Patterson 提交于
When tests are run with just `ruby`, the RAILS_ENV is set to `development` too early, and we connect to the development database rather than the test database.
-
由 George Claghorn 提交于
-
- 08 12月, 2017 6 次提交
-
-
由 Ryuta Kamizono 提交于
`connection.primary_key` also return composite primary keys, so `from_primary_key_column` may not be found even if `from_primary_key` is presented. ``` % ARCONN=sqlite3 be ruby -w -Itest test/cases/adapters/sqlite3/sqlite3_adapter_test.rb -n test_copy_table_with_composite_primary_keys Using sqlite3 Run options: -n test_copy_table_with_composite_primary_keys --seed 19041 # Running: E Error: ActiveRecord::ConnectionAdapters::SQLite3AdapterTest#test_copy_table_with_composite_primary_keys: NoMethodError: undefined method `type' for nil:NilClass /path/to/rails/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb:411:in `block in copy_table' ``` This change fixes `copy_table` to do not lose composite primary keys.
-
由 Sean Griffin 提交于
Fix issue #30658 by checking explicitly for 'null' referrer
-
由 George Claghorn 提交于
-
由 Eileen M. Uchitelle 提交于
Add headless firefox driver to System Tests
-
由 Ryuta Kamizono 提交于
This regression was caused at 213796fb due to polymorphic predicates are combined by `Arel::Nodes::And`. But I'd like to keep that combined because it would help inverting polymorphic predicates correctly (e9ba12f7), and we can collect equality nodes regardless of combined by `Arel::Nodes::And` (`a AND (b AND c) AND d` == `a AND b AND c AND d`). This change fixes the regression to collect equality nodes in `Arel::Nodes::And` as well. Fixes #31338.
-
由 bogdanvlviv 提交于
-
- 07 12月, 2017 8 次提交
-
-
由 Eileen M. Uchitelle 提交于
Fix sqlite migrations with custom primary keys
-
由 Andrew White 提交于
[ci skip] Make `Todo` classes inherit `ApplicationRecord`
-
由 Yoshiyuki Hirano 提交于
Example codes that use `has_many` or `before_create` in `Module::Concerning` look like active record models. So I've made them inherit `ApplicationRecord`.
-
由 Aaron Patterson 提交于
I frequently run tests with `ruby`, not with a runner like `rake` or `rails`. When running the test with just `ruby` the `RAILS_ENV` environment variable did not get set to "test", and this would cause the tests to fail (and even mutate the development database!) This commit adds integration tests for running tests with just `ruby` and ensures the environment gets defaulted to "test". I also added a test to ensure that passing an environment to `-e` actually works (and fixed that case too). An interesting / annoying thing is that Minitest picks up it's plugins by asking RubyGems for a list of files: https://github.com/seattlerb/minitest/blob/ca6a71ca901016db09a5ad466b4adea4b52a504a/lib/minitest.rb#L92-L100 This means that RubyGems needs to somehow know about the file before it can return it to Minitest. Since we are not packaging Rails as a Gem before running the integration tests on it (duh, why would you do that?), RubyGems doesn't know about the file, so it can't tell Minitest, so Minitest doesn't automatically require it. This means I had to manually require and insert the plugin in our integration test. I've left comments about that in the test as well. Ugh.
-
由 maciej-ka 提交于
-
由 Yuji Yaginuma 提交于
Correct routing test spelling mistake.
-
由 Philip Tolton 提交于
-
由 Ashley Ellis Pierce 提交于
Previously, if a record was created with a custom primary key, that table could not be migrated using sqlite. While attempting to copy the table, the type of the primary key was ignored. Once that was corrected, copying the indexes would fail because custom primary keys are autoindexed by sqlite by default. To correct that, this skips copying the index if the index name begins with "sqlite_". This is a reserved word that indicates that the index is an internal schema object. SQLite prohibits applications from creating objects whose names begin with "sqlite_", so this string should be safe to use as a check. ref https://www.sqlite.org/fileformat2.html#intschema
-