- 27 4月, 2020 6 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Remove redundant begin block from yarn template
-
由 Tasos Latsas 提交于
-
由 Ryuta Kamizono 提交于
This reverts commit 960ceb23. Ref #39012, #38858. [ci skip]
-
由 Xavier Noria 提交于
Require time core extensions in all environments
-
由 Eugene Kenny 提交于
These have been required in the generated test environment config since 1c7207a2, but the generated development config also uses them (albeit inside a conditional), and the generated production config contains a comment which uses them. More generally, we shouldn't require core extensions in one environment and not others, since applications with `config.active_support.bare` enabled could rely on them implicitly and exhibit inconsistent behaviour across environments.
-
- 26 4月, 2020 3 次提交
-
-
由 Ryuta Kamizono 提交于
Improve `WhereClause#ast` to make concise Arel ast
-
由 Ryuta Kamizono 提交于
Fix aggregate functions to return numeric value consistently even on custom attribute type
-
由 Ryuta Kamizono 提交于
Merge pull request #39048 from abhaynikam/fix-failing-test-for-upsert-all-on-relation-for-sqlite-adapter Skip test cases for upsert_all on relation for sqlite adapter for duplicate record
-
- 25 4月, 2020 13 次提交
-
-
由 Abhay Nikam 提交于
Skip test cases for upsert_all on relation if database adapter doesn't support update on duplicate records
-
由 Ryuta Kamizono 提交于
If only one Arel node exist, wrapping a node by `And` node is obviously redundant, make concise Arel ast will improve performance for visiting the ast (about 20% faster for complex ast case). ```ruby class Post < ActiveRecord::Base end posts = (0..500).map { |i| Post.where(id: i) } Benchmark.ips do |x| x.report("inject scopes") { posts.inject { |res, scope| res.or(scope) }.to_sql } end ``` Before: ``` Warming up -------------------------------------- where with ids 8.000 i/100ms Calculating ------------------------------------- where with ids 80.416 (± 2.5%) i/s - 408.000 in 5.078118s ``` After: ``` Warming up -------------------------------------- where with ids 9.000 i/100ms Calculating ------------------------------------- where with ids 96.126 (± 2.1%) i/s - 486.000 in 5.058960s ```
-
由 Xavier Noria 提交于
-
由 Ryuta Kamizono 提交于
Remove unmaintained gem from ActiveJob README [ci skip]
-
由 Ryuta Kamizono 提交于
Currently, `count` and `average` always returns numeric value, but `sum`, `maximum`, and `minimum` not always return numeric value if aggregated on custom attribute type. I think that inconsistent behavior is surprising: ```ruby # All adapters except postgresql adapter are affected # by custom type casting. Book.group(:status).sum(:status) # => { "proposed" => "proposed", "published" => nil } ``` That is caused by fallback looking up cast type to `type_for(column)`. Now all supported adapters can return numeric value without that fallback, so I think we can remove that, it will also fix aggregate functions to return numeric value consistently.
-
由 Santiago Bartesaghi 提交于
-
由 Kasper Timm Hansen 提交于
Build GTG::Simulator memos in a single loop
-
由 Ryuta Kamizono 提交于
-
由 Vinicius Stock 提交于
-
由 William Carey 提交于
Closes #37701.
-
由 Ryuta Kamizono 提交于
Allow insert_all on relation
-
由 Ryuta Kamizono 提交于
This allows to work `author.books.insert_all` as expected. Co-authored-by: NJosef Šimánek <josef.simanek@gmail.com>
-
由 Ryuta Kamizono 提交于
Remove unused journey code
-
- 24 4月, 2020 4 次提交
-
-
由 Ryuta Kamizono 提交于
Journey was integrated into Action Dispatch at 56fee39c, but from that time, almost all NFA namespace code were not used.
-
由 Ryuta Kamizono 提交于
mysql2 gem have type casting mechanism from raw payload to Ruby primitive object.
-
由 Ryuta Kamizono 提交于
Remove unused `operand1`/`operand2` aliases
-
由 Rafael França 提交于
Upgrade kind-of
-
- 23 4月, 2020 9 次提交
-
-
由 Ryuta Kamizono 提交于
Get rid of redundant direction argument in execute_migration_in_transaction
-
由 Andrey Koleshko 提交于
-
由 Ryuta Kamizono 提交于
Fix typos [ci skip]
-
由 Ryuta Kamizono 提交于
There is no worth to keep those unused aliases and tests which are private API.
-
由 Eugene Kenny 提交于
Reload schema after ignored_columns reassignment
-
由 Flavio Wuensche 提交于
reload column_names after ignored_columns assignment code review: remove unnecessary setup and move up reload_schema_from_cache
-
由 Godfrey Chan 提交于
I wrote this shell script to find words from the Rails repo, so I can paste them into https://www.horsepaste.com/ for the [codenames game](https://en.m.wikipedia.org/wiki/Codenames_(board_game)). ```bash git grep -Il '' | \ grep -v -E "CHANGELOG|Gemfile|gemspec|package\.json|yarn\.lock" | \ xargs cat | \ sed '/[^ ]\{10,\}/d' | \ sed 's/\([A-Z]\)/ \1/g' | \ tr 'A-Z' 'a-z' | \ tr -c -s 'a-z' '\n' | \ sed '/^.\{0,3\}$/d' | \ sort | \ uniq | \ tr '\n' ',' | \ pbcopy ``` You can see the result in https://www.horsepaste.com/rails-fixed. Click "Next game" to cycle the words. Found some typos in the codebase from this
😂 This is how I generated the list of possible typos: ```bash git grep -Il '' | \ grep -v -E "CHANGELOG|Gemfile|gemspec|package\.json|yarn\.lock" | \ xargs cat | \ sed '/[^ ]\{10,\}/d' | \ sed 's/\([A-Z]\)/ \1/g' | \ tr 'A-Z' 'a-z' | \ tr -c -s 'a-z' '\n' | \ sed '/^.\{0,3\}$/d' | \ sort | \ uniq | \ aspell --ignore-case list ``` I manually reviewed the list and made the corrections in this commit. The rest on the list are either: * Bugs in my script: it split things like "doesn't" into "doesn" and "t", if find things like `#ffffff` and extracts "ffffff" as a word, etc * British spelling: honour, optimised * Foreign words: bonjour, espanol * Names: nginx, hanekawa * Technical words: mutex, xhtml * Portmanteau words: autosave, nodelist * Invented words: camelize, coachee * Shortened words: attrs, repo * Deliberate typos: hllo, hillo (used in code examples, etc) * Lorem ipsum words: arcu, euismod This is the [output](https://gist.github.com/chancancode/eb0b573d667dc31906f33f1fb0b22313) of the script *after* fixing the typos included in this commit. In theory, someone can run that command again in the future and compare the output to catch new typos (i.e. using my list to filter out known typos). Limitations: the aspell dictionary could be wrong, I could have miss things, and my script ignores words that are less than 3 characters or longer than 10 characters. -
由 Rafael França 提交于
Reference updated errors attribute names method in deprecation warning
-
由 Adam Hess 提交于
-
- 22 4月, 2020 5 次提交
-
-
由 Eugene Kenny 提交于
Reject hexadecimal numbers with signs while validating numericality
-
由 nimish 提交于
-
由 Ryuta Kamizono 提交于
Realign cache key diagram in method doc [ci skip]
-
由 Jonathan Hefner 提交于
Follow-up to #37669.
-
由 David Heinemeier Hansson 提交于
-