- 15 8月, 2015 7 次提交
-
-
由 Aaron Patterson 提交于
Eventually I want to eliminate the FakeSet test class
-
由 Aaron Patterson 提交于
I'm going to reimplement this using route objects, so it will be easier if we just change ast access to go through a method rather than hashes
-
由 Aaron Patterson 提交于
we don't need to keep adding it and deleting if from hashes.
-
由 Aaron Patterson 提交于
Eventually I want to pull up AST generation so that we don't have to add it to the `conditions` hash.
-
由 Rafael Mendonça França 提交于
Add method_source dependency to activesupport
-
由 Rafael Mendonça França 提交于
We already have rake install command that does the same thing.
-
由 Rafael Mendonça França 提交于
Remove `version` argument in install.rb
-
- 14 8月, 2015 17 次提交
-
-
由 Kite 提交于
-
由 Kasper Timm Hansen 提交于
Fix middleware deprecation message. Related to #21172.
-
由 Jon Atack 提交于
-
由 Claudio B. 提交于
[ci skip] SQL is written using statements, not sentences
-
由 Aaron Patterson 提交于
It just constructs a Path::Pattern object with the AST that it already has
-
由 Aaron Patterson 提交于
This was a useless object. We can just directly construct a Path::Pattern object without a Strexp object.
-
由 Aaron Patterson 提交于
the caller already has it, there is no reason to pack it in to an object and just throw that object away.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
we always pass all parameters, so there is no reason to provide default arguments.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
the caller already has access to `as`, so we can stop passing it around.
-
由 Aaron Patterson 提交于
the same value that is extracted from the options hash earlier is returned, so we don't need to pass it in in the first place. The caller already has the data, so stop passing it around.
-
由 Aaron Patterson 提交于
this way we don't have to mutate the options hash so far away from where the user passed it in
-
由 Rafael Mendonça França 提交于
Require explicit counter_cache option for has_many
-
由 Aaron Patterson 提交于
The `anchor` parameter [is overridden](https://github.com/rails/rails/blob/b4b4a611d0eb9aa1c640c5f521c6a43bf2a65bab/actionpack/lib/action_dispatch/routing/mapper.rb#L1528) unless it is directly passed to `match`, so setting it in a scope must be a mistake.
-
由 Rafael Mendonça França 提交于
Prevent duplicating `where` clauses
-
由 Brooks Reese 提交于
-
- 13 8月, 2015 16 次提交
-
-
由 Yves Senn 提交于
Closes #21201.
-
由 Robin Dupret 提交于
How to pass arguments to ActiveJob Jobs [ci skip]
-
由 Dhia Eddine Chouchane 提交于
A section explaining how to pass arguments to Jobs has been added. [ci skip] How to pass arguments to ActiveJob Jobs Removed the "how to pass arguments" from what you will know section [ci skip] improving Enqueue Job section Using GuestsCleanupJob rather than MyJob for coherence. [ci skip] Passing args section merged with enqueuing jobs Passing args is now explained through examples withing Enqueuing the Jobs section [ci skip] Unnecessary example removed [ci skip] Typo fixed (missing as)
-
由 Robin Dupret 提交于
[ci skip] Clarified asset pipeline guide
-
由 Andreas Lietz 提交于
-
由 Yves Senn 提交于
The latest, currently unreleased, version of queue_classic is required for this to work. See https://github.com/QueueClassic/queue_classic/pull/262 for more details.
-
由 Kasper Timm Hansen 提交于
Added helper methods to stub any instance
-
由 Yves Senn 提交于
As described in the "Follow Coding Conventions" section in our contribution guide (http://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#follow-the-coding-conventions) we favor `assert_not` over `refute`. While we don't usually make stylistic changes on it's own I opted to do it in this case. The reason being that test cases are usually copied as a starting point for new tests. This results in a spread of `refute` in files that have been using it already.
-
由 Yves Senn 提交于
Assert that the `:prefix` option of `number_to_human_size` is deprecated
-
由 Ronak Jangir 提交于
-
由 Sean Griffin 提交于
Replace the giant comment in routes.rb with a link to the guides
-
由 Roque Pinel 提交于
-
由 Zachary Scott 提交于
[ci skip] Documentation: Switch around a common phrase for readability
-
由 Aaron Patterson 提交于
I didn't like this method because it mutates the parameters. Now that the method is so small, just push it up to `initialize`
-
由 Rafael Mendonça França 提交于
If the through class has default scopes we should skip the statement cache. Closes #20745.
-
由 Aaron Patterson 提交于
now the `@defaults` variable doesn't need to be set before calling `normalize_defaults`
-