1. 01 5月, 2019 8 次提交
    • Y
      Remove database specific sql statements from SQLCounter · 6030110f
      Yasuo Honda 提交于
      Every database executes different type of sql statement to get metadata then `ActiveRecord::TestCase` ignores these database specific sql statements to make `assert_queries` or `assert_no_queries` work consistently.
      
      Connection adapter already labels these statement by setting "SCHEMA" argument, this pull request makes use of "SCHEMA" argument to ignore metadata queries.
      
      Here are the details of these changes:
      
      * PostgresqlConnectionTest
      
      Each of PostgresqlConnectionTest modified just executes corresponding methods
      
      https://github.com/rails/rails/blob/fef174f5c524edacbcad846d68400e7fe114a15a/activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb#L182-L195
      
      ```ruby
              # Returns the current database encoding format.
              def encoding
                query_value("SELECT pg_encoding_to_char(encoding) FROM pg_database WHERE datname = current_database()", "SCHEMA")
              end
      
              # Returns the current database collation.
              def collation
                query_value("SELECT datcollate FROM pg_database WHERE datname = current_database()", "SCHEMA")
              end
      
              # Returns the current database ctype.
              def ctype
                query_value("SELECT datctype FROM pg_database WHERE datname = current_database()", "SCHEMA")
              end
      ```
      
      * BulkAlterTableMigrationsTest
      
      mysql2 adapter executes `SHOW KEYS FROM ...` to see if there is an index already created as below. I think the main concerns of these tests are how each database adapter creates or drops indexes then ignoring  `SHOW KEYS FROM` statement makes sense.
      
      https://github.com/rails/rails/blob/fef174f5c524edacbcad846d68400e7fe114a15a/activerecord/lib/active_record/connection_adapters/mysql/schema_statements.rb#L11
      
      ```ruby
                execute_and_free("SHOW KEYS FROM #{quote_table_name(table_name)}", "SCHEMA") do |result|
      ```
      
      * Temporary change not included in this commit to show which statements executed
      
      ```diff
      $ git diff
      diff --git a/activerecord/test/cases/migration_test.rb b/activerecord/test/cases/migration_test.rb
      index 8e8ed494d9..df05f9bd16 100644
      --- a/activerecord/test/cases/migration_test.rb
      +++ b/activerecord/test/cases/migration_test.rb
      @@ -854,7 +854,7 @@ def test_adding_indexes
      
             classname = ActiveRecord::Base.connection.class.name[/[^:]*$/]
             expected_query_count = {
      -        "Mysql2Adapter"     => 3, # Adding an index fires a query every time to check if an index already exists or not
      +        "Mysql2Adapter"     => 1, # Adding an index fires a query every time to check if an index already exists or not
               "PostgreSQLAdapter" => 2,
             }.fetch(classname) {
               raise "need an expected query count for #{classname}"
      @@ -886,7 +886,7 @@ def test_removing_index
      
             classname = ActiveRecord::Base.connection.class.name[/[^:]*$/]
             expected_query_count = {
      -        "Mysql2Adapter"     => 3, # Adding an index fires a query every time to check if an index already exists or not
      +        "Mysql2Adapter"     => 1, # Adding an index fires a query every time to check if an index already exists or not
               "PostgreSQLAdapter" => 2,
             }.fetch(classname) {
               raise "need an expected query count for #{classname}"
      $
      ```
      
      * Executed these modified tests
      
      ```ruby
      $ ARCONN=mysql2 bin/test test/cases/migration_test.rb -n /index/
      Using mysql2
      Run options: -n /index/ --seed 8462
      
      F
      
      Failure:
      BulkAlterTableMigrationsTest#test_adding_indexes [/home/yahonda/git/rails/activerecord/test/cases/migration_test.rb:863]:
      3 instead of 1 queries were executed.
      Queries:
      SHOW KEYS FROM `delete_me`
      SHOW KEYS FROM `delete_me`
      ALTER TABLE `delete_me` ADD UNIQUE INDEX `awesome_username_index`  (`username`), ADD  INDEX `index_delete_me_on_name_and_age`  (`name`, `age`).
      Expected: 1
        Actual: 3
      
      bin/test test/cases/migration_test.rb:848
      
      F
      
      Failure:
      BulkAlterTableMigrationsTest#test_removing_index [/home/yahonda/git/rails/activerecord/test/cases/migration_test.rb:895]:
      3 instead of 1 queries were executed.
      Queries:
      SHOW KEYS FROM `delete_me`
      SHOW KEYS FROM `delete_me`
      ALTER TABLE `delete_me` DROP INDEX `index_delete_me_on_name`, ADD UNIQUE INDEX `new_name_index`  (`name`).
      Expected: 1
        Actual: 3
      
      bin/test test/cases/migration_test.rb:879
      
      ..
      
      Finished in 0.379245s, 10.5473 runs/s, 7.9105 assertions/s.
      4 runs, 3 assertions, 2 failures, 0 errors, 0 skips
      $
      ```
      
      * ActiveRecord::ConnectionAdapters::Savepoints
      
      Left `self.ignored_sql` to ignore savepoint related statements because these SQL statements are not related "SCHEMA"
      
      ```
      self.ignored_sql = [/^SAVEPOINT/, /^ROLLBACK TO SAVEPOINT/, /^RELEASE SAVEPOINT/]
      ```
      
      https://github.com/rails/rails/blob/fef174f5c524edacbcad846d68400e7fe114a15a/activerecord/lib/active_record/connection_adapters/abstract/savepoints.rb#L10-L20
      
      ```ruby
            def create_savepoint(name = current_savepoint_name)
              execute("SAVEPOINT #{name}")
            end
      
            def exec_rollback_to_savepoint(name = current_savepoint_name)
              execute("ROLLBACK TO SAVEPOINT #{name}")
            end
      
            def release_savepoint(name = current_savepoint_name)
              execute("RELEASE SAVEPOINT #{name}")
            end
      ```
      6030110f
    • A
      `@controller` may not be defined here, and if so, it causes a Ruby warning · fef174f5
      Akira Matsuda 提交于
      e.g. via test-unit-rails' `run_setup`
      fef174f5
    • A
      Merge pull request #36150 from rails/error-any-delegation · 0c152f2e
      Aaron Patterson 提交于
      any? should be delegated to the errors list
      0c152f2e
    • E
      Merge pull request #36148 from ksolo/update-event-duration-in-notifications · 84572fe2
      Eileen M. Uchitelle 提交于
      Revert changes to monotonic times
      84572fe2
    • A
      any? should be delegated to the errors list · 2ada222f
      Aaron Patterson 提交于
      Otherwise we get deprecation warnings in the generated scaffold template files
      2ada222f
    • K
      revert changes to monotonic times · b9a9131f
      Kevin Solorio 提交于
      The change to monotonic times causes failures for applications
      where the subscribed block is expecting Time objects as described
      in this issue: https://github.com/rails/rails/issues/36145
      
      The original PR (https://github.com/rails/rails/pull/35984) was
      concerned with errors on the cpu_time. Test was edited to reflect
      changes to initializer using 0 values instead of nil
      b9a9131f
    • R
      Merge pull request #36146 from carlesjove/remove_outdated_gem_from_guides · 681b0c1f
      Ryuta Kamizono 提交于
      [Guides] Remove dynamic_form gem reference in guides
      
      [ci skip]
      681b0c1f
    • C
      Remove dynamic_form gem references in guides · c3828a10
      Carles Jove i Buxeda 提交于
      This gem has not been updated since April 2014 and 2 of the 4 methods it introduces have been broken since Rails 4
      c3828a10
  2. 30 4月, 2019 9 次提交
  3. 29 4月, 2019 3 次提交
  4. 28 4月, 2019 2 次提交
  5. 27 4月, 2019 6 次提交
  6. 26 4月, 2019 10 次提交
  7. 25 4月, 2019 2 次提交