- 31 7月, 2014 16 次提交
-
-
由 Carlos Antonio da Silva 提交于
-
由 Aaron Patterson 提交于
every call to default_resources_path_names allocates a new hash, no need to dup
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
this makes scope rollback much easier
-
由 Aaron Patterson 提交于
just ask whether or not the route is defined
-
由 Aaron Patterson 提交于
we can `super` in to the previous implementation.
-
由 Aaron Patterson 提交于
we already know what helpers are path helpers, so just iterate through that list and define the helpers with warnings
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
this lets us avoid hard coding a regexp for separating path and url helpers in the clear! method.
-
由 Aaron Patterson 提交于
-
由 Xavier Noria 提交于
Deprecate `*_path` methods in mailers
-
由 Rafael Mendonça França 提交于
Remove redundant `self.` in class method calls
-
由 Jack Danger Canty 提交于
These are the only instances of this in the whole code base.
-
由 Rafael Mendonça França 提交于
Prevent using String#scrub on Rubinius
-
由 Robin Dupret 提交于
Rubinius' has built-in support for String#scrub but it doesn't have yet support for ASCII-incompatible chars so for now, we should rely on the old implementation of #tidy_bytes.
-
由 @schneems and @sgrif 提交于
Email does not support relative links since there is no implicit host. Therefore all links inside of emails must be fully qualified URLs. All path helpers are now deprecated. When removed, the error will give early indication to developers to use `*_url` methods instead. Currently if a developer uses a `*_path` helper, their tests and `mail_view` will not catch the mistake. The only way to see the error is by sending emails in production. Preventing sending out emails with non-working path's is the desired end goal of this PR. Currently path helpers are mixed-in to controllers (the ActionMailer::Base acts as a controller). All `*_url` and `*_path` helpers are made available through the same module. This PR separates this behavior into two modules so we can extend the `*_path` methods to add a Deprecation to them. Once deprecated we can use this same area to raise a NoMethodError and add an informative message directing the developer to use `*_url` instead. The module with warnings is only mixed in when a controller returns false from the newly added `supports_relative_path?`. Paired @sgrif & @schneems
-
- 30 7月, 2014 14 次提交
-
-
由 Santiago Pastorino 提交于
This reverts commit f632f79b, reversing changes made to 98c7fe87. Closes #16343
-
由 Rafael Mendonça França 提交于
remove unneeded test model for ActiveModel test cases.
-
由 David Heinemeier Hansson 提交于
Add implicit receiver support to `Object#with_options`
-
由 Pavel Pravosud 提交于
-
由 Rafael Mendonça França 提交于
Remove @state.parent assignment on commit
-
由 Aaron Patterson 提交于
use helpers.include? so we don't get any false positives
-
由 Aaron Patterson 提交于
we should not be accessing internals to figure out if a method is defined.
-
由 Aaron Patterson 提交于
since helpers is a set, we can be confident about when to remove methods from the module.
-
由 Aaron Patterson 提交于
after this, we can disconnect @module from the instance
-
由 Aaron Patterson 提交于
we can cache the module on the stack, then reuse it
-
由 Aaron Patterson 提交于
-
由 Zachary Scott 提交于
-
由 Zachary Scott 提交于
GET request should not write to database note added. [ci skip]
-
由 Deepender Singla 提交于
-
- 29 7月, 2014 10 次提交
-
-
由 Rafael Mendonça França 提交于
Add missing test case for Array#to_sentence, collect all test cases for Object#to_param at one place and avoid repitition
-
由 Arthur Neves 提交于
This piece of code was introduced on 67d8bb96 , which was calling `committed?` in the `transaction_state` before calling the `committed!` method. However on 7386ffc7, the `committed?` check was removed and replaced by a `finalized?`, which only checks if the state is not nil. Thus we can remove that line.
-
由 Akshay Vishnoi 提交于
Add missing test case for Array#to_sentence, collect all test cases for Object#to_param at one place and avoid repitition
-
由 Rafael Mendonça França 提交于
Move array test files under array
-
由 Yves Senn 提交于
[ci skip] This fixes the broken code block rendering and indents the examples within the parameter list.
-
由 Akshay Vishnoi 提交于
-
由 Robin Dupret 提交于
[ci skip] fix doc typo for validates_uniqueness_of
-
由 Satoru Yamasaki 提交于
-
由 Yves Senn 提交于
Give password_confirmation div the "field" class in the scaffold generator "_form" partial
-
由 Godfrey Chan 提交于
Fix json autoload
-