- 28 1月, 2013 6 次提交
-
-
由 Santiago Pastorino 提交于
Make HEAD work / convert to GET once more
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Aaron Patterson 提交于
-
由 Jon Leighton 提交于
This caused a bug with the new associations implementation, because now association conditions are represented as Arel nodes internally right up to when the whole thing gets turned to SQL. In Rails 3.2, association conditions get turned to raw SQL early on, which prevents Relation#merge from interfering. The current implementation was buggy when a default_scope existed on the target model, since we would basically end up doing: default_scope.merge(association_scope) If default_scope contained a where(foo: 'a') and association_scope contained a where(foo: 'b').where(foo: 'c') then the merger would see that the same column is representated on both sides of the merge and collapse the wheres to all but the last: where(foo: 'c') Now, the RHS of the merge is left alone. Fixes #8990
-
由 Carlos Antonio da Silva 提交于
-
- 27 1月, 2013 9 次提交
-
-
由 Derek Kraan 提交于
because of an ambiguous column name. This happened if the association model had a default scope that referenced a third table, and the third table also referenced the original table (with an identical foreign_key). Mysql requires that ambiguous columns are deambiguated by using the full table.column syntax. Postgresql and Sqlite use a different syntax for updates altogether (and don't tolerate table.name syntax), so the fix requires always including the full table.column and discarding it later for Sqlite and Postgresql.
-
由 José Valim 提交于
Use `silence` instead of `quietly` to silence the `CheckPending` middleware.
-
由 Lucas Mazza 提交于
`Kernel.quietly` silences `STDOUT` and `STDERR`, which is useless if the logger is writing to a file, while `AS::Logger#silence` swaps the logger level to `ERROR`. Related to #8820 and #8052.
-
由 Andrew White 提交于
With the addition of String#in_time_zone and Date#in_time_zone we can simplify the type casting code by checking if the value has an `in_time_zone` method.
-
由 Lilibeth De La Cruz 提交于
Previously, when `time_zone_aware_attributes` were enabled, after changing a datetime or timestamp attribute and then changing it back to the original value, `changed_attributes` still tracked the attribute as changed. This caused `[attribute]_changed?` and `changed?` methods to return true incorrectly. Example: in_time_zone 'Paris' do order = Order.new original_time = Time.local(2012, 10, 10) order.shipped_at = original_time order.save order.changed? # => false # changing value order.shipped_at = Time.local(2013, 1, 1) order.changed? # => true # reverting to original value order.shipped_at = original_time order.changed? # => false, used to return true end
-
由 Xavier Noria 提交于
Conflicts: actionpack/lib/action_view/helpers/form_options_helper.rb guides/code/getting_started/app/controllers/comments_controller.rb
-
由 Xavier Noria 提交于
-
由 José Valim 提交于
document the behavior of `ActionMailer::Base.delivieries` in tests
-
由 Yves Senn 提交于
thanks @danielpuglisi
-
- 26 1月, 2013 7 次提交
-
-
由 Rafael Mendonça França 提交于
`#count` in conjunction with `#uniq` performs distinct count.
-
由 Yves Senn 提交于
closes #6865
-
由 Andrew Wilcox 提交于
-
由 Akira Matsuda 提交于
-
由 Juanjo Bazán 提交于
-
由 Carlos Antonio da Silva 提交于
Bring back the same API we have with Request::Session.
-
由 Carlos Antonio da Silva 提交于
All ActionPack and Railties tests are passing. Closes #8891. [Carlos Antonio da Silva + Santiago Pastorino]
-
- 25 1月, 2013 9 次提交
-
-
由 Carlos Antonio da Silva 提交于
Allow passing interpolations to #default_i18n_subject in mailers
-
由 Rafael Mendonça França 提交于
Fixes improper database name when creating a new rails app with a '.' Conflicts: railties/CHANGELOG.md
-
由 Andrew White 提交于
Since the default in Rails 4.0 is to run in 'threadsafe' mode we need to eager load all of the paths in `autoload_paths` so we alias `eager_load_paths` to it. This may have unintended consequences if you have added 'lib' to `autoload_paths` such as loading unneeded code or code intended only for development and/or test environments. If this applies to your application you should thoroughly check what is being eager loaded.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
- 24 1月, 2013 9 次提交
-
-
由 Olek Janiszewski 提交于
# config/locales/en.yml en: user_mailer: welcome: subject: 'Hello, %{username}' # app/mailers/user_mailer.rb class UserMailer < ActionMailer::Base def welcome(user) mail(subject: default_i18n_subject(username: user.name)) end end
-
由 Akira Matsuda 提交于
or the ConnectionPool silently fails to close connections inside the Thread
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
This reverts commit 4e05bfb8. Reason: BlankTopic#blank? should not be removed to check that dynamic finder with a bang can find a model that responds to `blank?`
-
由 Akira Matsuda 提交于
-
this would give us some more clues in case a test silently dies inside Thread
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Weston Platter 提交于
-