- 31 3月, 2014 4 次提交
-
-
由 Yves Senn 提交于
We have `connection_adapters/column.rb` so it's easier to remember that the column in in a separate file.
-
由 Luke Steensen 提交于
-
由 Luke Steensen 提交于
fixes #10613
-
由 Rafael Mendonça França 提交于
It is already called inside type_to_sql method.
-
- 30 3月, 2014 1 次提交
-
-
由 Guo Xiang Tan 提交于
Follow-Up to https://github.com/rails/rails/pull/14400 This ensures that all tables are removed after each test and thereby allowing us to run the tests in a random order.
-
- 29 3月, 2014 3 次提交
-
-
由 Godfrey Chan 提交于
460eb83d cused `ActiveRecord::Base#==` to sometimes return `nil` in some cases, this ensures we always return a boolean value. Also fixed a similar problem in AR reflections.
-
由 Kelley Reynolds 提交于
-
- 28 3月, 2014 6 次提交
-
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
-
由 Yves Senn 提交于
-
由 Rafael Mendonça França 提交于
Swap Timestamp/Callbacks order in ActiveRecord::Base
-
由 chrisfinne 提交于
custom primary_key that didn't save due to validation error
-
由 Henrik Nyh 提交于
It's unintuitive to call '#valid?' when you want to run validations but don't care about the return value. The alias in ActiveRecord isn't strictly necessary (the ActiveModel alias is still in effect), but it clarifies.
-
- 27 3月, 2014 12 次提交
-
-
由 Yves Senn 提交于
When the tests are executed in order, the dependency is loaded at the right time. However this makes it impossible to execute a single test later down the line. Let's require the dependecy at the beginning to get them working independent of the order. This resolves the following error: ``` $ ARCONN=postgresql ruby -Itest /Users/senny/Projects/rails/activerecord/test/cases/xml_serialization_test.rb -n test_to_xml Using postgresql Run options: -n test_to_xml --seed 51819 E Finished in 0.081320s, 12.2971 runs/s, 0.0000 assertions/s. 1) Error: DatabaseConnectedXmlSerializationTest#test_to_xml: NameError: uninitialized constant DatabaseConnectedXmlSerializationTest::REXML /Users/senny/Projects/rails/activerecord/test/cases/xml_serialization_test.rb:226:in `test_to_xml' ``` /cc @tgxworld fyi
-
由 Yves Senn 提交于
This will keep the test suite passing with older PG installations.
-
由 Lauro Caetano 提交于
It is supposed to raise ActiveRecord::InvalidForeignKey when the database has a fk constraint.
-
由 Rafael Mendonça França 提交于
This method is not being called anywhere in our code and a GitHub search show it is not being used in any project.
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
* cache `o.name` value * Avoid extra `concat` call * Avoid extra `<<` call
-
由 Rafael Mendonça França 提交于
These comments will likely be outdated with time and doesn't include any information that can't be found in the adapters
-
由 Rafael Mendonça França 提交于
Also improve some of the code conventions
-
- 26 3月, 2014 4 次提交
-
-
由 Steve Rice 提交于
Also: - updates tests by stubbing table_exists? method - adds entry for creating indexes in CREATE TABLE to changelog
-
由 Cody Cutrer 提交于
This is important, because adding an index on a temporary table after it has been created would commit the transaction Conflicts: activerecord/CHANGELOG.md
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
This reverts commit 6e3ab3e1, reversing changes made to 39e07b64. Conflicts: activerecord/CHANGELOG.md activerecord/test/cases/autosave_association_test.rb
-
- 25 3月, 2014 4 次提交
-
-
由 Yves Senn 提交于
-
由 Kuldeep Aggarwal 提交于
ActiveRecord::Base.pluralize_table_names = false. Previously, generation a migration like this: rails g migration add_column_name_to_user name would not generating the correct table name. Fixes #13426.
-
由 Aaron Patterson 提交于
arel methods are not supposed to be public API for ActiveRecord
-
由 Aaron Patterson 提交于
This abstracts us from the actual construction of the nodes
-
- 23 3月, 2014 1 次提交
-
-
由 Guo Xiang Tan 提交于
Follow-Up to https://github.com/rails/rails/pull/14400 This ensures that all tables are removed after each test and thereby allowing us to run the tests in a random order.
-
- 21 3月, 2014 1 次提交
-
-
由 Guo Xiang Tan 提交于
This setups the helper method which other tests can benefit from.
-
- 20 3月, 2014 4 次提交
-
-
由 Carlos Antonio da Silva 提交于
assert_raise + assert_equal on the returned exception message work just fine, there is no need for extra work, specially like this overly complicated helper.
-
由 Josh Williams 提交于
The pk_an_sequence_for query previously joined against pg_class's oid for rows in pg_depend, but pg_depend's objid may point to other system tables, such as pg_attrdef. If a row in one of those other tables coincidentally has the same oid as an (unrelated) sequence, that sequence name may be returned instead of the real one. This ensures that only the pg_depend entries pointing to pg_class are considered.
-
由 Carlos Antonio da Silva 提交于
-
由 Yves Senn 提交于
-