- 30 3月, 2018 12 次提交
-
-
由 Andrew White 提交于
Remove expired explanation [ci skip]
-
由 Andrew White 提交于
-
由 Shia 提交于
Override callback doesn't work anymore.
-
由 Ryuta Kamizono 提交于
Adding missing extension for `cattr_accessor` method
-
由 Wojciech Wnętrzak 提交于
-
-
由 Ryuta Kamizono 提交于
Don't unset foreign key when preloading missing record
-
由 Ryuta Kamizono 提交于
Previously `relation.all` behaves as `relation.scoping { klass.all }`. But it is just enough to `relation.spawn`.
-
由 yuuji.yaginuma 提交于
-
由 Guillermo Iguaran 提交于
--frozen-lockfile is the right name of the argument
-
由 Guillermo Iguaran 提交于
Use `did_you_mean` spell checker for option suggestions
-
由 Guillermo Iguaran 提交于
[Webpack] Raise an error when lockfile diff is generated
-
- 29 3月, 2018 3 次提交
-
-
由 Andrew White 提交于
Compare ruby version with correct way
-
由 Shia 提交于
-
由 Rafael França 提交于
Fix deprecation warnings from with_lock
-
- 28 3月, 2018 2 次提交
-
-
由 Yuji Yaginuma 提交于
-
由 Guillermo Iguaran 提交于
Expose foreign key name ignore pattern in configuration
-
- 27 3月, 2018 4 次提交
-
-
由 George Claghorn 提交于
Flip the order of the after_create callbacks
-
由 Dwight Watson 提交于
Addresses rails/rails#32247 Add test that checks identify and analyze work in correct order Break out direct upload test helper Review changes for direct-upload test helper
-
由 Rafael França 提交于
Add `before?` and `after?` methods to date and time classes
-
由 Eileen M. Uchitelle 提交于
Part 1 Easy Multi db in Rails: Add basic rake tasks for multi db setup
-
- 26 3月, 2018 2 次提交
-
-
由 Richard Schneeman 提交于
Readability fix [ci skip]
-
由 Isaac Orme 提交于
-
- 25 3月, 2018 3 次提交
-
-
由 Andrew White 提交于
Not everything that responds to `routes` is a Rails engine - for example a Grape API endpoint will have a `routes` method but can't be used with `assert_recognizes` as it doesn't respond to `recognize_path_with_request`. Fixes #32312.
-
由 yuuji.yaginuma 提交于
-
由 Eugene Kenny 提交于
When a belongs to association's target is set, its foreign key is now updated to match the new target. This is the correct behaviour when a new record is assigned, but not when the existing record is preloaded. As long as we mark the association as loaded, we can skip setting the target when the record is missing and avoid clobbering the foreign key.
-
- 24 3月, 2018 1 次提交
-
-
由 Andrew White 提交于
Add custom prefix to ActiveRecord::Store accessors
-
- 23 3月, 2018 7 次提交
-
-
由 Genadi Samokovarov 提交于
Now that we require Ruby over `2.3`, we can replace the current suggestion methods we have with tooling from the `did_you_mean` gem. There is a small user visible change and this is that we now offer a single suggestion for misspelled options. We are suggesting fixes during generator invocation and during a mistyped rails server rack handler. In both cases, if we don't make a proper prediction on the first match, we won't do so in the second or third one, so in my mind, this is okay.
-
由 Ryuta Kamizono 提交于
The multiple assignments was caused by 37a1dfad due to lost the `to_s` normalization for given names. Fixes #32323.
-
由 Tan Huynh 提交于
Add a prefix option to ActiveRecord::Store.store_accessor and ActiveRecord::Store.store. This option allows stores to have identical keys with different accessors.
-
由 Rafael França 提交于
Fix Cache `read_multi` with local_cache bug, should returns raw value, not `ActiveSupport::Cache::Entry` instance.
-
由 Rafael França 提交于
Use ASCII-8BIT paths in ActionDispatch::Static
-
由 Rafael Mendonça França 提交于
-
由 Rafael França 提交于
Ruby 2.6 will not require monkey patched `URI#unescape`
-
- 22 3月, 2018 6 次提交
-
-
由 Yasuo Honda 提交于
since revision 62897 https://github.com/ruby/ruby/commit/234a30459cdae6aa7da6e28a1082d9c11f315696
-
由 David Stosik 提交于
This makes more sense, as the foreign key ignore pattern is only used by the schema dumper.
-
由 Andrew White 提交于
The rack gem returns PATH_INFO as an ASCII-8BIT encoded string but it was being converted to US-ASCII by the match? method because it was calling Rack::Utils.escape_path. To prevent incompatibile encoding warnings use ASCII-8BIT strings for the root path and let Ruby handle any filename encoding conversion. Fixes #32294, Closes #32314.
-
由 Ryuta Kamizono 提交于
[ci skip] Update Action Mailer Documentation
-
由 eileencodes 提交于
Moves the configs_for and DatabaseConfig struct into it's own file. I was considering doing this in a future refactoring but our set up forced me to move it now. You see there are `mattr_accessor`'s on the Core module that have default settings. For example the `schema_format` defaults to Ruby. So if I call `configs_for` or any methods in the Core module it will reset the `schema_format` to `:ruby`. By moving it to it's own class we can keep the logic contained and avoid this unfortunate issue. The second change here does a double loop over the yaml files. Bear with me... Our tests dictate that we need to load an environment before our rake tasks because we could have something in an environment that the database.yml depends on. There are side-effects to this and I think there's a deeper bug that needs to be fixed but that's for another issue. The gist of the problem is when I was creating the dynamic rake tasks if the yaml that that rake task is calling evaluates code (like erb) that calls the environment configs the code will blow up because the environment is not loaded yet. To avoid this issue we added a new method that simply loads the yaml and does not evaluate the erb or anything in it. We then use that yaml to create the task name. Inside the task name we can then call `load_config` and load the real config to actually call the code internal to the task. I admit, this is gross, but refactoring can't all be pretty all the time and I'm working hard with `@tenderlove` to refactor much more of this code to get to a better place re connection management and rake tasks.
-
由 Kasper Timm Hansen 提交于
-