1. 30 3月, 2018 12 次提交
  2. 29 3月, 2018 3 次提交
  3. 28 3月, 2018 2 次提交
  4. 27 3月, 2018 4 次提交
  5. 26 3月, 2018 2 次提交
  6. 25 3月, 2018 3 次提交
    • A
      Make engine check more explicit · 9232ba71
      Andrew White 提交于
      Not everything that responds to `routes` is a Rails engine - for example
      a Grape API endpoint will have a `routes` method but can't be used with
      `assert_recognizes` as it doesn't respond to `recognize_path_with_request`.
      
      Fixes #32312.
      9232ba71
    • Y
      Remove unused `serialize` method · 8881d843
      yuuji.yaginuma 提交于
      8881d843
    • E
      Don't unset foreign key when preloading missing record · 0cdeda58
      Eugene Kenny 提交于
      When a belongs to association's target is set, its foreign key is now
      updated to match the new target. This is the correct behaviour when a
      new record is assigned, but not when the existing record is preloaded.
      
      As long as we mark the association as loaded, we can skip setting the
      target when the record is missing and avoid clobbering the foreign key.
      0cdeda58
  7. 24 3月, 2018 1 次提交
  8. 23 3月, 2018 7 次提交
  9. 22 3月, 2018 6 次提交
    • Y
    • D
      Move fk_ignore_pattern from config.active_record to SchemaDumper · f6e612b2
      David Stosik 提交于
      This makes more sense, as the foreign key ignore pattern is only used by
      the schema dumper.
      f6e612b2
    • A
      Use ASCII-8BIT paths in ActionDispatch::Static · 2ef14588
      Andrew White 提交于
      The rack gem returns PATH_INFO as an ASCII-8BIT encoded string but it
      was being converted to US-ASCII by the match? method because it was
      calling Rack::Utils.escape_path. To prevent incompatibile encoding
      warnings use ASCII-8BIT strings for the root path and let Ruby handle
      any filename encoding conversion.
      
      Fixes #32294, Closes #32314.
      2ef14588
    • R
      Merge pull request #31869 from BKSpurgeon/patch-1 · 4c9c3ffc
      Ryuta Kamizono 提交于
      [ci skip] Update Action Mailer Documentation
      4c9c3ffc
    • E
      Refactor configs_for and friends · 4e663c1e
      eileencodes 提交于
      Moves the configs_for and DatabaseConfig struct into it's own file. I
      was considering doing this in a future refactoring but our set up forced
      me to move it now. You see there are `mattr_accessor`'s on the Core
      module that have default settings. For example the `schema_format`
      defaults to Ruby. So if I call `configs_for` or any methods in the Core
      module it will reset the `schema_format` to `:ruby`. By moving it to
      it's own class we can keep the logic contained and avoid this
      unfortunate issue.
      
      The second change here does a double loop over the yaml files. Bear with
      me...
      
      Our tests dictate that we need to load an environment before our rake
      tasks because we could have something in an environment that the
      database.yml depends on. There are side-effects to this and I think
      there's a deeper bug that needs to be fixed but that's for another
      issue. The gist of the problem is when I was creating the dynamic rake
      tasks if the yaml that that rake task is calling evaluates code (like
      erb) that calls the environment configs the code will blow up because
      the environment is not loaded yet.
      
      To avoid this issue we added a new method that simply loads the yaml and
      does not evaluate the erb or anything in it. We then use that yaml to
      create the task name. Inside the task name we can then call
      `load_config` and load the real config to actually call the code
      internal to the task. I admit, this is gross, but refactoring can't all
      be pretty all the time and I'm working hard with `@tenderlove` to
      refactor much more of this code to get to a better place re connection
      management and rake tasks.
      4e663c1e
    • K
      Use try in tests that try to test try. · 242ae67e
      Kasper Timm Hansen 提交于
      242ae67e