1. 14 11月, 2014 9 次提交
  2. 13 11月, 2014 2 次提交
  3. 12 11月, 2014 8 次提交
  4. 11 11月, 2014 16 次提交
  5. 10 11月, 2014 5 次提交
    • S
    • Y
      2a843b35
    • G
      Remove useless `only_path: true` in path helpers · 6625000b
      Godfrey Chan 提交于
      We added a deprecation warning for these cases in aa1fadd4, so these are now
      causing deprecation warnings in the test output. AFAICT, in these two cases, the
      option is not integral to the purpose of the test, so they can be safely removed
      6625000b
    • G
      Pass the route name explicitly · aa6637d1
      Godfrey Chan 提交于
      Follow up to 212057b9. Since that commit, we need to pass the `route_name`
      explicitly. This is one of the left-over cases that was not handled in that
      commit, which was causing `use_route` to be ignored in functional tests.
      aa6637d1
    • S
      Revert the behavior of booleans in string columns to that of 4.1 · 52c3a16f
      Sean Griffin 提交于
      Why are people assigning booleans to string columns? >_>
      
      We unintentionally changed the behavior on Sqlite3 and PostgreSQL.
      Boolean values should cast to the database's representation of true and
      false. This is 't' and 'f' by default, and "1" and "0" on Mysql. The
      implementation to make the connection adapter specific behavior is hacky
      at best, and should be re-visted once we decide how we actually want to
      separate the concerns related to things that should change based on the
      database adapter.
      
      That said, this isn't something I'd expect to change based on my
      database adapter. We're storing a string, so the way the database
      represents a boolean should be irrelevant. It also seems strange for us
      to give booleans special behavior at all in string columns. Why is
      `to_s` not sufficient? It's inconsistent and confusing. Perhaps we
      should consider deprecating in the future.
      
      Fixes #17571
      52c3a16f