- 25 1月, 2019 4 次提交
-
-
由 Kevin Deisz 提交于
Allows aliasing, predications, ordering, and various other functions on `And` and `Case` nodes. This brings them in line with other nodes like `Binary` and `Unary`.
-
由 Rafael França 提交于
Fix deeply nested namespace command printing
-
由 Gannon McGibbon 提交于
-
由 George Claghorn 提交于
Don't upsize images smaller than the specified dimensions.
-
- 24 1月, 2019 10 次提交
-
-
由 Ryuta Kamizono 提交于
Currently `conn.column_exists?("testings", "created_at", "datetime")` returns false even if the table has the `created_at` column. That reason is that `column.type` is a symbol but passed `type` is not normalized to symbol unlike `column_name`, it is surprising behavior to me. I've improved that to normalize a value before comparison.
-
由 Yuji Yaginuma 提交于
Fix document formatting on Action Text docs [ci skip]
-
由 colorbox 提交于
Use `+` instead of backquote.
-
由 Aaron Patterson 提交于
Pass the view around instead of using an ivar
-
由 Xavier Noria 提交于
-
由 Ryuta Kamizono 提交于
activerecord: Fix statement cache for strictly cast attributes
-
由 Aaron Patterson 提交于
If we pass the view instance around it's easier to understand the flow control.
-
由 Dylan Thacker-Smith 提交于
-
由 Rafael França 提交于
Subdomains of localhost are safe against DNS rebinding
-
由 Kasper Timm Hansen 提交于
Fix attribute typo in ActionCable connection test request
-
- 23 1月, 2019 13 次提交
-
-
由 Sergey Ponomarev 提交于
-
由 Marc Schütz 提交于
-
由 George Claghorn 提交于
Corrected spelling of ActionCable::Connection::TestCase [ci skip]
-
由 Alan Brown 提交于
-
由 Rafael França 提交于
Revert ensure external redirects are explicitly allowed
-
由 Rafael França 提交于
Fix NumericalityValidator on object responding to `to_f`:
-
由 Ryuta Kamizono 提交于
MySQL 8.0.14 adds `ER_FK_INCOMPATIBLE_COLUMNS`
-
由 Edouard CHIN 提交于
- If you had a PORO that acted like a Numeric, the validator would work correctly because it was previously using `Kernel.Float` which is implicitely calling `to_f` on the passed argument. Since rails/rails@d126c0d , we are now using `BigDecimal` which does not implicitely call `to_f` on the argument, making the validator fail with an underlying `TypeError` exception. This patch replate the `is_decimal?` check with `Kernel.Float`. Using `Kernel.Float` as argument for the BigDecimal call has two advantages: 1. It calls `to_f` implicetely for us. 2. It's also smart enough to detect that `Kernel.Float("a")` isn't a Numeric and will raise an error. We don't need the `is_decimal?` check thanks to that. Passing `Float::DIG` as second argument to `BigDecimal` is mandatory because the precision can't be omitted when passing a Float. `Float::DIG` is what is used internally by ruby when calling `123.to_d` https://github.com/ruby/ruby/blob/trunk/ext/bigdecimal/lib/bigdecimal/util.rb#L47 - Another small issue introduced in https://github.com/rails/rails/pull/34693 would now raise a TypeError because `Regexp#===` will just return false if the passed argument isn't a string or symbol, whereas `Regexp#match?` will.
-
由 Rafael França 提交于
Actionpack typo fixes.
-
由 Aaron Patterson 提交于
Template Handler Refactoring
-
由 alkesh26 提交于
2. Typo fixes.
-
由 Gannon McGibbon 提交于
-
由 Eileen M. Uchitelle 提交于
Replaced webserver with web server
-
- 22 1月, 2019 4 次提交
-
-
由 alkesh26 提交于
-
由 Yasuo Honda 提交于
https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-14.html > Error messages relating to creating and dropping foreign keys > were improved to be more specific and informative. (Bug #28526309, Bug #92087) https://dev.mysql.com/doc/refman/8.0/en/server-error-reference.html > Error number: 3780; Symbol: ER_FK_INCOMPATIBLE_COLUMNS; SQLSTATE: HY000 > Message: Referencing column '%s' and referenced column '%s' in foreign key constraint '%s' are incompatible. > ER_FK_INCOMPATIBLE_COLUMNS was added in 8.0.14.
-
由 Ryuta Kamizono 提交于
Alias case nodes
-
由 Andrew White 提交于
Fix year value when casting a multiparameter time hash
-
- 21 1月, 2019 8 次提交
-
-
由 Kevin Deisz 提交于
When `Arel` was merged into `ActiveRecord` we lost the ability to alias case nodes. This adds it back.
-
由 Ryuta Kamizono 提交于
Add Channel tests to `rails stats`
-
由 Ryuta Kamizono 提交于
Add missing entries to guides' changelog file [ci skip]
-
由 bogdanvlviv 提交于
Rails generates `test/channels`(#34933) and even allows `rails test:channels` (#34947). `rails stats` has been providing info about `app/channels`, it makes sense to add `test/channels` as well. (I've changed test because we generate `test/channels` with some code)
-
由 Andrew White 提交于
When assigning a hash to a time attribute that's missing a year component (e.g. a `time_select` with `:ignore_date` set to `true`) then the year defaults to 1970 instead of the expected 2000. This results in the attribute changing as a result of the save. Before: event = Event.new(start_time: { 4 => 20, 5 => 30 }) event.start_time # => 1970-01-01 20:30:00 UTC event.save event.reload event.start_time # => 2000-01-01 20:30:00 UTC After: event = Event.new(start_time: { 4 => 20, 5 => 30 }) event.start_time # => 2000-01-01 20:30:00 UTC event.save event.reload event.start_time # => 2000-01-01 20:30:00 UTC
-
由 bogdanvlviv 提交于
We added "Action Mailbox Basics", "Action Text Overview" guides(#34812, #34878) I think it makes to mention about it in the changelog file. (Similar to 7200ec92) Note that entries retain original author since I just moved content from readme files to the guides.
-
由 George Claghorn 提交于
Fix ArgumentError when using S3Service
-
由 Yuichi Takeuchi 提交于
-
- 20 1月, 2019 1 次提交
-
-
由 Ryuta Kamizono 提交于
Report statistics for app/mailboxes
-