- 21 11月, 2018 2 次提交
-
-
由 Eileen Uchitelle 提交于
The connection handler was using the RuntimeRegistry which kind of implies it's a per thread registry. But it's actually per fiber. If you have an application that uses fibers and you're using multiple databases, when you switch the connection handler to swap connections new fibers running on the same thread used to get a different connection id. This PR changes the code to actually use a thread so that we get the same connection. Fixes https://github.com/rails/rails/issues/30047 [Eileen M. Uchitelle, Aaron Patterson, & Arthur Neeves]
-
由 Aaron Patterson 提交于
Fix handling of duplicates for `replace` on has_many-through
-
- 20 11月, 2018 18 次提交
-
-
由 Vipul A M 提交于
Fix typo in development_dependencies_install.md [ci skip]
-
由 Alfonso Jiménez 提交于
-
由 Ryuta Kamizono 提交于
Since #33449, `event.end = Time.now` is not used anymore and should use `event.finish!`. We can't use `deprecate :end=` in definition time in this module due to circular require in `active_support/deprecation/behaviors`.
-
由 Rafael Mendonça França 提交于
ActionMailer: support overriding template name in multipart
-
由 Rafael Mendonça França 提交于
:only and :except are now chained for routing resource(s)
-
由 Rafael França 提交于
Prevent TextHelper#word_wrap from stripping white space on the left side of long lines; Fixes #34487
-
由 Rafael França 提交于
Homogenize also rails help command output
-
由 Rafael Mendonça França 提交于
Permit of ActionController::Parameters for ActiveJob Serializable Argument
-
由 Bernie Chiu 提交于
-
由 Rafael França 提交于
Add comments to markdown templates
-
由 Lyle Mullican 提交于
side of long lines; Fixes #34487
-
由 Alberto Almagro 提交于
In commit 6567464b we homogenized rails commands with former rake tasks. We decided to display all commands at the same level and merged the list of commands displayed by `rails help`. We however forgot to actually merge the output in the command itself. This commit fixes that.
-
由 Alberto Almagro 提交于
The output from `rails help` actually leaves an empty space when printing the command lists. This commit adapts this guide to have the same format.
-
由 Aaron Patterson 提交于
Exercise `connected_to` and `connects_to` methods
-
由 Rafael Mendonça França 提交于
allow right to left styling of docs
-
由 Eileen M. Uchitelle 提交于
Windows support for parallelization and instrumenter
-
由 Eileen M. Uchitelle 提交于
Correctly handle unknown object in parallel tests
-
由 tamarr 提交于
* adding rtl css main file and logic to use
-
- 19 11月, 2018 5 次提交
-
-
由 Ryuta Kamizono 提交于
Update active_job_basics.md [ci skip]
-
由 Shota Iguchi 提交于
ApplicationJob should be inherits ActiveJob::Base
-
由 Gannon McGibbon 提交于
Correct a spelling error
-
由 jacobherrington 提交于
My spellchecker flagged this as an incorrect spelling, upon further research it appears to be a point of contention in English. Either way might work. After further examination queuing is much more common in the Rails codebase so making this change will serve to standardize the spelling.
-
由 jacobherrington 提交于
-
- 18 11月, 2018 2 次提交
-
-
由 yuuji.yaginuma 提交于
These tests are for testing the `rake` method.
-
由 yuuji.yaginuma 提交于
`Journey::Router::RoutingError` is no longer used since db06d128.
-
- 17 11月, 2018 9 次提交
-
-
由 Yuji Yaginuma 提交于
Synchronize ActionCable JS source code with compiled bundle
-
由 yuuji.yaginuma 提交于
DRb wraps in `DRbUnknown` if the data contains a type that can not be resolved locally. This can happen if an error occurs in the test and the error class can not be resolved on the server side. When this happens, an instance of `DRbUnknown` is passed to the `result` of `Server#record`. This causes another error(undefined method assertions for #<DRb::DRbUnknown:> (NoMethodError)) in `reporter.record`. This can confirm by the following steps. ``` $ rails new app -B --dev; cd app $ rails g scaffold user name:string $ edit `config.action_controller.allow_forgery_protection = true` in environments/test.rb $ bin/rails t ``` In the case of `DRbUnknown` occurs, can't resolve error exception. So wrap exception with `DRbRemoteError` in the same way as an unmarshalled object.
-
由 Richard Macklin 提交于
30a0c7e0 commited changes to the compiled bundle but not to the corresponding source files. This meant that running `yarn build` was producing untracked changes to the compiled bundle. The fix is to commit the changes to the source files so that they are in sync.
-
由 Rafael França 提交于
Re-add changes_applied doc
-
由 Gannon McGibbon 提交于
[ci skip]
-
由 Rafael França 提交于
Fix typo and clarify documentation
-
由 Jacob Evelyn 提交于
This commit fixes a small typo in documentation of the "UNLOGGED" table option for PostgreSQL databases, and clarifies the documentation slightly.
-
由 Gannon McGibbon 提交于
[ci skip]
-
由 Gannon McGibbon 提交于
Replace `cache_key` with `cache_key_with_version` on caching_with_rails in Caching with Rails guide [ci skip]
-
- 16 11月, 2018 2 次提交
-
-
由 tnantoka 提交于
-
由 Dmytro Shteflyuk 提交于
* Arel: Implemented DB-aware NULL-safe comparison * Fixed where clause inversion for NULL-safe comparison * Renaming "null_safe_eq" to "is_not_distinct_from", "null_safe_not_eq" to "is_distinct_from" [Dmytro Shteflyuk + Rafael Mendonça França]
-
- 15 11月, 2018 2 次提交
-
-
由 Ryuta Kamizono 提交于
Fix a method call in bin/setup file
-
由 Nihad Abbasov 提交于
Follow up to a725539d
-