- 24 12月, 2016 1 次提交
-
-
由 Akira Matsuda 提交于
-
- 13 11月, 2016 1 次提交
-
-
由 Ryuta Kamizono 提交于
Currently if `CollectionProxy` has more than one new record, `CollectionProxy#uniq` result is incorrect. And `CollectionProxy#uniq` was aliased to `distinct` in a1bb6c8b. But the `uniq` method and the `SELECT DISTINCT` method are different methods. The doc in `CollectionProxy` is for the `SELECT DISTINCT` method, not for the `uniq` method. Therefore, reverting the alias in `CollectionProxy` to fix the inconsistency and to have the both methods.
-
- 22 10月, 2016 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
- CollectionAssociation#select was removed in https://github.com/rails/rails/pull/25989 in favor of QueryMethods#select but it caused a regression when passing arguments to select and a block. - This used to work earlier in Rails 4.2 and Rails 5. See gist https://gist.github.com/prathamesh-sonpatki/a7df922273473a77dfbc742a4be4b618. - This commit restores the behavior of Rails 4.2 and Rails 5.0.0 to allow passing arguments and block at the same time but also deprecates it. - Because, these arguments do not have any effect on the output of select when select is used with a block. - Updated documentation to remove the example passing arguments and block at the same time to `CollectionProxy#select`.
-
- 07 9月, 2016 2 次提交
-
-
由 Vipul A M 提交于
-
由 Aditya Kapoor 提交于
-
- 04 9月, 2016 1 次提交
-
-
由 Ryuta Kamizono 提交于
Simply use its own method because `CollectionProxy` inherits `Relation`.
-
- 19 8月, 2016 2 次提交
-
-
由 Ryuta Kamizono 提交于
Simply use its own methods because `CollectionProxy` inherits `Relation`.
-
由 Ryuta Kamizono 提交于
`length` is delegated to `records` (`load_target`) by `ActiveRecord::Delegation`. https://github.com/rails/rails/blob/v5.0.0/activerecord/lib/active_record/relation/delegation.rb#L38
-
- 18 8月, 2016 2 次提交
-
-
由 Ryuta Kamizono 提交于
Currently `CollectionProxy` inherits `Relation` therefore we can use its own methods rather than delegating to collection association.
-
由 Ryuta Kamizono 提交于
Currently `CollectionProxy` inherits `Relation` and `Relation` includes `QueryMethods`. This method is completely duplicated. https://github.com/rails/rails/blob/v5.0.0/activerecord/lib/active_record/relation/query_methods.rb#L271-L275
-
- 16 8月, 2016 1 次提交
-
-
由 Ryuta Kamizono 提交于
`#second`, `#third`, etc finder methods was added in 03855e79. But the signature of these methods is inconsistent with the original finder methods. And also the signature of `#first` and `#last` methods is different from the original. This commit fixes the inconsistency.
-
- 14 8月, 2016 1 次提交
-
-
由 Ryuta Kamizono 提交于
`#first`, `#second`, ..., `#last` methods respects dirty target. But `#take` doesn't respect it. This commit fixes the inconsistent behavior.
-
- 04 8月, 2016 1 次提交
-
-
由 Ryuta Kamizono 提交于
-
- 28 7月, 2016 1 次提交
-
-
由 Ryuta Kamizono 提交于
-
- 24 7月, 2016 1 次提交
-
-
由 Ryuta Kamizono 提交于
-
- 20 7月, 2016 1 次提交
-
-
由 Ryuta Kamizono 提交于
Fixes #25732.
-
- 15 7月, 2016 1 次提交
-
-
由 Yamaguchi.Tomoki 提交于
-
- 19 5月, 2016 1 次提交
-
-
由 Jeremy Daer 提交于
Ruby 2.4 unifies Fixnum and Bignum into Integer: https://bugs.ruby-lang.org/issues/12005 * Forward compat with new unified Integer class in Ruby 2.4+. * Backward compat with separate Fixnum/Bignum in Ruby 2.2 & 2.3. * Drops needless Fixnum distinction in docs, preferring Integer.
-
- 20 3月, 2016 1 次提交
-
-
由 Erik Michaels-Ober 提交于
-
- 21 2月, 2016 1 次提交
-
-
由 Matthew Draper 提交于
Clarifying this separation and enforcing relation immutability is the culmination of the previous efforts to remove the mutator method delegations.
-
- 11 2月, 2016 1 次提交
-
-
由 Brian Christian 提交于
-
- 10 2月, 2016 1 次提交
-
-
由 Brian Christian 提交于
-
- 14 10月, 2015 2 次提交
-
-
由 Yves Senn 提交于
The focus of this change is to make the API more accessible. References to method and classes should be linked to make it easy to navigate around. This patch makes exzessiv use of `rdoc-ref:` to provide more readable docs. This makes it possible to document `ActiveRecord::Base#save` even though the method is within a separate module `ActiveRecord::Persistence`. The goal here is to bring the API closer to the actual code that you would write. This commit only deals with Active Record. The other gems will be updated accordingly but in different commits. The pass through Active Record is not completely finished yet. A follow up commit will change the spots I haven't yet had the time to update. /cc @fxn
-
由 Yves Senn 提交于
-
- 27 9月, 2015 1 次提交
-
-
由 amitkumarsuroliya 提交于
-
- 09 9月, 2015 1 次提交
-
-
由 Ronak Jangir 提交于
-
- 23 8月, 2015 1 次提交
-
-
由 Ronak Jangir 提交于
-
- 20 7月, 2015 1 次提交
-
-
由 Mehmet Emin İNAÇ 提交于
-
- 18 7月, 2015 1 次提交
-
-
由 Andrii Ponomarov 提交于
-
- 03 6月, 2015 1 次提交
-
-
由 Roque Pinel 提交于
Improve the guide about `has_many` `collection.clear` to indicate the behavior for each dependent strategy according to `collection.delete_all`. Based on #17179, I changed the `collection.delete` docs to also clarify the default strategy for each `hm` and `hm:t` associations. Fixes #20170.
-
- 07 3月, 2015 1 次提交
-
-
由 Prathamesh Sonpatki 提交于
- CollectionProxy#clear method calls delete_all so the SQL is directly run into the database. - So the updated_at column of the object on which its run is not updated. - Closes #17161
-
- 28 2月, 2015 1 次提交
-
-
由 Akira Matsuda 提交于
-
- 21 2月, 2015 1 次提交
-
-
由 Rafael Mendonça França 提交于
-
- 02 1月, 2015 1 次提交
-
-
由 Rafael Mendonça França 提交于
-
- 30 12月, 2014 1 次提交
-
-
由 Sean Griffin 提交于
Fixes #18237
-
- 27 12月, 2014 1 次提交
-
-
由 Sean Griffin 提交于
Construction of relations can be a hotspot, we don't want to create one of these in the constructor. This also allows us to do more expensive things in the predicate builder's constructor, since it's created once per AR::Base subclass
-
- 04 10月, 2014 1 次提交
-
-
由 eileencodes 提交于
For detailed testing of behavior see: https://gist.github.com/eileencodes/5b0a2fe011dcff6203fe This shows destroy_all always destroys records and fires callbacks. It will never use nullify or delete_all delete_all's behavior varies greatly based on `hm` vs `hm:t` and deletion strategy.
-
- 27 8月, 2014 3 次提交
-
-
由 Tom Kadwill 提交于
-
由 Tom Kadwill 提交于
-
由 Tom Kadwill 提交于
-