- 28 5月, 2019 7 次提交
-
-
由 Ryuta Kamizono 提交于
Remove unused requires from debug_exceptions
-
由 yaojie 提交于
-
由 Prem Sichanugrist 提交于
[documentation][ci skip] changes 'Week day' to 'day of week'
-
由 Corprew Reed 提交于
'Week day' has a specific meaning in English -- see https://en.wiktionary.org/wiki/weekday for details -- that is not meant here. 'Day of week' is more appropriate. [ci skip]
-
由 Akira Matsuda 提交于
-
由 Rafael França 提交于
Use WeakRef in Reaper to avoid leaking connection pools
-
由 John Hawthorn 提交于
Prior to 3e2e8eeb the Reaper thread would hold a reference to connection pools indefinitely, preventing the connection pool from being garbage collected, and also leaking the Thread. Since 3e2e8eeb, there is only one Reaper Thread for all pools, however all pools are still stored in a class variable, preventing them from being garbage collected. This commit instead holds reference to the pools through a WeakRef. This way, connection pools referenced elsewhere will be reaped, any others will be able to be garbage collected. I don't love resorting to WeakRef to solve this, but I believe it's the simplest way to accomplish the the desired behaviour.
-
- 27 5月, 2019 2 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Kasper Timm Hansen 提交于
-
- 26 5月, 2019 1 次提交
-
-
由 Ryuta Kamizono 提交于
Change comments [ci skip]
-
- 25 5月, 2019 3 次提交
-
-
由 Edu Depetris 提交于
-
由 Kasper Timm Hansen 提交于
Fix EventedFileUpdateChecker through a symlink
-
由 Kasper Timm Hansen 提交于
-
- 24 5月, 2019 8 次提交
-
-
由 Rafael França 提交于
Wrap ActionView cache expiry in a mutex
-
由 Rafael França 提交于
Delete evented_file_update_checker existing_parent
-
由 John Hawthorn 提交于
On MacOS, Dir.tmpdir gives me a folder inside "/var/folders/". However, /var is a symlink to /private/var. Previously, the nonexistent directory test would fail because it was initialized with /var/folders/... but the filenames from listen would be the realpaths. This commit normalizes the dirs by calling realpath on them if they exist. This is done on boot!, so it will work with newly directories through the symlink.
-
由 John Hawthorn 提交于
The common include of this test creates a tmpdir, we should use that for consistency.
-
由 John Hawthorn 提交于
This is no longer used as of caa3cc88
-
由 Rafael França 提交于
Bump Gemfile entry jbuilder version
-
由 George Claghorn 提交于
Add :allow_nil option to delegate_missing_to
-
由 Matt Tanous 提交于
attachment
-
- 23 5月, 2019 8 次提交
-
-
由 Anton Rieder 提交于
jbuilder 2.6.4 is the first version that relaxes the version constraint to allow Rails 6. I also did some more tests in #25183, although not with 2.6.4 explicitly. To simplify the version requirement, I went for 2.7. https://github.com/rails/jbuilder/blob/v2.6.4/jbuilder.gemspec https://github.com/rails/rails/issues/25183#issuecomment-494342406
-
由 Gannon McGibbon 提交于
Keep part when scope option has value
-
由 Alberto Almagro 提交于
After @kamipo CR feedback we realized `Route#build` wasn't used. As it is also private API being able to create Routes both with `#new` and `#build` was redundant.
-
由 Alberto Almagro 提交于
This commit changes from constructor's argument list to keyword arguments in order to remove the dependency of remember parameters' positions. It also unifies all parameters extracted from the `scope` into `scope_params`, which also takes care of providing the default values for them.
-
由 Alberto Almagro 提交于
This commit changes from constructor's argument list to keyword arguments in order to remove the dependency of remember parameters' positions. The constructor already provided a default value for `internal`, this commits takes the chance to also add default values for `precedence` and `scope_options`.
-
由 Alberto Almagro 提交于
When a route was defined within an optional scope, if that route didn't take parameters the scope was lost when using path helpers. This patch ensures scope is kept both when the route takes parameters or when it doesn't. Fixes #33219
-
由 George Claghorn 提交于
-
由 Rafael França 提交于
Remove compatibility module from docs [ci skip]
-
- 22 5月, 2019 9 次提交
-
-
由 Alan Wu 提交于
This module exists to warn old users. I think we should remove it from the docs so we don't advertise it.
-
由 Rafael França 提交于
Added deep_transform_keys to StrongParameters
-
由 Gustavo Gutierrez 提交于
-
由 प्रथमेश Sonpatki 提交于
- This hook was added in 90296674
-
由 Rafael França 提交于
[CI skip] Put :nodoc: on method that raises NoMethodError
-
由 John Hawthorn 提交于
-
由 Ryuta Kamizono 提交于
And no longer need to except SCHEMA SQLs manually since 0810c076.
-
由 Alan Wu 提交于
This method is not intended to be used so I think we should remove it from the docs.
-
由 Ryuta Kamizono 提交于
This reverts commit a1ee4a9f. Even if a1ee4a9f is applied, CI is still flakiness. https://buildkite.com/rails/rails/builds/61252#2c090afa-aa84-4a2b-8b81-9f09219222c6/994-1005 https://buildkite.com/rails/rails/builds/61252#2e55bf83-1bde-44a2-a4f1-b5c3f6820fb4/929-938 Failing tests by whether schema cache is filled or not, it actually means that whether SCHEMA SQLs are executed or not is not target for the tests. So I've reverted commit a1ee4a9f which filling schema cache before `assert_no_queries`, and replace `assert_no_queries` to `assert_queries(0)`.
-
- 21 5月, 2019 2 次提交
-
-
由 Ryuta Kamizono 提交于
Almost all database statements methods except `explain` was moved into `DatabaseStatements` at #35922. This moves the last one method.
-
由 Ryuta Kamizono 提交于
Fall back to type casting from the connection adapter
-