1. 31 12月, 2014 1 次提交
  2. 18 11月, 2014 2 次提交
  3. 25 8月, 2014 1 次提交
  4. 24 8月, 2014 1 次提交
  5. 30 5月, 2014 2 次提交
  6. 08 5月, 2014 1 次提交
  7. 11 4月, 2014 2 次提交
  8. 21 3月, 2014 1 次提交
  9. 20 3月, 2014 1 次提交
    • J
      Postgres schema: Constrain sequence search classid · 0110d7b7
      Josh Williams 提交于
      The pk_an_sequence_for query previously joined against pg_class's oid
      for rows in pg_depend, but pg_depend's objid may point to other system
      tables, such as pg_attrdef.  If a row in one of those other tables
      coincidentally has the same oid as an (unrelated) sequence, that
      sequence name may be returned instead of the real one.
      
      This ensures that only the pg_depend entries pointing to pg_class are
      considered.
      0110d7b7
  10. 13 2月, 2014 1 次提交
  11. 29 12月, 2013 1 次提交
  12. 23 12月, 2013 1 次提交
    • S
      Tell how to Create a Database in Error Message · 0ec45cd1
      schneems 提交于
      Currently if you attempt to use a database that does not exist  you get an error:
      
      ```
      PG::ConnectionBad FATAL:  database "db_error" does not exist
      ```
      
      The solution is easy, create and migrate your database however new developers may not know these commands by memory. Instead of requiring the developer to search for a solution, tell them how to fix the problem in the error message:
      
      ```
      ActiveRecord::NoDatabase: FATAL:  database "db_error" does not exist
      Run `$ bin/rake db:create db:migrate` to create your database
      ```
      
      Active Record should not know about `rake db:migrate` so this additional information needs to come from the railtie. Potential alternative implementation suggestions are welcome.
      0ec45cd1
  13. 19 12月, 2013 1 次提交
  14. 15 8月, 2013 1 次提交
  15. 03 7月, 2013 1 次提交
  16. 13 5月, 2013 1 次提交
  17. 10 5月, 2013 1 次提交
    • B
      Fix that #exists? can produce invalid SQL: "SELECT DISTINCT DISTINCT" · 15d6e4dc
      Ben Woosley 提交于
      The combination of a :uniq => true association and the #distinct call
      in #construct_limited_ids_condition combine to create invalid SQL, because
      we're explicitly selecting DISTINCT, and also sending #distinct on to AREL,
      via the relation#distinct_value.
      
      Rather than build a select distinct clause in #construct_limited_ids_condition,
      I set #distinct! and pass just the columns into the select statement.
      This requires introducing a #columns_for_distinct method to return the
      select columns but not the statement itself.
      15d6e4dc
  18. 26 3月, 2013 1 次提交
  19. 01 3月, 2013 1 次提交
  20. 16 2月, 2013 1 次提交
    • J
      Revert "checking in the abstractions for valid type checking:" · c65b0763
      Jon Leighton 提交于
      This reverts commit c321b309.
      
      Conflicts:
      	activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb
      	activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb
      
      Reason: failing test
      
        1) Error:
      test_valid_column(ActiveRecord::ConnectionAdapters::SQLite3AdapterTest):
      NoMethodError: undefined method `column' for
          test/cases/adapters/sqlite3/sqlite3_adapter_test.rb:29:in
      `test_valid_column'
      c65b0763
  21. 12 2月, 2013 1 次提交
  22. 21 11月, 2012 1 次提交
  23. 05 10月, 2012 1 次提交
  24. 08 4月, 2012 1 次提交
  25. 02 4月, 2012 1 次提交
  26. 01 4月, 2012 2 次提交
  27. 25 2月, 2012 1 次提交
  28. 09 2月, 2012 1 次提交
  29. 11 6月, 2011 1 次提交
  30. 10 6月, 2011 2 次提交
    • P
      apply private method indentation convention · 019c2636
      Paul Gallagher 提交于
      * tidy test code and fix my typo 
      019c2636
    • P
      Improve PostgreSQL adapter schema-awareness · 5c7f8c92
      Paul Gallagher 提交于
      * table_exists? scoped by schema search path unless schema is explicitly named. Added tests and doc to clarify the behaviour
      * extract_schema_and_table tests and implementation extended to cover all cases
      * primary_key does not ignore schema information
      * add current_schema and schema_exists? methods
      * more robust table referencing in insert_sql and sql_for_insert methods
      5c7f8c92
  31. 07 6月, 2011 1 次提交
  32. 05 6月, 2011 1 次提交
    • J
      Refactor Active Record test connection setup. Please see the... · 253bb6b9
      Jon Leighton 提交于
      Refactor Active Record test connection setup. Please see the RUNNING_UNIT_TESTS file for details, but essentially you can now configure things in test/config.yml. You can also run tests directly via the command line, e.g. ruby path/to/test.rb (no rake needed, uses default db connection from test/config.yml). This will help us fix the CI by enabling us to isolate the different Rails versions to different databases.
      253bb6b9
  33. 14 4月, 2011 1 次提交
  34. 12 4月, 2011 2 次提交