- 18 1月, 2018 1 次提交
-
-
由 Koichi ITO 提交于
### Summary This PR changes .rubocop.yml. Regarding the code using `if ... else ... end`, I think the coding style that Rails expects is as follows. ```ruby var = if cond a else b end ``` However, the current .rubocop.yml setting does not offense for the following code. ```ruby var = if cond a else b end ``` I think that the above code expects offense to be warned. Moreover, the layout by autocorrect is unnatural. ```ruby var = if cond a else b end ``` This PR adds a setting to .rubocop.yml to make an offense warning and autocorrect as expected by the coding style. And this change also fixes `case ... when ... end` together. Also this PR itself is an example that arranges the layout using `rubocop -a`. ### Other Information Autocorrect of `Lint/EndAlignment` cop is `false` by default. https://github.com/bbatsov/rubocop/blob/v0.51.0/config/default.yml#L1443 This PR changes this value to `true`. Also this PR has changed it together as it is necessary to enable `Layout/ElseAlignment` cop to make this behavior.
-
- 11 7月, 2017 1 次提交
-
-
由 Koichi ITO 提交于
-
- 09 7月, 2017 1 次提交
-
-
由 Kir Shatrov 提交于
-
- 02 7月, 2017 1 次提交
-
-
由 Matthew Draper 提交于
This reverts commit 3420a145, reversing changes made to afb66a5a.
-
- 01 7月, 2017 1 次提交
-
-
由 Kir Shatrov 提交于
-
- 23 5月, 2017 1 次提交
-
-
由 bogdanvlviv 提交于
".. with __dir__ we can restore order in the Universe." - by @fxn Related to 5b8738c2
-
- 20 4月, 2017 1 次提交
-
-
由 Willem van Bergen 提交于
Send deprecation horizon and gem name as arguments to deprecation heavier handler, and make sure they are used for the ActiveSupport::Notifications message.
-
- 15 2月, 2017 1 次提交
-
-
由 kenta-s 提交于
-
- 07 8月, 2016 2 次提交
-
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
The current code base is not uniform. After some discussion, we have chosen to go with double quotes by default.
-
- 12 4月, 2016 1 次提交
-
-
由 Vipul A M 提交于
- we are ending sentences properly - fixing of space issues - fixed continuity issues in some sentences. Reverts https://github.com/rails/rails/commit/8fc97d198ef31c1d7a4b9b849b96fc08a667fb02 . This change reverts making sure we add '.' at end of deprecation sentences. This is to keep sentences within Rails itself consistent and with a '.' at the end.
-
- 24 2月, 2016 2 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
Fixes #22982.
-
- 04 11月, 2015 1 次提交
-
-
由 Rafael Mendonça França 提交于
When a frame is an eval block without filename argument there is no absolute_path so the previous implementation would fail because `nil` doesn't responds to `start_with?`.
-
- 25 8月, 2015 1 次提交
-
-
由 Aaron Patterson 提交于
We have `caller_locations`, so we don't need to parse the strings in the callstack.
-
- 30 10月, 2012 1 次提交
-
-
由 Alexey Gaziev 提交于
-
- 15 9月, 2012 1 次提交
-
-
由 Francesco Rodriguez 提交于
-
- 14 9月, 2012 2 次提交
-
-
由 Arun Agrawal 提交于
-
由 Rafael Mendonça França 提交于
-
- 13 9月, 2012 2 次提交
-
-
由 Piotr Niełacny 提交于
ActiveSupport::Deprecation is now a class rather than a module. You can get instance of ActiveSupport::Deprecation calling #instance method. ActiveSupport::Deprecation.instance But when you need to get new object od ActiveSupport::Deprecation you need to just call #new. @instance = ActiveSupport::Deprecation.new Since you can create a new object, you can change the version and the name of the library where the deprecator concerned. ActiveSupport::Deprecation.new('2.0', 'MyGem') If you need use another deprecator instance you can select it in the options of deprecate method. deprecate :method, :deprecator => deprecator_instance Documentation has been updated.
-
由 Robert Pankowecki 提交于
test local deprecation deprecator object Test ActiveSupport::Deprecation when included
-
- 23 6月, 2012 1 次提交
-
-
由 Vijay Dev 提交于
-
- 18 6月, 2012 1 次提交
-
-
由 Francesco Rodriguez 提交于
-
- 27 4月, 2011 1 次提交
-
-
由 Vijay Dev 提交于
-
- 13 1月, 2011 1 次提交
-
-
由 Aaron Patterson 提交于
-
- 21 12月, 2010 1 次提交
-
-
由 Ryan Bigg 提交于
-
- 25 8月, 2010 1 次提交
-
-
由 Jakub Suder 提交于
now the reported line is the first line in the stack that's outside Rails, which is the one that actually caused the problem in the first place [#5231 state:resolved] Signed-off-by: NJosé Valim <jose.valim@gmail.com>
-
- 01 7月, 2010 1 次提交
-
-
由 José Valim 提交于
-
- 06 3月, 2010 1 次提交
-
-
由 Jeremy Kemper 提交于
-
- 18 4月, 2009 1 次提交
-
-
由 Jeremy Kemper 提交于
-