- 07 12月, 2015 1 次提交
-
-
由 Genadi Samokovarov 提交于
Those are actually shortcuts for `after_commit`. Before: after_commit :add_to_index_later, on: :create after_commit :update_in_index_later, on: :update after_commit :remove_from_index_later, on: :destroy After: after_create_commit :add_to_index_later after_update_commit :update_in_index_later after_destroy_commit :remove_from_index_later
-
- 06 12月, 2015 9 次提交
-
-
由 Arthur Nogueira Neves 提交于
Add redirection path in the error message of assert_response if response is :redirect
-
由 Kasper Timm Hansen 提交于
When `parse_options_for` was called for a command that hadn't set up any option parsing with `options_for`, the `call` method would be sent to `-> {}`, which didn't like to be passed two arguments. Switch to `proc {}` which can accept several arguments.
-
由 Arthur Nogueira Neves 提交于
even if a write fails, store the raw value
-
由 Kasper Timm Hansen 提交于
I want to streamline the wording around `command`, and not start pondering about instances.
-
由 Kasper Timm Hansen 提交于
The `ARGV` constant in Ruby is not a string, it's an array as demonstrated by running: ``` $ ruby -e "p ARGV" => [] $ $ ruby -e "p ARGV" test/file.rb --version=2 => ["test/file.rb", "--version=2"] ```
-
由 Kasper Timm Hansen 提交于
* Ditch the instance methods local variable. * Prefer Ruby's default nil return, and remove else branch.
-
由 Kasper Timm Hansen 提交于
Checking that a command exists before running it is an implementation detail of the Rails command and Rake task world right now. Eventually I'd like to get rid of `exists?`, when I've worked out another way to fall back to run the old tasks.
-
由 Kasper Timm Hansen 提交于
Users shouldn't have to lookup the command name for a task. Put it in the private section, so it doesn't show up in any generated documentation.
-
由 Matthew Draper 提交于
The previous spelling seemed a bit too generous with the whitespace, and looked out of place when amongst others.
-
- 05 12月, 2015 6 次提交
-
-
由 Sean Griffin 提交于
Add note about serialization to update_columns documentation [ci skip]
-
由 James Wen 提交于
-
由 Sean Griffin 提交于
remove warning from postgresql geometric test
-
由 yuuji.yaginuma 提交于
This removes the following warning which has been out in the case of a PostgreSQL 9.3 below. ``` activerecord/test/cases/adapters/postgresql/geometric_test.rb:265: warning: instance variable @connection not initialized ```
-
由 Kasper Timm Hansen 提交于
Add Rails command infrastructure
-
由 Chuck Callebs 提交于
-
- 04 12月, 2015 8 次提交
-
-
由 Prathamesh Sonpatki 提交于
- If the assert_response is checking for any non-redirect response like :success and actual response is :redirect then, the error message displayed was - Expected response to be a <success>, but was <302> - This commit adds the redirect path to the error message of assert_response if the response is :redirect. So above message is changed to - Expected response to be a <success>, but was a redirect to <http://test.host/posts/lol>
-
由 Rafael França 提交于
Replace ActionMailer::Base.respond_to? with respond_to_missing?
-
由 Rafael França 提交于
Fix the Railties tests
-
由 Rafael Mendonça França 提交于
Railsties tests are broken with this new update checker so we will use the old one until we have the tests fixed.
-
由 Rafael Mendonça França 提交于
Related with e62ddac0
-
由 Rafael Mendonça França 提交于
Related with 668c006c.
-
由 Rafael Mendonça França 提交于
-
由 Ryan Buckley 提交于
-
- 03 12月, 2015 8 次提交
-
-
由 Ryan Buckley 提交于
-
由 Claudio B 提交于
Remove old comment about AC::Parameters>subclasses
-
由 claudiob 提交于
[ci skip] Q: What happens if you initialize an AR model by passing Parameters that have not been whitelisted with `permit`? A: An `ActiveModel::ForbiddenAttributesError` is raised. I think this behavior is correct, and it's better than what used to happen, with unpermitted parameter being simply ignored.
-
由 Rafael França 提交于
Fix failing test using custom file watcher
-
由 Rafael França 提交于
Revert "don't start a new process for every test file"
-
由 Matthew Erhard 提交于
This reverts commit 5a0e0e72. This commit causes railties tests on TravisCI to always return a 0 status (all tests passing), even when tests are failing. Reverting for now until a new solution can be found.
-
由 Matthew Erhard 提交于
LoadingTest#test_does_not_reload_constants_on_development_if_custom_file_watcher_always_returns_false in railties/test/application/loading_test.rb is failing with: `NoMethodError: undefined method 'execute' for #<#<Class:0x00000002465a30>:0x00000001f79698>` The test creates an anonymous class to be used as a custom file watcher using `config.file_watcher=`. Per the Rails guides for Configuring, the class set to `config.file_watcher` “Must conform to ActiveSupport::FileUpdateChecker API”. Per the docs for ActiveSupport::FileUpdateChecker, the API depends on four methods: #initialize, #updated?, #execute, and #execute_if_updated. The custom file watcher in the failing test only implements the first two methods. This pull request adds #execute and #execute_if_updated to the custom file_watcher, conforming it to the ActiveSupport::FileUpdateChecker API, and passing the test.
-
由 Yves Senn 提交于
This will also get the defaults from attribute definitions like: attribute :type, :string, default: "SomethingElse"
-
- 02 12月, 2015 8 次提交
-
-
由 Yves Senn 提交于
`has_attribute?` method to check wether a given attribute has been defined.
-
由 Yves Senn 提交于
This solves the following error: ActiveRecord::StatementInvalid: Could not find table 'guitars' It seems that the table structure of the `Guitar` model has not been necessary until now. Due to the wrong table name the model was not correctly linked to the table.
-
由 Yves Senn 提交于
STI cast new instances to `default type` on initialize.
-
由 Kuldeep Aggarwal 提交于
fixes #17121
-
由 Claudio B 提交于
Update autoloading_and_reloading_constants.md
-
由 Sean Griffin 提交于
It appears that I missed this one when I delegated all the non-mutation array methods that were not on Enumerable
-
由 pavlos 提交于
Fixed a typo
-
由 Claudio B 提交于
Modify unscoped usage guide to include chaining [ci skip]
-