- 23 10月, 2015 1 次提交
-
-
由 Grey Baker 提交于
-
- 22 10月, 2015 2 次提交
-
-
由 Timo Schilling 提交于
`Forwardable` has been used in the past
- 21 10月, 2015 1 次提交
-
-
由 Sean Griffin 提交于
parse RSS/ATOM responses as XML, not HTML
-
- 20 10月, 2015 1 次提交
-
-
由 yui-knk 提交于
When `require 'active_support/rails'`, 'active_support/deprecation' is automatically loaded.
-
- 19 10月, 2015 1 次提交
-
-
由 Agis Anastasopoulos 提交于
Prior to this change, given a route: # config/routes.rb get ':a' => "foo#bar" If one pointed to http://example.com/%BE (param `a` has invalid encoding), a `BadRequest` would be raised with the following non-informative message: ActionController::BadRequest From now on the message displayed is: Invalid parameter encoding: hi => "\xBE" Fixes #21923.
-
- 10 10月, 2015 2 次提交
-
-
由 Rafael Sales 提交于
When an application has multiple root entries with different constraints, the current solution is to use `get '/'`. Example: **Currently I have to do:** ```ruby get '/', to: 'portfolio#show', constraints: ->(req) { Hostname.portfolio_site?(req.host) } get '/', to: 'blog#show', constraints: ->(req) { Hostname.blog_site?(req.host) } root 'landing#show' ``` **But I would like to do:** ```ruby root 'portfolio#show', constraints: ->(req) { Hostname.portfolio_site?(req.host) } root 'blog#show', constraints: ->(req) { Hostname.blog_site?(req.host) } root 'landing#show' ``` Other URL matchers such as `get`, `post`, etc, already allows this, so I think it's fair that `root` also allow it since it's just a shortcut for a `get` internally.
-
由 Ronak Jangir 提交于
-
- 08 10月, 2015 1 次提交
-
-
由 Matthew Erhard 提交于
When generating the url for a mounted engine through its proxy, the path should be the sum of three parts: 1. Any `SCRIPT_NAME` request header or the value of `ActionDispatch::Routing::RouteSet#relative_url_root`. 2. A prefix (the engine's mounted path). 3. The path of the named route inside the engine. Since commit https://github.com/rails/rails/commit/44ff0313c121f528a68b3bd21d6c7a96f313e3d3, this has been broken. Step 2 has been changed to: 2. A prefix (the value of `ActionDispatch::Routing::RouteSet#relative_url_root` + the engine's mounted path). The value of `ActionDispatch::Routing::RouteSet#relative_url_root` is taken into account in step 1 of the route generation and should be ignored when generating the mounted engine's prefix in step 2. This commit fixes the regression by having `ActionDispatch::Routing::RouteSet#url_for` check `options[:relative_url_root]` before falling back to `ActionDispatch::Routing::RouteSet#relative_url_root`. The prefix generating code then sets `options[:relative_url_root]` to an empty string. This empty string is used instead of `ActionDispatch::Routing::RouteSet#relative_url_root` and avoids the duplicate `relative_url_root` value in the final result. This resolves #20920 and resolves #21459
-
- 07 10月, 2015 5 次提交
-
-
由 Aaron Patterson 提交于
Use the methods rack provides so we don't have to worry about the exact header key.
-
由 Aaron Patterson 提交于
Rack implements the Etag header manipulation methods, so we can use those instead of ours.
-
由 Jeremy Daer 提交于
Rails 4.x and earlier didn't support `Mime::Type[:FOO]`, so libraries that support multiple Rails versions would've had to feature-detect whether to use `Mime::Type[:FOO]` or `Mime::FOO`. `Mime[:foo]` has been around for ages to look up registered MIME types by symbol / extension, though, so libraries and plugins can safely switch to that without breaking backward- or forward-compatibility. Note: `Mime::ALL` isn't a real MIME type and isn't registered for lookup by type or extension, so it's not available as `Mime[:all]`. We use it internally as a wildcard for `respond_to` negotiation. If you use this internal constant, continue to reference it with `Mime::ALL`. Ref. efc6dd55
-
由 tanmay3011 提交于
-
由 Abhishek Jain 提交于
-
- 06 10月, 2015 1 次提交
-
-
由 Aaron Patterson 提交于
Just a slight refactor that delegates file sending to the response object. This gives us the advantage that if a webserver (in the future) provides a response object that knows how to do accelerated file serving, it can implement this method.
-
- 04 10月, 2015 1 次提交
-
-
由 Jeremy Daer 提交于
* Introduce `ActionDispatch::Http::Headers#add` to add a value to a multivalued header. * Move `Response#add_header` upstream: https://github.com/rack/rack/pull/957 * Match upstream `Response#have_header?` -> `#has_header?` name change.
-
- 03 10月, 2015 1 次提交
-
-
由 yui-knk 提交于
By [this commit](https://github.com/rails/rails/commit/0b476de445faf330c58255e2ec3eea0f3a7c1bfc) `Journey::Route#verb` need not to return verb as regexp. The returned value is used by inspector, so change it to be a string. Add inspect_with_multiple_verbs test case to keep the behavior of inspector correctly.
-
- 02 10月, 2015 2 次提交
-
-
由 Jeremy Daer 提交于
-
由 Jeremy Daer 提交于
-
- 29 9月, 2015 3 次提交
-
-
由 Aaron Patterson 提交于
the caller of `handle_conditional_get!` checks the committed state of the response, so we don't need to in the subclass.
-
由 Rafael Mendonça França 提交于
This reverts commit 4147ab73.
-
由 Gaurav Sharma 提交于
-
- 28 9月, 2015 2 次提交
-
-
由 Ronak Jangir 提交于
-
由 yui-knk 提交于
* add `end` to end of class definition * add a blank line between explanation and example code
-
- 26 9月, 2015 5 次提交
-
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
We only want to activate flash when the user has enabled it. Api servers don't use flash, so add an empty implementation to the base Request object.
-
由 Aaron Patterson 提交于
Committing the flash needs to happen in order for the session to be written correctly, so lets guarantee that it actually does happen.
-
由 Aaron Patterson 提交于
I'm doing this so that we can commit the flash to the session object Out of Band of the flash middleware
-
由 Gaurav Sharma 提交于
-
- 25 9月, 2015 4 次提交
-
-
由 amitkumarsuroliya 提交于
Accessing mime types via constants is deprecated. Now, we are using `Mime::Type[:JSON]` instead of `Mime::JSON`
-
由 Aaron Patterson 提交于
Use the Rack utility methods for functional header manipulation. This helps to eliminate coupling on the header hash
-
由 Aaron Patterson 提交于
I want to move the header hash to the super request object in order to consolidate behavior. We should be switching out buffering strategies rather than header strategies since things like "mutating headers after send" is an error in both cases (buffering vs streaming).
-
由 Aaron Patterson 提交于
We should not mutate headers after the response has been committed.
-
- 24 9月, 2015 4 次提交
-
-
由 Aaron Patterson 提交于
again, since we are going through the test harness, all this is done for us.
-
由 Aaron Patterson 提交于
Since we just go through the normal test harness that sets up a request for us, we don't need to do this anymore.
-
由 Aaron Patterson 提交于
I'm making this change so that I can construct response objects that *don't* have the default headers applied. For example, I would like to construct a response object from the return value of a controller. If you need to construct a response object with the default headers, then please use the alternate constructor: `ActionDispatch::Response.create`
-
由 Eliot Sykes 提交于
-
- 23 9月, 2015 3 次提交
-
-
由 amitkumarsuroliya 提交于
As we all know that Accessing mime types via constants is deprecated. Now, we are using `Mime::Type[:JSON]` instead of `Mime::JSON`
-
由 Aaron Patterson 提交于
The flash middleware shouldn't know how to look up the session object. Just ask the request for that information.
-
由 Aaron Patterson 提交于
We can know whether or not there is a content type object, and just exit early. There is no need to `try` so hard.
-