- 18 8月, 2016 3 次提交
-
-
由 Ryuta Kamizono 提交于
Currently `CollectionProxy` inherits `Relation` therefore we can use its own methods rather than delegating to collection association.
-
由 Rafael Mendonça França 提交于
Those methods are only using inside this module and by a private method so they all should be private.
-
由 Rafael Mendonça França 提交于
Since e852daa6 only the verb methods where extracting the defaults options. It was merged a fix for the `root` method in 31fbbb7f but `match` was still broken since `:defaults` where not extracted. This was causing routes defined using `match` and having the `:defaults` keys to not be recognized. To fix this it was extracted a new private method with the actual content of `match` and the `:defaults` extracting was moved to `match`.
-
- 17 8月, 2016 25 次提交
-
-
由 Jon Moss 提交于
Fix #26187
-
由 Jonathan 提交于
As "discussed" in #26187 I added the route that magically disappeared again.
-
由 प्रथमेश Sonpatki 提交于
Fix diffrent naming in getting_started.md
-
由 Jonathan 提交于
I've noticed that once `<h1>Editing article</h1>` L1157 was the title and then later on it's `<h1>Edit article</h1>` L1358 which kind of makes more sense... [ci skip]
-
由 Rafael França 提交于
Fix error message for out of range byte size integer value for consistency
-
由 Rafael Mendonça França 提交于
Remove parameter "options = nil" for #clear
-
由 Guillermo Iguaran 提交于
Fix link in Rails 5.0 Release Note
-
由 Yohei YASUKAWA 提交于
-
由 Rafael França 提交于
`pluck` should use `records` (`load_target`) when `loaded?` is true
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
Fix does_not_support_reverse? to find sql functions with commas in nested brackets
-
由 Rafael França 提交于
refactor `CommandsTasks`
-
由 Rafael França 提交于
`sql_for_insert` should be called inside `exec_insert`
-
由 Rafael França 提交于
Fix inconsistent the signature of finder methods for collection association
-
由 प्रथमेश Sonpatki 提交于
Start documenting ActionController::TestCase again
-
由 Prathamesh Sonpatki 提交于
- Rails 5 changed interface for passing arguments to request methods to keyword args for AC::TestCase but also hid the documentation. - But existing AC::TestCase tests need the new documentation about keyword args. So resurrected documentation and added a note about not using this for new tests. - The guides and other documentation is already updated to use `ActionDispatch::IntegrationTest`. [Matthew Draper, Prathamesh Sonpatki]
-
由 Rafael França 提交于
Finder bang method should call non bang method
-
由 Rafael França 提交于
Check if the logger is not nil before using it
-
由 Rafael Mendonça França 提交于
Extract `PredicateBuilder::CaseSensitiveHandler`
-
由 yuuji.yaginuma 提交于
Extract a common method of `Rails::CommandsTasks` and `Rails::Engine::CommandsTasks` to the module.
-
由 Rafael Mendonça França 提交于
Fix count which would sometimes force a DISTINCT
-
由 Rafael França 提交于
Do not handle as an associated predicate if a table has the column
-
由 Rafael França 提交于
Remove internal `sanitize` method
-
由 David Heinemeier Hansson 提交于
Yield the job instance so you have access to things like `job.arguments` on the custom logic after retries fail
-
由 Rafael França 提交于
Remove duplicate test.
-
- 16 8月, 2016 12 次提交
-
-
由 Rafael França 提交于
Makes touch_later respects no_touching policy
-
由 Ryuta Kamizono 提交于
Otherwise CollectionProxy's bang methdos cannot respect dirty target.
-
由 Ryuta Kamizono 提交于
`#second`, `#third`, etc finder methods was added in 03855e79. But the signature of these methods is inconsistent with the original finder methods. And also the signature of `#first` and `#last` methods is different from the original. This commit fixes the inconsistency.
-
由 Maxime Lapointe 提交于
The current behaviour of checking if there is a LEFT OUTER JOIN arel node to detect if we are doing eager_loading is wrong. This problem wasn't frequent before as only some pretty specific cases would add a LEFT OUTER JOIN arel node. However, the recent new feature left_outer_joins also add this node and made this problem happen frequently. Since in the perform_calculation function, we don't have access to eager_loading information, I had to extract the logic for the distinct out to the calculate method. As I was in the file for left_outer_join tests, I fixed a few that had bugs and I replaced some that were really weak with something that will catch more issues. In relation tests, the first test I changed would have failed if it had validated the hash returned by count instead of just checking how many pairs were in it. This is because this merge of join currently transforms the join node into an outer join node, which then made count do a distinct. So before this change, the return was {1=>1, 4=>1, 5=>1}.
-
由 Jean Boussier 提交于
-
由 Rafael França 提交于
List names of error interpolation variables.
-
由 Ryuta Kamizono 提交于
Currently uniqueness validator is coupled with building Arel ASTs. This commit extracts `PredicateBuilder::CaseSensitiveHandler` for decouple the building Arel ASTs.
-
由 Rafael França 提交于
Clarify migration to ApplicationRecord in upgrade guides [ci skip]
-
由 Ryuta Kamizono 提交于
If handled as an associated predicate even though a table has the column, will generate invalid SQL by valid column name treated as a table name.
-
由 Rafael França 提交于
Add array column documentation
-
由 Rafael França 提交于
Show unpermitted parameters as symbols in logs (so they could be copy…
-
由 oss92 提交于
-