- 18 7月, 2017 26 次提交
-
-
由 Rafael França 提交于
Fix typo s/rause/raise/
-
由 Ryuta Kamizono 提交于
-
由 Sean Griffin 提交于
-
由 Sean Griffin 提交于
-
由 Sean Griffin 提交于
This method needs to be protected.
-
由 Rafael França 提交于
Fix `JoinDependency` with using a custom table
-
由 Sean Griffin 提交于
[ci skip] CodeTriage badge
-
由 schneems 提交于
[Code Triage](https://www.codetriage.com/) is an app I've maintained for the past 4-5 years with the intent of getting people involved in open source. It sends subscribers a random open issue for them to help "triage". For Ruby projects such as "rails/rails" you can also subscribe to documentation. For example you can get a few random documented methods, or if you want to write docs, get undocumented methods. The initial approach was inspired by seeing the work of the small core team spending countless hours asking "what rails version was this in" and "can you give us an example app". The idea is to outsource these small interactions to a huge team of volunteers and let the core team focus on their work. The purpose of the badge is to give more people an easier way to start contributing to Rails. Here's what it currently looks like: [![Code Triage Badge](https://www.codetriage.com/rails/rails/badges/users.svg)](https://www.codetriage.com/rails/rails) The number is how many people are currently subscribed (a.k.a. "helpers") to the project on CodeTriage, the color is based off of the number of open issues in the project. You can see an example of this badge on another popular open source repo [Crystal](github.com/crystal-lang/crystal/). > For context to non-rails core: I also maintain sprockets (though a release hasn't happened in some time, sorry), and I have commit to Rails. I'm not some rando trying to push arbitrary links to READMEs on GitHub.
-
由 Sean Griffin 提交于
support `-` as an argument to `rails runner`
-
由 Cody Cutrer 提交于
in Rails 4.0, you could use `/dev/stdin` on both Linux and Mac, but with the switch to Kernel.load in Rails 4.1, this broke on Linux (you get a LoadError). Instead, explicitly detect `-` as meaning stdin, then read from stdin explicitly, instead of performing file gymnastics. This should now work on any platform uniformly. Passing a script via stdin is useful when you're sshing to a server, and the script you want to run is stored locally. You could theoretically pass the entire script on the command line, but in reality you'll run into problems with the command being too long.
-
由 Kasper Timm Hansen 提交于
Clarifies the intent that aren't just loading the model but really caring about triggering the on_load callbacks.
-
由 Ryuta Kamizono 提交于
Without this fix, `JoinDependency` doesn't use a custom table alias: ``` % ARCONN=sqlite3 be ruby -w -Itest test/cases/relations_test.rb -n test_using_a_custom_table_with_joins_affects_the_wheres Using sqlite3 Run options: -n test_using_a_custom_table_with_joins_affects_the_wheres --seed 14531 E Error:RelationTest#test_using_a_custom_table_with_joins_affects_the_wheres: ActiveRecord::StatementInvalid: SQLite3::SQLException: no such column: posts.author_id: SELECT "omg_posts".* FROM "posts" "omg_posts" INNER JOIN "authors" ON "authors"."id" = "posts"."author_id" WHERE "omg_posts"."title" = ? LIMIT ? ```
-
由 Sean Griffin 提交于
Extract `NullRelationTest` from `RelationTest`
-
由 Sean Griffin 提交于
Remove outdated `test_scoped_responds_to_delegated_methods`
-
由 Sean Griffin 提交于
Correctly handle frozen options for ActiveRecord::Serialization#seria…
-
由 Sean Griffin 提交于
Fix HashWithIndifferentAccess#default when include?(nil)
-
由 Sean Griffin 提交于
Fix `where` with a custom table
-
由 Sean Griffin 提交于
`Persistence#delete` should not be affected by scoping
-
由 Lisa Ugray 提交于
The implementation of HashWithIndifferentAccess#default didn't distinguish `default` from `default(nil)`, which caused an incorrect result for `default` if `nil` was used as a key. Define HashWithIndifferentAccess#dig so that hackery that behaves differently from Hash#default can be removed from HashWithIndifferentAccess#default.
-
由 Ryuta Kamizono 提交于
Without this fix, SELECT clause doesn't use a custom table alias name: ``` % ARCONN=sqlite3 be ruby -w -Itest test/cases/relations_test.rb -n test_using_a_custom_table_affects_the_wheres Using sqlite3 Run options: -n test_using_a_custom_table_affects_the_wheres --seed 31818 E Error: RelationTest#test_using_a_custom_table_affects_the_wheres: ActiveRecord::StatementInvalid: SQLite3::SQLException: no such table: posts: SELECT "posts".* FROM "posts" "omg_posts" WHERE "omg_posts"."title" = ? LIMIT ? ```
-
由 Ryuta Kamizono 提交于
`self.class.delete` is delegated to `all` and `all` is affected by scoping. It should use `unscoped` to not be affected by that.
-
由 Rafael França 提交于
Add bootsnap to default Gemfile
-
由 Rafael França 提交于
Remove unused `Mutex_m` in Active Model
-
由 Rafael França 提交于
Scrub the invalid paramter value before using it in the error
-
由 Burke Libbey 提交于
Bootsnap precomputes load path resolution and caches ruby ISeq and YAML parsing/compilation, reducing application boot time by approximately 50% on supported configurations.
-
由 Arthur Neves 提交于
You should be able to safely use the String error message. So when finding the paramter has an invalid encoding we need to remove the invalid bytes before using it in the error. Otherwise the caller might get another Encoding error if they use the message.
-
- 17 7月, 2017 14 次提交
-
-
由 Sean Griffin 提交于
Fixing "Adding Member Routes" documentation
-
由 Sean Griffin 提交于
Between 4.2 and 5.0 the behavior of how multiparameter attributes interact with `_before_type_cast` changed. In 4.2 it returns the post-type-cast value. After 5.0, it returns the hash that gets sent to the type. This behavior is correct, but will cause an issue if you then tried to render that value in an input like `text_field` or `hidden_field`. In this case, we want those fields to use the post-type-cast form, instead of the `_before_type_cast` (the main reason it uses `_before_type_cast` at all is to avoid losing data when casting a non-numeric string to integer). I've opted to modify `came_from_user?` rather than introduce a new method for this as I want to avoid complicating that contract further, and technically the multiparameter hash didn't come from assignment, it was constructed internally by AR. Close #27888.
-
由 Sean Griffin 提交于
Add documentation for class_attribute default option
-
由 Sean Griffin 提交于
Remove useless `arel_engine`
-
由 Glauco Custódio 提交于
-
由 Sean Griffin 提交于
This change was introduced by #18109. The intent of that change was to specifically apply `unscoped`, not to allow all changes to `current_scope` to affect the join. The idea of allowing `current_scope` to affect joins is interesting and potentially more consistent, but has sever problems associated with it. The fact that we're specifically stripping out joins indicates one such problem (and potentially leads to invalid queries). Ultimately it's difficult to reason about what `Posts.joins(:users)` actually means if it's affected by `User.current_scope`, and it's difficult to specifically control what does or doesn't get added. If we were starting from scratch, I don't think I'd have `joins` be affected by `default_scope` either, but that's too big of a breaking change to make at this point. With this change, we no longer apply `current_scope` when bringing in joins, with the singular exception of the motivating use case which introduced this bug, which is providing a way to *opt-out* of having the default scope apply to joins. Fixes #29338.
-
由 Sean Griffin 提交于
Make the order of Hash#reverse_merge! consistent with HashWithIndifferentAccess
-
由 Sean Griffin 提交于
-
由 Ryuta Kamizono 提交于
`arel_engine` is only used in `raise_record_not_found_exception!` to use `engine.connection` (and `connection.visitor`) in `arel.where_sql`. https://github.com/rails/arel/blob/v8.0.0/lib/arel/select_manager.rb#L183 But `klass.connection` will work as expected even if not using `arel_engine` (described by `test_connection`). So `arel_engine` is no longer needed.
-
由 Matthew Draper 提交于
Enable `Layout/FirstParameterIndentation` cop
-
由 Kasper Timm Hansen 提交于
Set `RAILS_ENV` before load application file
-
由 Ryuta Kamizono 提交于
We have some indentation cops. But now there is a little inconsistent params indentations. Enable `Layout/FirstParameterIndentation` cop to prevent newly inconsistent indentation added and auto-correct to existing violations.
-
由 yuuji.yaginuma 提交于
Since #29725, load application file when `dbconsole` command is executed. However, if do not set `RAILS_ENV` before reading the application file, can not connect to the env specified in option, so added the setting of `RAILS_ENV`.
-
由 Matthew Draper 提交于
Use frozen string literal in activemodel/
-