- 05 4月, 2014 7 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
Renamed private methods _create_record and _update_record
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
CollectionProxy uses the arel of its association's scope. Conflicts: activerecord/CHANGELOG.md
-
- 04 4月, 2014 16 次提交
-
-
由 Arthur Nogueira Neves 提交于
add missing parentheses to validates_with documentation [skip ci]
-
由 Steve Agalloco 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
Active support instead of ActiveSupport::Deprecation.silence we can use assert_deprecated
-
由 Rajarshi Das 提交于
-
由 Rafael Mendonça França 提交于
Ensure we supply Kernel#y for 1.9 too
-
由 Matthew Draper 提交于
In 1.9, it doesn't live in its own file, so we'll have to define it ourselves. Check RUBY_VERSION, instead of rescuing the require, because we want this to break if `psych/y` moves in a future Ruby release.
-
由 Yves Senn 提交于
Prevent state leak in test.
-
由 Guo Xiang Tan 提交于
This will allow us to run the tests in random order.
-
由 Rafael Mendonça França 提交于
Blacklist ruby keywords for scopes
-
由 Arthur Neves 提交于
Add tests to make sure scopes cannot be create with names such as: private, protected, public. Make sure enum values don't collide with those methods too.
-
由 Rafael Mendonça França 提交于
Fix error when using `with_options` with lambda. Conflicts: activerecord/CHANGELOG.md
-
由 Arthur Nogueira Neves 提交于
Improve error message for guides:generate:kindle
-
由 Łukasz Adamczak 提交于
With `kindlegen` missing from the PATH, the task keeps suggesting to `gem install kindlerb`. This change provides a more meaningful error message for guides:generate:kindle.
-
由 Rafael Mendonça França 提交于
Explicitly load Kernel#y when starting a console
-
由 Matthew Draper 提交于
Previously, we relied on the IRB-detection in Psych itself. But that doesn't work when we're running under spring: the application boots (and thus psych is required) before we switch to console mode and load IRB. Fixes #14587.
-
- 03 4月, 2014 16 次提交
-
-
由 Rafael Mendonça França 提交于
Revise 'sqlite3:' URL handling for smoother upgrades Conflicts: activerecord/CHANGELOG.md
-
由 Lauro Caetano 提交于
It was causing error when using `with_options` passing a lambda as its last argument. class User < ActiveRecord::Base with_options dependent: :destroy do |assoc| assoc.has_many :profiles, -> { where(active: true) } end end It was happening because the `option_merger` was taking the last argument and checking if it was a Hash. This breaks the HasMany usage, because its last argument can be a Hash or a Proc. As the behavior described in this test: https://github.com/rails/rails/blob/master/activesupport/test/option_merger_test.rb#L69 the method will only accept the lambda, this way it will keep the expected behavior. See 9eaa0a34
-
由 Rafael Mendonça França 提交于
Avoid a spurious deprecation warning for database URLs
-
由 Yves Senn 提交于
Add ConnectionHelper to refactor tests.
-
由 Yves Senn 提交于
-
由 Dmitry Lavrov 提交于
-
由 Yves Senn 提交于
Change order of scope subsections in Active Record Querying guide [ci skip]
-
由 Guo Xiang Tan 提交于
-
由 ariabov 提交于
In Active Record Querying guide, currently `Merging of scopes` section uses a concept of default scope in its example before it is introduced in the following section titled `Applying a default scope`. It makes more sense to switch the ordering to introduce default scopes (`Applying a default scope`) first and then go into `Merging of scopes` section where it is used.
-
由 Rafael Mendonça França 提交于
Fix default_url_options example in i18n guide
-
由 Nikolay Shebanov 提交于
-
由 Jefferson Lai 提交于
CollectionProxy should be able to reuse the behavior (methods) of its parent class, but with its own state. This change allows CollectionProxy to use the arel object corresponding to its association's scope.
-
由 Matthew Draper 提交于
The keys are quite sufficient; we shouldn't be throwing passwords around.
-
由 Matthew Draper 提交于
This is all about the case where we have a `DATABASE_URL`, and we have a `database.yml` present, but the latter doesn't contain the key we're looking for. If the key is a symbol, we'll always connect to `DATABASE_URL`, per the new behaviour in 283a2ede. If the key is a string, on the other hand, it should always be a URL: the ability to specify a name not present in `database.yml` is new in this version of Rails, and that ability does not stretch to the deprecated use of a string in place of a symbol. Uncovered by @guilleiguaran while investigating #14495 -- this actually may be related to the original report, but we don't have enough info to confirm.
-
由 Carlos Antonio da Silva 提交于
The option actually needs to be set on action_dispatch. [ci skip]
-
由 Carlos Antonio da Silva 提交于
Change to require all active_support/deprecation since that's the actual entry point for the deprecation methods.
-
- 02 4月, 2014 1 次提交
-
-