- 22 12月, 2009 1 次提交
-
-
由 David Heinemeier Hansson 提交于
-
- 02 12月, 2009 1 次提交
-
-
由 Joshua Peek 提交于
-
- 06 11月, 2009 1 次提交
-
-
由 Nathan Weizenbaum 提交于
When rendering layouts with blocks, use #capture to avoid assuming that the return value is the block's content. Signed-off-by: NYehuda Katz <wycats@Yehuda-Katz.local>
-
- 01 11月, 2009 1 次提交
-
-
由 José Valim 提交于
-
- 29 10月, 2009 1 次提交
-
-
由 Yehuda Katz 提交于
-
- 10 10月, 2009 1 次提交
-
-
由 Yehuda Katz 提交于
-
- 09 10月, 2009 1 次提交
-
-
由 Yehuda Katz 提交于
-
- 08 10月, 2009 1 次提交
-
-
由 Michael Koziarski 提交于
This consists of: * String#html_safe! a method to mark a string as 'safe' * ActionView::SafeBuffer a string subclass which escapes anything unsafe which is concatenated to it * Calls to String#html_safe! throughout the rails helpers * a 'raw' helper which lets you concatenate trusted HTML from non-safety-aware sources (e.g. presantized strings in the DB) * New ERB implementation based on erubis which uses a SafeBuffer instead of a String Hat tip to Django for the inspiration.
-
- 29 9月, 2009 1 次提交
-
-
由 Erik Ostrom 提交于
state:resolved] The test case now mimicks the template environment more closely, so it's possible to use render, load helper dependencies. This also fixes assert_select, and similar assertions. Because view tests and helpers generally don't render full templates assert_select looks first in rendered and then in output_buffer to find the rendered output. Additional `master'-only changes: Made the Action Pack Rakefile run the ActionView::TestCase tests, and made ActionView::Rendering#_render_text always return a string. Signed-off-by: NJoshua Peek <josh@joshpeek.com>
-
- 25 9月, 2009 1 次提交
-
-
由 Joshua Peek 提交于
-
- 16 8月, 2009 4 次提交
-
-
由 Yehuda Katz 提交于
-
由 Yehuda Katz 提交于
Caches and cache clearing seems to actually work, but the actual architecture is kind of messy. Next: CLEAN UP.
-
由 Yehuda Katz 提交于
* only one of partial_name or :as will be available as a local * `object` is removed * Simplify _layout_for in most cases. * Remove <% render :partial do |args| %> * <% render :partial do %> still works fine
-
由 Yehuda Katz 提交于
* Call _evaluate_assigns_and_ivars at the two entry points so we don't have to do a check at every render. * Make template.render viable without having to go through a wrapper method * Remove old TemplateHandler#render(template, local_assigns) path so we don't have to set self.template every time we render a template. * Move Template rescuing code to Template#render so it gets caught every time. * Pull in some tests from Pratik that test render @object in ActionView
-
- 12 8月, 2009 2 次提交
-
-
由 Yehuda Katz 提交于
-
由 Yehuda Katz 提交于
Further experimentation. Was able to cut the cost of rendering 100 partials in a collection in half. To discuss: What are the desired semantics (if any) for layouts in a collection. There are no tests for it at present, and I'm not sure if it's needed at all. Deprecated on this branch: `object` pointing at the current object in partials. You can still use the partial name, or use :as to achieve the same thing. This is obviously up for discussion.
-
- 09 8月, 2009 5 次提交
-
-
由 Yehuda Katz 提交于
-
由 Yehuda Katz 提交于
-
由 Yehuda Katz 提交于
-
由 Yehuda Katz 提交于
-
由 Jeremy Kemper 提交于
-
- 08 8月, 2009 2 次提交
-
-
由 Yehuda Katz 提交于
-
由 Yehuda Katz 提交于
-
- 07 8月, 2009 12 次提交
-
-
由 Yehuda Katz 提交于
* It is not possible to always pre-determine the layout before going to ActionView. This was *already* broken for render :partial => @object, :layout => true. This is now handled by overriding render_to_body in layouts.rb and manually injecting the partial's response. This needs to be done in ActionController since ActionController knows enough to get _layout_for_option. There is probably a better abstraction here. * As a result, all partial rendering can correctly restrict their layouts to the mime type of the rendered partial. This could have previously caused a bug in some edge cases. * If other layout-like options are added, they might need to add special code for the case of render :partial. We should try to think of an alternate solution, if possible, but this works for the cases we know of now.
-
由 Yehuda Katz 提交于
-
由 Yehuda Katz 提交于
* TODO: Review ActionController calling render_template for certain partials. Might we be able to save logic by always delegating to AV's render_partial?
-
由 Yehuda Katz 提交于
* _render_single_template, which renders a template without layout * _render_partial_unknown_type, which renders a partial of unknown type (the entry method for most partial rendering; supports strings, objects, and collections) * _render_partial_object, which renders a partial for a single object. * extracted _render_partial_path so it can be used to render the spacer without going through the public render :partial
-
由 Yehuda Katz 提交于
* rename _render_partial to _render_partial_unknown_type to reflect that for this call, we don't know the type. * Merge _render_partial_with_block and _render_partial_with_layout to _render_partial * TODO: Check to see if any more logic can be shared * TODO: See about streamlining block path so we can get rid of @_proc_for_layout * Remove @exempt_from_layout as it is no longer needed
-
由 Yehuda Katz 提交于
-
由 Yehuda Katz 提交于
* remove no longer used _array_like_objects * _render_content_with_layout renamed to _render_content since layout it optional * remove check for optional layout before _render_content
-
由 Yehuda Katz 提交于
-
由 Yehuda Katz 提交于
-
由 Yehuda Katz 提交于
-
由 Yehuda Katz 提交于
-
由 Yehuda Katz 提交于
-
- 19 7月, 2009 1 次提交
-
-
由 Yehuda Katz 提交于
-
- 26 6月, 2009 1 次提交
-
-
由 Joshua Peek 提交于
-
- 19 6月, 2009 2 次提交
-
-
- 18 6月, 2009 1 次提交
-
-
Extract the layout proc into a method, and write documentation explaining what the proc does in various cases.
-