1. 04 8月, 2020 1 次提交
  2. 03 8月, 2020 5 次提交
  3. 02 8月, 2020 1 次提交
  4. 01 8月, 2020 8 次提交
  5. 31 7月, 2020 9 次提交
  6. 30 7月, 2020 11 次提交
    • E
      Add docs for abstract class generators · aeab40b4
      eileencodes 提交于
      Adds documentation for https://github.com/rails/rails/pull/39866
      aeab40b4
    • E
      Merge pull request #39952 from tgxworld/fix_incorrect_test · 98135434
      Eugene Kenny 提交于
      Fix wrong attributes being set in transactions savepoint test.
      98135434
    • G
      96a1c88e
    • R
      Merge pull request #39951 from abhaynikam/fix--typo-in-railties-changelog · 52086f11
      Ryuta Kamizono 提交于
      Fixed typo AnimalsRecrd -> AnimalsRecord [ci skip]
      52086f11
    • A
      Fixed typo AnimalsRecrd -> AnimalsRecord [ci skip] · db5c6195
      Abhay Nikam 提交于
      db5c6195
    • V
      Reduce allocations in transition_table (#39943) · 6e636e23
      Vinicius Stock 提交于
      * Reduce allocations in transition_table
      
      * Use predicate symbol? instead of is_a?
      6e636e23
    • R
      Merge pull request #39949 from yahonda/diag_build_70853 · 132ee010
      Ryuta Kamizono 提交于
      Clear Resolvers' cache after AVLogSubscriberTest tests
      132ee010
    • Y
      Clear Resolvers' cache after AVLogSubscriberTest tests · 1e84ac42
      Yasuo Honda 提交于
      Addresses the build failure below:
      https://buildkite.com/rails/rails/builds/70853#29647167-4db2-4810-810e-d2c3a4e6dcf8
      
      * This pull request addresses this error.
      
      ```
      $ bin/test test/template/log_subscriber_test.rb test/template/test_case_test.rb -n "/^(?:AVLogSubscriberTest#(?:test_render_collection_template)|ActionView::HelperInclusionTest#(?:test_helper_class_that_is_being_tested_is_always_included_in_view_instance))$/" --seed 54118
      Run options: -n "/^(?:AVLogSubscriberTest#(?:test_render_collection_template)|ActionView::HelperInclusionTest#(?:test_helper_class_that_is_being_tested_is_always_included_in_view_instance))$/" --seed 54118
      
      .E
      
      Error:
      ActionView::HelperInclusionTest#test_helper_class_that_is_being_tested_is_always_included_in_view_instance:
      ActionView::Template::Error: undefined method `_test__customer_erb___3224798146126036163_10260' for #<#<Class:0x00005653f1b35768>:0x00005653f1b348e0>
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/base.rb:276:in `_run'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/template.rb:182:in `block in render'
          /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications.rb:205:in `instrument'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/template.rb:384:in `instrument_render_template'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/template.rb:180:in `render'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/collection_renderer.rb:186:in `block in collection_with_template'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/collection_renderer.rb:66:in `block in each_with_info'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/collection_renderer.rb:66:in `each'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/collection_renderer.rb:66:in `each_with_info'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/collection_renderer.rb:177:in `each'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/collection_renderer.rb:177:in `map'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/collection_renderer.rb:177:in `collection_with_template'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/collection_renderer.rb:159:in `block (2 levels) in render_collection'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/partial_renderer/collection_caching.rb:21:in `cache_collection_render'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/collection_renderer.rb:158:in `block in render_collection'
          /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications.rb:203:in `block in instrument'
          /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications/instrumenter.rb:24:in `instrument'
          /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications.rb:203:in `instrument'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/collection_renderer.rb:144:in `render_collection'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/collection_renderer.rb:116:in `render_collection_with_partial'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/renderer.rb:75:in `render_partial_to_object'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/renderer.rb:27:in `render_to_object'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/renderer.rb:22:in `render'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/helpers/rendering_helper.rb:38:in `block in render'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/base.rb:306:in `in_rendering_context'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/helpers/rendering_helper.rb:34:in `render'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/test_case.rb:205:in `render'
          /home/yahonda/src/github.com/rails/rails/actionview/test/template/test_case_test.rb:126:in `render_from_helper'
          /home/yahonda/src/github.com/rails/rails/actionview/test/fixtures/test/_from_helper.erb:1:in `__home_yahonda_src_github_com_rails_rails_actionview_test_fixtures_test__from_helper_erb___900298654238864924_10340'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/base.rb:276:in `_run'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/template.rb:182:in `block in render'
          /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications.rb:205:in `instrument'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/template.rb:384:in `instrument_render_template'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/template.rb:180:in `render'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/partial_renderer.rb:285:in `block in render_partial_template'
          /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications.rb:203:in `block in instrument'
          /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications/instrumenter.rb:24:in `instrument'
          /home/yahonda/src/github.com/rails/rails/activesupport/lib/active_support/notifications.rb:203:in `instrument'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/partial_renderer.rb:280:in `render_partial_template'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/partial_renderer.rb:271:in `render'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/renderer.rb:84:in `render_partial_to_object'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/renderer.rb:27:in `render_to_object'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/renderer/renderer.rb:22:in `render'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/helpers/rendering_helper.rb:38:in `block in render'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/base.rb:306:in `in_rendering_context'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/helpers/rendering_helper.rb:34:in `render'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/test_case.rb:205:in `render'
          /home/yahonda/src/github.com/rails/rails/actionview/lib/action_view/test_case.rb:122:in `render'
          /home/yahonda/src/github.com/rails/rails/actionview/test/template/test_case_test.rb:136:in `block in <class:HelperInclusionTest>'
      
      bin/test test/template/test_case_test.rb:132
      
      Finished in 0.076637s, 26.0970 runs/s, 39.1454 assertions/s.
      2 runs, 3 assertions, 0 failures, 1 errors, 0 skips
      $
      ```
      
      Refer #36189 for the similar fix
      1e84ac42
    • E
      Merge pull request #39771 from eugeneius/autosave_exactly_once · fa82ea40
      Eugene Kenny 提交于
      Autosave collection associations exactly once
      fa82ea40
    • E
      Merge pull request #39866 from seejohnrun/generate-abstract-class · e396bcaa
      Eileen M. Uchitelle 提交于
      Generate abstract class when generating scaffold in another database
      e396bcaa
    • E
      Generate abstract class when generating scaffold in another database · 261cbcd2
      eileencodes 提交于
      This PR ensures that when you're generating a scaffold or model and that
      model should belong to another database it will create an abstract class
      if it doesn't already exist.
      
      The new abstract class will ensure that the new model inherits from that
      class, but will not be deleted if the scaffold is deleted. This is
      because Rails can't know if you have other models inheriting from that
      class so we don't want to revoke that if the scaffold is destroyed.
      
      If the abstract class already exists it won't be created twice. If the
      options for `parent` are set, the generator will use that as the
      abstract class instead of creating one. The generated abstract class
      will add the writing connection automatically, users need to add the
      reading connection themselves as Rails doesn't know which is the reading
      connection.
      Co-authored-by: NJohn Crepezzi <john.crepezzi@gmail.com>
      261cbcd2
  7. 29 7月, 2020 4 次提交
  8. 28 7月, 2020 1 次提交