1. 01 8月, 2017 2 次提交
  2. 25 7月, 2017 1 次提交
    • L
      Stop creating ApplicationRecord on model generation · 75ccdfed
      Lisa Ugray 提交于
      When generating models, we created ApplicationRecord in the default
      location if no file existed there.  That was annoying for people who
      moved it to somewhere else in the autoload path.  At this point, the
      vast majority of apps should have either run the upgrade script or
      generated a model since upgrading.  For those that haven't the error
      message after generating a new model should be helpful:
      
         NameError: uninitialized constant ApplicationRecord
      
      To ease friction in that case, this also adds a generator for
      ApplicationRecord.
      75ccdfed
  3. 16 7月, 2017 1 次提交
    • Y
      Do not generate unused components contents in `app:update` task · 58036402
      yuuji.yaginuma 提交于
      Currently, `app:update` generates all contents regardless of the
      component using in application.
      
      For example, even if not using Action Cable, `app:update` will generate
      a contents related to Action Cable. This is a little inconvenient.
      This PR checks the existence of the component and does not generate
      unnecessary contents.
      Can not check all options in this way. However, it will be able to
      prevent the generation of unnecessary files.
      58036402
  4. 06 7月, 2017 1 次提交
  5. 02 7月, 2017 1 次提交
  6. 01 7月, 2017 1 次提交
  7. 30 6月, 2017 1 次提交
  8. 26 6月, 2017 1 次提交
  9. 18 6月, 2017 1 次提交
  10. 14 6月, 2017 1 次提交
  11. 30 5月, 2017 1 次提交
  12. 28 5月, 2017 1 次提交
  13. 26 5月, 2017 1 次提交
  14. 23 5月, 2017 1 次提交
  15. 19 5月, 2017 1 次提交
  16. 07 5月, 2017 1 次提交
  17. 16 4月, 2017 1 次提交
  18. 12 4月, 2017 1 次提交
  19. 27 3月, 2017 1 次提交
  20. 26 3月, 2017 1 次提交
  21. 24 3月, 2017 1 次提交
  22. 23 3月, 2017 1 次提交
    • C
      Remove -j (--javascript) option from `rails new` · 42198064
      claudiob 提交于
      The "-j" option was added 5 years ago (https://github.com/rails/rails/commit/d9c39c3a)
      when we wanted to support prototype-rails and jquery-rails.
      Prototype is not as popular and jQuery is not a requirement anymore.
      Still the "-j" option can be used to install *any* gem that ends in "-rails".
      
      This "might" open security issues and does not bring great benefits anymore.
      
      If you know which "-rails"-ending gem you want to install, you can manually
      add it to the Gemfile just like any other gem.
      42198064
  23. 22 3月, 2017 1 次提交
  24. 21 3月, 2017 1 次提交
  25. 20 3月, 2017 2 次提交
    • Y
      Add `app:update` task to engines · a42351ac
      yuuji.yaginuma 提交于
      Occasionally we update the file generated by engine.
      Therefore, I think that there is a task for updating as well as
      application in the engine, it is convenient for updating.
      a42351ac
    • Y
      Fix `warning: character class has duplicated range` · 6dfe25a8
      yuuji.yaginuma 提交于
      This fixes the following warnings:
      
      ```
      railties/test/generators/encrypted_secrets_generator_test.rb:15: warning: character class has duplicated range: /[\w\d]+/
      railties/test/generators/encrypted_secrets_generator_test.rb:18: warning: character class has duplicated range: /production:\n#  external_api_key: [\w\d]+/
      railties/test/generators/encrypted_secrets_generator_test.rb:19: warning: character class has duplicated range: /production:\n#  external_api_key: [\w\d]+/
      ```
      6dfe25a8
  26. 19 3月, 2017 1 次提交
    • Y
      Correctly check whether key is defined in configuration · 53e6fe96
      yuuji.yaginuma 提交于
      It can not check correctly with `defined?`
      
      ```ruby
      irb(main):001:0> Rails.application.config.active_record
      => {:maintain_test_schema=>true, :belongs_to_required_by_default=>true}
      irb(main):002:0> defined?(Rails.application.config.active_record)
      => nil
      ```
      
      Follow up to #28469
      53e6fe96
  27. 18 3月, 2017 1 次提交
    • M
      Track the version-compatible config settings inside railties · 4183ee88
      Matthew Draper 提交于
      Instead of forcing new applications to carry an initializer that just
      switches things to what their default "should" be, we can handle it
      internally.
      
      The initializer is then only used by upgraders: it shows what the new
      default would be (commented out), while their upgraded application
      continues to operate as it did before.
      
      Under this model, a multiply-upgraded application could accumulate
      several new_framework_defaults_*.rb files, for each release series it
      has traversed. A given release series only needs to generate the latest,
      though, because we don't support `rails app:upgrade` while skipping
      releases.
      4183ee88
  28. 15 3月, 2017 1 次提交
  29. 14 3月, 2017 1 次提交
  30. 24 2月, 2017 2 次提交
  31. 23 2月, 2017 2 次提交
  32. 22 2月, 2017 1 次提交
  33. 21 2月, 2017 4 次提交
    • R
      Use Puma 3.7.x · bd163bda
      Roberto Miranda 提交于
      ref this commit seems that has not been merged into 3.7 https://github.com/puma/puma/commit/42bec4600c51ab8a1c1ee5a0e1b738a4ffd82bf2
      bd163bda
    • E
      Move and rename system tests · 1a0ca84a
      eileencodes 提交于
      * Move system tests back into Action Pack
      * Rename `ActionSystemTest` to `ActionDispatch::SystemTestCase`
      * Remove private base module and only make file for public
      `SystemTestCase` class, name private module `SystemTesting`
      * Rename `ActionSystemTestCase` to `ApplicationSystemTestCase`
      * Update corresponding documentation and guides
      * Delete old `ActionSystemTest` files
      1a0ca84a
    • E
      Turn system testing into it's own gem and rename · 5bf0aa67
      eileencodes 提交于
      Renames `Rails::SystemTestCase` to `ActionSystemTest` and moves it to a
      gem under the Rails name.
      
      We need to name the class `ActionSystemTestCase` because the gem expects
      a module but tests themselves expect a class.
      
      Adds MIT-LICENSE, CHANGELOG, and README for the future.
      5bf0aa67
    • E
      Add tests for system testing · 9730b1db
      eileencodes 提交于
      * Adds test case test
      * Adds driver adapter test
      * Adds tests for capybara seleium driver (testing the settings not
      actually opening the browser to test capybara w/ selenium because that
      would so so so slow)
      * Adds tests for rack test driver
      * Adds tests for generators
      9730b1db