1. 05 7月, 2015 1 次提交
  2. 17 6月, 2015 1 次提交
  3. 13 6月, 2015 1 次提交
  4. 31 5月, 2015 1 次提交
    • S
      Ensure symbols passed to `select` are always quoted · 0ef7e73f
      Sean Griffin 提交于
      Our general contract in Active Record is that strings are assumed to be
      SQL literals, and symbols are assumed to reference a column. If a from
      clause is given, we shouldn't include the table name, but we should
      still quote the value as if it were a column.
      
      Upon fixing this, the tests were still failing on SQLite. This was
      because the column name being returned by the query was `"\"join\""`
      instead of `"join"`. This is actually a bug in SQLite that was fixed a
      long time ago, but I was using the version of SQLite included by OS X
      which has this bug. Since I'm guessing this will be a common case for
      contributors, I also added an explicit check with a more helpful error
      message.
      
      Fixes #20360
      0ef7e73f
  5. 29 5月, 2015 1 次提交
  6. 28 4月, 2015 1 次提交
  7. 26 4月, 2015 1 次提交
  8. 24 4月, 2015 1 次提交
    • G
      Uncomment byebug in framework Gemfile · 78b51a80
      Godfrey Chan 提交于
      History:
      
      1. `debugger` was there until d2ed433b where it was commented out, and I
         couldn't figure out why
      
      2. Since then we inherited that when switching to `byebug` in 93559da4
      
      Reasons:
      
      1. It's nice to have a debugger when working on framework bugs
      
      2. It's an uncommented dependency in app Gemfiles since Rails 4.2 (see fbe38c9e)
      78b51a80
  9. 10 4月, 2015 1 次提交
  10. 09 4月, 2015 1 次提交
  11. 02 4月, 2015 1 次提交
  12. 30 3月, 2015 1 次提交
  13. 19 3月, 2015 1 次提交
  14. 18 3月, 2015 1 次提交
  15. 11 3月, 2015 2 次提交
  16. 06 3月, 2015 1 次提交
  17. 02 3月, 2015 2 次提交
    • R
      Test against the mail gem's edge · 5140c07c
      Robin Dupret 提交于
      The edge version ships with a patch that uses composition over
      inheritance for the Mail::PartsList object (see mikel/mail#782).
      Let's test Action Mailer against it to prevent eventual regressions
      and experience it.
      
      Moreover, this branch makes the Action Mailer suite green against
      Rubinius.
      5140c07c
    • E
      Bump rack-test to fix nil values being sent to `parse_nested_query` · e1e2b54e
      eileencodes 提交于
      I found that nil values were being incorrectly sent to
      `parse_nested_query` in Rack. Originally it was thought that Rails was
      doing something incorrect but it was actually rack-test. This was fixed
      in brynary/rack-test@4a4b2c1 and is no longer an issue. This commit
      bumps rack-test in Rails so changes to Rack don't cause failures.
      
      See rack/rack#813 for more information.
      e1e2b54e
  18. 20 2月, 2015 1 次提交
  19. 19 2月, 2015 1 次提交
    • R
      Track Gemfile.lock at the repository · b1edc378
      Rafael Mendonça França 提交于
      The main reason is to make bisect easier.
      
      In some points, we have a lot of git dependencies. Since we don't have
      the information of which commit we are referring to, bundler get the
      latest commit of the master branch of the dependency. This sometimes
      returns a version that is not compatible with Rails anymore, making the
      tests fail and the harder to identify the commit that introduced a bug.
      
      Also this will make sure that a contributor will always get a set of
      dependencies that are passing with our tests.
      
      In our CI server we delete the lock file to make sure we are always
      testing against the newest release of our dependencies.
      b1edc378
  20. 08 8月, 2014 1 次提交
  21. 12 6月, 2014 1 次提交
  22. 20 5月, 2014 5 次提交
  23. 19 5月, 2014 5 次提交
  24. 18 5月, 2014 2 次提交