- 11 9月, 2018 9 次提交
-
-
由 Darwin D Wu 提交于
In order to avoid double assignments of nested_attributes for `has_many` relations during record initialization, nested_attributes in `create_with` should not be passed into `klass.new` and have them populate during `initialize_internals_callback` with scope attributes. However, `create_with` keys should always have precedence over where clauses, so if there are same keys in both `create_with` and `where_values_hash`, the value in `create_with` should be the one that's used.
-
由 yuuji.yaginuma 提交于
Follow up of 3e814907.
-
由 Xavier Noria 提交于
Followup to a recently merged PR, too minor and detailed to require a modification to the contributed patch.
-
由 Rafael França 提交于
ActiveJob Backburner adapter: fix priority
-
由 Xavier Noria 提交于
Add #unfreeze_time to ActiveSupport::Testing::TimeHelpers
-
由 ryanwhocodes 提交于
-
由 Rafael Mendonça França 提交于
-
由 Ryuta Kamizono 提交于
docs: Fix typo in activerecord/CHANGELOG.md [ci skip]
-
由 Nick Stanish 提交于
-
- 10 9月, 2018 2 次提交
-
-
由 Eileen M. Uchitelle 提交于
retry_on argument `attempts` clarification
-
由 Eileen M. Uchitelle 提交于
Follow up #33637 and #33770
-
- 09 9月, 2018 7 次提交
-
-
由 Graham Turner 提交于
-
由 bogdanvlviv 提交于
-
由 bogdanvlviv 提交于
Since #33770 `#configs_for` changed method signature and it isn't supposed to work with a passed block.
-
由 bogdanvlviv 提交于
See `ConnectionUrlResolver#database_from_path` in `activerecord/lib/active_record/connection_adapters/connection_specification.rb`
-
由 yuuji.yaginuma 提交于
Without `perform_enqueued_jobs`, job are not executed and assertion is not done.
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
The writer was added during Arel refactoring to pass Active Record tests at 7a29220c. That is no longer used since 846832ae.
-
- 08 9月, 2018 9 次提交
-
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Rather than a configuration on the connection.
-
由 Xavier Noria 提交于
-
由 stoodfarback 提交于
The priority wasn't being passed from ActiveJob to Backburner, despite priority being supported. This also brings it inline with the docs, which mark Backburner as supporting priorities in the "Backend Features" table: https://api.rubyonrails.org/classes/ActiveJob/QueueAdapters.html
-
由 Richard Schneeman 提交于
Don’t allocate array on no args
-
由 schneems 提交于
When no dependencies are present to be digested there is no reason to build an array just to turn around and turn it back into a string. The dependencies array is not mutated in this method so we can use the same empty array across all invocations. Total allocated: 791402 bytes (7294 objects) Total allocated: 777442 bytes (7132 objects) (791402 - 777442) / 791402.0 # => 1.76 % speed improvement
-
由 Xavier Noria 提交于
Closes #32885.
-
由 Ryuta Kamizono 提交于
Fix non_numeric_string?
-
由 Rafael França 提交于
`ActiveModel.full_message` interaction with `index_errors`
-
- 07 9月, 2018 13 次提交
-
-
由 Eileen M. Uchitelle 提交于
Add `inspection_masks` to make values of sensitive database columns w…
-
由 Yoshiyuki Kinjo 提交于
For example, dirty checking was not right for the following case: ``` model.int_column = "+5" model.float_column = "0.5E+1" model.decimal_column = "0.5e-3" ``` It is enough to see whether leading character is a digit for avoiding invalid numeric expression like 'wibble' to be type-casted to 0, as this method's comment says. Fixes #33801
-
由 Zhang Kang 提交于
Configuration item `config.filter_parameters` could also filter out sensitive value of database column when call `#inspect` * Why Some sensitive data will be exposed in log accidentally by calling `#inspect`, e.g. ```ruby @account = Account.find params[:id] payload = { account: @account } logger.info "payload will be #{ payload }" ``` All the information of `@account` will be exposed in log. * Solution Add a class attribute filter_attributes to specify which values of columns shouldn't be exposed. This attribute equals to `Rails.application.config.filter_parameters` by default. ```ruby Rails.application.config.filter_parameters += [:credit_card_number] Account.last.insepct # => #<Account id: 123, credit_card_number: [FILTERED] ...> ```
-
由 Ryuta Kamizono 提交于
Fixing code block rendering, indentation, backticks, etc.
-
由 yuuji.yaginuma 提交于
`spec` is the same variable name as gemspec generated by bundler, and its intention is easier to understand than a one-letter variable. https://github.com/bundler/bundler/blob/00fd58eaa69015092ee272c4cb5aa92a5e7ee45c/lib/bundler/templates/newgem/newgem.gemspec.tt#L11 This is follow up on 1c59b484. `spec` is already in use there.
-
由 Aaron Patterson 提交于
Maintain html_safe? on sliced HTML safe strings
-
由 Richard Schneeman 提交于
Document ActionView::OutputBuffer
-
由 schneems 提交于
-
由 Yumin Wong 提交于
Co-authored-by: Nno-itsbackpack <no-itsbackpack@github.com>
-
由 Richard Schneeman 提交于
[ci skip] Improve remove_column documentation
-
由 Rafael França 提交于
Fix typo in i18n_railtie.rb [ci skip]
-
由 Olivier 提交于
-
由 Paulo Fidalgo 提交于
Since when we remove one column it will also remove the associated indexes, we must ensure this behaviour is properly documented. In this commit we add a line to the documentation mentioning this behaviour.
-