- 25 1月, 2018 12 次提交
-
-
由 kami-zh 提交于
- Fix typo - Adjust output example to other example's format
-
由 Ryuta Kamizono 提交于
It is useless since 90c8be76.
-
由 Ryuta Kamizono 提交于
This is a regression caused by 6beb4de7. In PostgreSQL, ORDER BY expressions must appear in SELECT list when using DISTINCT. When using `count(:all)` with eager loading, Active Record enforces DISTINCT to count the driving table records only. 6beb4de7 was caused the regression because `count(:all)` with DISTINCT path no longer removes ORDER BY. We need to ignore ORDER BY when DISTINCT is enforced, otherwise not always generated valid SQL for PostgreSQL. Fixes #31783.
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
Clear the transaction state when AR object is duped
-
由 Yuriy Ustushenko 提交于
-
由 Matthew Draper 提交于
-
由 Rafael França 提交于
Avoid passing unnecessary arguments to relation
-
由 Rafael Mendonça França 提交于
-
由 Rafael França 提交于
Only enable verbose_query_logs in Rails server
-
由 Rafael França 提交于
Remove code duplication for `ActionController::Metal.action`
-
由 Daniel Colson 提交于
Most of the time the table and predicate_builder passed to Relation.new are exactly the arel_table and predicate builder of the given klass. This uses klass.arel_table and klass.predicate_builder as the defaults, so we don't have to pass them in most cases. This does change the signaure of both Relation and AssocationRelation. Are we ok with that?
-
- 24 1月, 2018 11 次提交
-
-
由 Matthew Draper 提交于
It doesn't have to do anything, but it shouldn't fail. Fixes #31766.
-
由 Matthew Draper 提交于
Postgresql bulk_change_table should flatten procs array
-
由 Matthew Draper 提交于
Build a multi-statement query when inserting fixtures
-
由 Dinah Shi 提交于
-
由 Ryuta Kamizono 提交于
* Add backticks * Expand tabs * Fix indentation
-
由 Ryuta Kamizono 提交于
* rDBMS -> RDBMS. There is only place using rDBMS. * a SQL -> an SQL
-
由 loothunter1 提交于
* Update active_record_basics.md I made a bit of clarification for people, who are not familiar with SQL (pretty much like me). However, I don't know what tutorial for MySQL is better, so I haven't inserted a link yet. * [ci skip] For those who new to GitHub Added more instructions for contributing guides. Without them, it was somewhat confusing for me to find what I should actually do. * Update active_record_basics.md Fixed grammar and text wrapping as requested. * Update contributing_to_ruby_on_rails.md Revised instructions. * Update contributing_to_ruby_on_rails.md Typos * Update active_record_basics.md * [ci skip] Update active_record_basics Added a few links to SQL tutorials found on the net. Also, changed MySQL to SQL (or one of its extensions) - I think that it's a good compromise. * [ci skip] I think now it's more clear what to do. * [ci skip] Fixed strings [Rafael Mendonça França + loothunter1]
-
由 Rafael França 提交于
Allow for custom handling of exceptions that are discarded
-
由 Sean Griffin 提交于
We don't implement much custom marshalling logic for these objects, but the proc default case needs to be handled separately. Unfortunately there's no way to just say "do what you would have done but with this value for one ivar", so we have to manually implement `marshal_load` as well. The test case is a little bit funky, but I'd really like an equality test in there, and there's no easy way to add one now that this is out of AR (since the `attributes` method isn't here) Fixes #31216
-
由 Ryuta Kamizono 提交于
Fix actionmailer lambda default
-
由 Edouard CHIN 提交于
- mysql will add a 2 bytes margin to the statement, so given a `max_allowed_packet` set to 1024 bytes, a 1024 bytes fixtures will no be inserted (mysql will throw an error) - Preventing this by decreasing the max_allowed_packet by 2 bytes when doing the comparison with the actual statement size
-
- 23 1月, 2018 17 次提交
-
-
由 Olivier Lacan 提交于
Should fix #31688 unless someone can point me to a better way to achieve this goal. Essentially David's point was that verbose query logging when enabled in Rails console tends to make things very noisy. That's especially true if we display absolute paths to callsites which sadly is still the case when we detect a caller that isn't part of the Rails application — think gems. Discussed this with both @matthewd and @rafaelfranca and went back and forth between enabling if defined?(Rails::Server) or this implementation and this one makes more sense for now. Long term I think it'll make sense to let people override this default disabling in Rails Console because they might want to use the feature but for now it feels like the correct default behavior.
-
由 Yuji Yaginuma 提交于
Fix locale_selector JS bug in ActionMailer Preview
-
由 Hitoshi Nakashima 提交于
-
由 Rafael França 提交于
Improve fault tolerance for redis cache store
-
由 fatkodima 提交于
-
由 George Claghorn 提交于
-
由 Rafael França 提交于
remove text repetition
-
由 utilum 提交于
[ci skip]
-
由 Rafael Mendonça França 提交于
Add support for connection pooling on RedisCacheStore
-
由 Rafael França 提交于
Update guide text not to contradict image
-
由 utilum 提交于
The bottom line in the image of `ActionController::UnknownFormat`is not truncated. Now the text does not say it is. [ci skip]
-
由 Ryuta Kamizono 提交于
Support for PostgreSQL foreign tables
-
由 Ryuta Kamizono 提交于
Fixes #31762.
-
由 fatkodima 提交于
-
由 fatkodima 提交于
-
由 Edouard CHIN 提交于
-
由 Edouard CHIN 提交于
- The `insert_fixtures` method can be optimized by making a single multi statement query for all fixtures having the same connection instead of doing a single query per table - The previous code was bulk inserting fixtures for a single table, making X query for X fixture files - This patch builds a single **multi statement query** for every tables. Given a set of 3 fixtures (authors, dogs, computers): ```ruby # before %w(authors dogs computers).each do |table| sql = build_sql(table) connection.query(sql) end # after sql = build_sql(authors, dogs, computers) connection.query(sql) ``` - `insert_fixtures` is now deprecated, `insert_fixtures_set` is the new way to go with performance improvement - My tests were done with an app having more than 700 fixtures, the time it takes to insert all of them was around 15s. Using a single multi statement query, it took on average of 8 seconds - In order for a multi statement to be executed, mysql needs to be connected with the `MULTI_STATEMENTS` [flag](https://dev.mysql.com/doc/refman/5.7/en/c-api-multiple-queries.html), which is done before inserting the fixtures by reconnecting to da the database with the flag declared. Reconnecting to the database creates some caveats: 1. We loose all open transactions; Inside the original code, when inserting fixtures, a transaction is open. Multple delete statements are [executed](https://github.com/rails/rails/blob/a681eaf22955734c142609961a6d71746cfa0583/activerecord/lib/active_record/fixtures.rb#L566) and finally the fixtures are inserted. The problem with this patch is that we need to open the transaction only after we reconnect to the DB otherwise reconnecting drops the open transaction which doesn't commit all delete statements and inserting fixtures doesn't work since we duplicated them (Primary key duplicate exception)... - In order to fix this problem, the transaction is now open directly inside the `insert_fixtures` method, right after we reconnect to the db - As an effect, since the transaction is open inside the `insert_fixtures` method, the DELETE statements need to be executed here since the transaction is open later 2. The same problem happens for the `disable_referential_integrity` since we reconnect, the `FOREIGN_KEY_CHECKS` is reset to the original value - Same solution as 1. , the disable_referential_integrity can be called after we reconnect to the transaction 3. When the multi statement query is executed, no other queries can be performed until we paginate over the set of results, otherwise mysql throws a "Commands out of sync" [Ref](https://dev.mysql.com/doc/refman/5.7/en/commands-out-of-sync.html) - Iterating over the set of results until `mysql_client.next_result` is false. [Ref](https://github.com/brianmario/mysql2#multiple-result-sets) - Removed the `active_record.sql "Fixture delete"` notification, the delete statements are now inside the INSERT's one - On mysql the `max_allowed_packet` is looked up: 1. Before executing the multi-statements query, we check the packet length of each statements, if the packet is bigger than the max_allowed_packet config, an `ActiveRecordError` is raised 2. Otherwise we concatenate the current sql statement into the previous and so on until the packet is `< max_allowed_packet`
-