- 04 3月, 2017 1 次提交
-
-
由 ChakreshwarSharma 提交于
-
- 02 3月, 2017 8 次提交
-
-
由 Kasper Timm Hansen 提交于
Use `blank?` instead of `empty?`
-
由 yuuji.yaginuma 提交于
In order to avoid `NoMethodError` when it is nil. Follow up to 82f7dc61
-
由 Andrew White 提交于
Update `DateTime#change` to support usec and nsec
-
由 Andrew White 提交于
Adding support for these options now allows us to update the `DateTime#end_of` methods to match the equivalent `Time#end_of` methods, e.g: datetime = DateTime.now.end_of_day datetime.nsec == 999999999 # => true Fixes #21424.
-
由 Rafael França 提交于
`valid_type?` should accept only supported types
-
由 Kasper Timm Hansen 提交于
Just dispatch to the command help itself for more info.
-
由 Kasper Timm Hansen 提交于
Prefer Thor's say method to Kernel's plain puts.
-
由 Kasper Timm Hansen 提交于
In case there's no $EDITOR assigned users would see a cryptic: ``` % EDITOR= bin/rails secrets:edit Waiting for secrets file to be saved. Abort with Ctrl-C. sh: /var/folders/wd/xnncwqp96rj0v1y2nms64mq80000gn/T/secrets.yml.enc: Permission denied New secrets encrypted and saved. ``` That error is misleading, so give a hint in this easily detectable case. Fixes #28143.
-
- 01 3月, 2017 16 次提交
-
-
由 Kasper Timm Hansen 提交于
Use appropriate type for `test_framework` option
-
由 Kasper Timm Hansen 提交于
Use DEFAULT_CIPHER constant in MessageEncryptor
-
由 yuuji.yaginuma 提交于
This fixes the following warning. ``` Expected string default value for '--test-framework'; got false (boolean) ```
-
由 Lukas Zapletal 提交于
-
由 Andrew White 提交于
Support for using `SELECT` column or expression aliases in the `HAVING` clause isn't part of the SQL standard so it's better to whitelist the test for adapters where we know it works and skip it on others.
-
由 Rafael França 提交于
`HOST` must be all capital letters
-
由 Rafael França 提交于
Use `inspect` in `type_cast_for_schema` for date/time and decimal values
-
由 Rafael França 提交于
Allow skipping of turbolinks for test dummy application for plugin/engine
-
由 Rafael França 提交于
Make required by default test for belongs_to association clearer
-
由 Rafael França 提交于
`create_join_table` should respect `references` column type
-
由 Rafael França 提交于
Do not evaluate :if arguments when :on is not satisfied for transaction callbacks
-
由 eileencodes 提交于
I incorrectly changed behavior of `dup`. Reading the original issue I thought that `dup` should retain the original contents of the record and it's associations but it is in fact supposed to be a copy as if a record had been reinitialized. This reverts commit ca8c21df.
-
由 Rafael França 提交于
Use `tables` instead of `data_sources - views`
-
由 Rafael França 提交于
Take failed screenshot before reset driver
-
由 Rafael França 提交于
Improve documentation for Testing Your Mailers [ci skip]
-
- 28 2月, 2017 15 次提交
-
-
由 James Baer 提交于
The current Basic Test Case example has the following assertion ``` assert_equal read_fixture('invite').join, email.body.to_s ``` email.body.to_s returns an empty string if both HTML and text templates exist for a given mailer. This commit adds a note to section 11.2.2 explaining this and also suggests using email.text_part.body.to_s and email.html_part.body.to_s as alternatives.
-
由 Vipul A M 提交于
Fix http -> https [ci skip]
-
由 kenta-s 提交于
-
由 eileencodes 提交于
In Rails 3.2 dupping a `CollectionProxy` would dup it's `load_target` as well. That functionality has been broken since the release of Rails 4.0. I hit this in an application upgrade and wondered why duplicating a CollectionProxy and assigning it to a variable stopped working. When calling `dup` on a `CollectionProxy` only the owner (ex. topic) was getting duplicated and the `load_target` would remain in tact with it's original object ID. Dupping the `load_target` is useful for performing a logging operation after records have been destroyed in a method. For example: ``` def transfer_operation saved_replies = topic.replies topic.replies.clear saved_replies.each do |reply| user.update_replies_count! end end ``` This change adds a `initialize_dup` method that performs a `deep_dup` on the `@associatiation` so that the `load_target` is dupped as well. Fixes #17117
-
由 Andrew White 提交于
Oracle database also does not allow aliases in the having clause
-
由 Ryuta Kamizono 提交于
`valid_type?` is used in schema dumper to determine if a type is supported. So if `valid_type?(:foobar)` is true, it means that schema dumper is allowed to create `t.foobar`. But it doesn't work. I think that `valid_type?` should accept only supported types. https://github.com/rails/rails/blob/v5.1.0.beta1/activerecord/lib/active_record/schema_dumper.rb#L135-L142 ```ruby columns.each do |column| raise StandardError, "Unknown type '#{column.sql_type}' for column '#{column.name}'" unless @connection.valid_type?(column.type) next if column.name == pk type, colspec = @connection.column_spec(column) tbl.print " t.#{type} #{column.name.inspect}" tbl.print ", #{format_colspec(colspec)}" if colspec.present? tbl.puts end ```
-
由 Ryuta Kamizono 提交于
Follow up of #26266. The default type of `primary_key` and `references` were changed to `bigint` since #26266. But `create_join_table` column type is still `integer`. It should respect `references` column type.
-
由 Carlos Figueiredo 提交于
-
由 Viktor Fonic 提交于
When `rails new plugin` is invoked, turbolinks should be skipped in the dummy test application generated by the plugin generator.
-
由 yuuji.yaginuma 提交于
Now reset the driver before take failed screenshot since #28144. However, I think that failed screenshot should be take with the driver actually used in the test. So, fixed to take screenshot before reset driver.
-
由 Ryuta Kamizono 提交于
`tables` returns only tables now.
-
由 Rafael França 提交于
Use released webpacker in new applications
-
由 Rafael França 提交于
Remove `encode_special_chars` option from `strip_tags`
-
由 yuuji.yaginuma 提交于
Because webpacker 1.0 already released.
-
由 Carlos Figueiredo 提交于
Since #18937 `belongs_to` associations receive a setting to determine if it should be or not treated as `required` by default. While the tests were still passing, it was not evident that the "default" behaviour for `required` could change in fuction of a setting, that is set by default for fresh Rails5 apps, but not for upgraded apps. This commit try to relate them to make it clear what is the behaviour expected when the setting is set as `true` or not set.
-