This is the project guideline and the reasons are:

* That follows standard Ruby semantics.
* Allows the implementation to avoid artificial code like !! or something ? true : false
* You do not need to rely on the exact type of 3rd party code. For
example, if your method returns str.end_with?('foo') you do not need to
make sure end_with? returns a singleton. Your predicate just propagates
predicate semantics up regardless of what end_with? returns.

Refactor debug view

Avoid logic in ERB and use helpers

Add new methods to MessageVerifier

Silence Minitest for plugin tests.

`_generate_paths_by_default` should always be private.

no need to pass native_database_types around

Fixes https://github.com/rails/rails/issues/17340.

Use Minitest::BacktraceFilter instead of removing all silencers. This
will allow the backtrace for all libraries in the plugin to be shown
while removing noise generated by Minitest's backtrace.

Remove unused AV/test/fixtures/scope

Remove unused AV/test/fixtures/happy_path

The file `modgreet.erb` was added 8 years ago in 21187c0f
and is not used anymore by any test.

The `test/fixtures/happy_path/render_action/hello_world.erb` file was
introduced in 8ab37c76 for the `TestRenderAction` test.

That test was subsequently removed in 34f058e0, so the fixture is not
used anymore.

If Travis CI is happy, then you can be sure the fixture can be removed.

Remove unused AV/test/fixtures/blog_public

Remove one AV fixture (duplicate of an AP fixture)

This commit adds a `#verified` method to
`ActiveSupport::MessageVerifier` which will return either `false` when
it encounters an error or the message. `#verify` continues to raise an
`InvalidSignature` exception on error.

This commit also adds a convenience boolean method on `MessageVerifier`
as a way to check if a message is valid without performing the
decoding.

Bugfix config.action_view.default_form_builder option

Both ActionPack and ActionView include `test/fixtures/functional_caching/fragment_cached_without_digest.html.erb`.

The [ActionPack file](https://github.com/rails/rails/blob/master/actionpack/test/fixtures/functional_caching/fragment_cached_without_digest.html.erb) is used by the tests.

The [ActionView file](https://github.com/rails/rails/blob/master/actionview/test/fixtures/functional_caching/fragment_cached_without_digest.html.erb) is not: it was introduced in eb23754e when some tests and
fixtures were moved from AP to AV, but no tests in AV uses the fixture.

Long story short: if Travis CI is happy with removing the fixture, you can
be sure that is not needed anymore!

The fixtures were added to support StaticTests in 401cd979 but
those tests were then removed in d5ad92ce.

If Travis CI is happy with this PR, then you can be sure that
those fixtures are not needed anymore.

Fix documentation for ActionMailer::Base#default [ci skip]

Just a little syntax error I spotted by accident. Cannot pass hash with curly braces without normal parentheses.

This is a follow up to https://github.com/rails/rails/commit/07786c5e75a7b0afdf318063510af6b475e3e04c
and https://github.com/rails/rails/commit/cd2596f55e88fe659592612a793c4f4aa723c9be

Fix OR in Journey patterns

Fix value extracted from negative integers for PostgreSQL.

Fixes: https://github.com/rails/rails/issues/17856.

Pretty-print request params on exception page

The detection of in-place changes caused a weird unexpected issue with
numericality validations. That validator (out of necessity) works on the
`_before_type_cast` version of the attribute, since on an `:integer`
type column, a non-numeric string would type cast to 0.

However, strings are mutable, and we changed strings to ensure that the
post type cast version of the attribute was a different instance than
the before type cast version (so the mutation detection can work
properly).

Even though strings are the only mutable type for which a numericality
validation makes sense, special casing strings would feel like a strange
change to make here. Instead, we can make the assumption that for all
mutable types, we should work on the post-type-cast version of the
attribute, since all cases which would return 0 for non-numeric strings
are immutable.

Fixes #17852

FIX: absolute_path may be nil for code added via instance_eval