- 02 7月, 2016 16 次提交
-
-
由 Rafael França 提交于
Remove `create_table_info_cache` because it not be reused
-
由 Rafael Mendonça França 提交于
Since bundler 1.12.0, the gemspec is validated so the `bundle install` command will fail just after the gem is created causing confusion to the users. This change was a bug fix to correctly validate gemspecs.
-
由 Rafael França 提交于
Do not depend on Rails git repository layout in ActiveSupport tests.
-
由 Rafael França 提交于
Pass `pk: false` to `connection.insert` explicitly if do not have a primary key
-
由 Kasper Timm Hansen 提交于
-
由 Matthew Draper 提交于
ActionDispatch::DebugLocks
-
由 Matthew Draper 提交于
Don't inherit from Concurrent::CountDownLatch
-
由 Matthew Draper 提交于
close hijacked i/o socket after use (fixes #25613)
-
由 Tinco Andringa 提交于
-
由 Matthew Draper 提交于
-
由 Genadi Samokovarov 提交于
When an exception is raised, those Action View rendering logs are just noise for the end developer. I recently silenced those from Web Console, as we do use Action View rendering in it as well. It used created a half a screen of rendering logs. I think we can save those in this recent push for cleaner development logs. Now, the silencing is a bit hacky and we have a bunch of it now, so we can also invest in turning off the logs directly from Action View objects instead of silencing off the logging stream.
-
由 Kasper Timm Hansen 提交于
Felt that += overwriting the path variable was a little too hidden. Make the outcomes easier to spot with an if-else branch.
-
由 Kasper Timm Hansen 提交于
Fix request encoding in tests when string literals are frozen
-
由 Vipul A M 提交于
fix ActiveSupport::Infector.constantize usage API doc [ci skip]
-
由 Ryuta Kamizono 提交于
`create_table_info_cache` is used for sharing `create_table_info` both `table_options` and `foreign_keys`. But `foreign_keys` no longer uses `create_table_info_cache` by #25307. No need caching anymore.
-
由 Volmer 提交于
When running tests with `--enable-frozen-string-literal` or `# frozen_string_literal: true`, it's currently attempted to mutate the path string in order to append the format, causing a `RuntimeError`. ```ruby get '/posts', as: :json ``` ``` RuntimeError: can't modify frozen String ``` This commit fixes the problem by replacing the mutation with a concatenation, returning a new string.
-
- 01 7月, 2016 24 次提交
-
-
由 eileencodes 提交于
If you had a foreign key set and then decided to add `on_delete: :cascade` later in another migration that migration would run but wouldn't refresh the schema dump. The reason for this was because `create_table_info` caches the statement and sets it to be the same as the original declaration for the foreign key (without the `on_delete: :cascade`. PR #25307 ended up fixing this bug because it removes the check for `create_table_info` and relies on reading from `information_schema`. The fix however was intended to patch another bug. The reason this fixes the issue is we're no longer parsing the regex from the cached `create_table_info`. This regression test is to ensure that the issue does not return if we for some reason go back to using `create_table_info` to set the foreign keys.
-
由 Eileen M. Uchitelle 提交于
Extract foreign key action from `information_schema`
-
由 eileencodes 提交于
Note: this commit looks super weird becuase git. I'm moving the entire NPM section to the part where we actually push the gems/npm package for the reasons below. That's not how the git diff looks though. When we release Rails we run `rake prep_release` which calls `update_versions`. This was updating the NPM version as well. But when we would later run `rake install` to test the installed gem `update_versions` gets called again which causes the install to fail because NPM sees the version is the same as the last run and refuses to continue. If you forget to stash this will then cause the push to RubyGems to fail because `update_versions` is called again and then NPM will not continue because it thinks the version hasn't been changed even though it has. The correct solution would be to not update the NPM verion if it matches the version already in the file but after an hour I could not find a simple way to use NPM to read the current version. Honestly that's not the best way to do it either because say you forget to update something else and then the script thinks it's already been updated. With that in mind I think the best solution is to not update the NPM version until right before we are going to push to NPM because then that won't cause the push to RubyGems to fail.
-
由 Vít Ondruch 提交于
-
由 Ryuta Kamizono 提交于
Because causing an extra query by `sql_for_insert` for guessing a primary key. https://github.com/rails/rails/blob/v5.0.0/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb#L121-L125
-
由 Rafael França 提交于
Deprecation passing of `start` value was removed [ci skip]
-
由 Ryuta Kamizono 提交于
ref #18961, #23099.
-
由 प्रथमेश Sonpatki 提交于
[ci skip] Add 'params' formatting in ActionController::Base
-
由 Vipul A M 提交于
25543 docs cleanup
-
由 Rafael França 提交于
Merge pull request #25431 from prathamesh-sonpatki/add-note-about-upgrade-guide-at-the-end-of-update Display link to Rails upgrade guide at the end of `rails app:update` task.
-
由 Rafael Mendonça França 提交于
-
由 Rafael França 提交于
Mark Testing Guide as pubished and reword the title
-
由 Vipul A M 提交于
-
由 Vipul A M 提交于
[ci skip] Fix Typos and Punctuation in Guides: Upgrading
-
由 Alex Kitchens 提交于
-
由 Rafael Mendonça França 提交于
-
由 Eileen M. Uchitelle 提交于
Add a Rails 5 release note for ActionController::Live becoming a Concern
-
由 Rodrigo Rosenfeld Rosas 提交于
Related to issue #25581 https://github.com/rails/rails/issues/25581
-
由 Eileen M. Uchitelle 提交于
Add an upgrade note related to ActionController::Live becoming a Concern
-
由 Rafael Mendonça França 提交于
Update to Turbolinks 5.0.0 final
-
由 Rodrigo Rosenfeld Rosas 提交于
See issue #25581: https://github.com/rails/rails/issues/25581
-
由 Rafael Mendonça França 提交于
-
由 Sam Stephenson 提交于
-
由 eileencodes 提交于
From the style guide: When writing headings, capitalize all words except for prepositions, conjunctions, internal articles, and forms of the verb "to be":
-