- 30 9月, 2016 3 次提交
-
-
由 Matthew Draper 提交于
Callbacks: leave less lines in the backtrace
-
由 Matthew Draper 提交于
Callbacks are everywhere, so it's better if we can avoid making a mess of the backtrace just because we've passed through a callback hook. I'm making no effort to the before/after invocations: those only affect backtraces while they're running. The calls that matter are the ones that remain on the call stack after run_callbacks yields: around callbacks, and internal book-keeping around the before/afters.
-
由 Sean Griffin 提交于
This was caused by 6d0d83a3. While the bug it's trying to fix is handled if the association is loaded in an after_(create|save) callback, it doesn't handle any cases that load the association before the persistence takes place (validation, or before_* filters). Instead of caring about the timing of persistence, we can just ensure that we're not double adding the record instead. The test from that commit actually broke, but it was not because the bug has been re-introduced. It was because `Bulb` in our test suite is doing funky things that look like STI but isn't STI, so equality comparison didn't happen as the loaded model was of a different class. Fixes #26661.
-
- 29 9月, 2016 12 次提交
-
-
由 Vipul A M 提交于
Fix typo in 5_0_release_notes.md doc [ci skip]
-
由 Yusuke Nakamura 提交于
-
由 Kasper Timm Hansen 提交于
remove `mongrel` once again
-
由 Akira Matsuda 提交于
Remove dead constants
-
由 yuuji.yaginuma 提交于
`mongrel` was removed in #26408. But have back accidentally in #26414.
-
由 Jon Moss 提交于
update description of queue adapter in test [ci skip]
-
由 Jon Moss 提交于
[ci skip] Remove not necessary whitespace
-
由 Jon Moss 提交于
[ci skip] Use right format text
-
由 Jon Moss 提交于
[ci skip] Use class name instead of path to file
-
由 Andrey Molchanov 提交于
-
由 Andrey Molchanov 提交于
-
由 Andrey Molchanov 提交于
-
- 28 9月, 2016 3 次提交
-
-
由 प्रथमेश Sonpatki 提交于
[ci skip] Removes broken performance testing link from the 2.2 release notes
-
由 Michael Lennox 提交于
-
由 yuuji.yaginuma 提交于
`ActiveJob::TestCase` set `TestAdapter` to queue adapter at `before_setup`. https://github.com/rails/rails/blob/master/activejob/lib/active_job/test_helper.rb#L12..L21
-
- 27 9月, 2016 10 次提交
-
-
由 Kasper Timm Hansen 提交于
use `active_support/testing/autorun` in `bin/test` script
-
由 Rafael França 提交于
Make :as option also set request format (AC::TestCase)
-
由 Rafael França 提交于
Do not leak the Errors default proc when calling to_hash or as_json
-
由 Jean Boussier 提交于
-
由 yuuji.yaginuma 提交于
29f0fbd5 has changed that always call `Minitest.autorun` in `active_support/testing/autorun`. Therefore, when used directly `Minitest.run`, tests are performed twice.
-
由 प्रथमेश Sonpatki 提交于
fix typo in `DateAndTime::Calculations#all_week` doc [ci skip]
-
由 yuuji.yaginuma 提交于
`Date.week_start` does not exist. `Date.beginning_of_week` seems to be correct. Ref: #5339
-
由 Jon Moss 提交于
Fix doc format for `RecordFetchWarning` [ci skip]
-
由 Ryuta Kamizono 提交于
-
由 Kasper Timm Hansen 提交于
Initial Rails Commands Infrastructure
-
- 26 9月, 2016 12 次提交
-
-
由 Kasper Timm Hansen 提交于
-
由 Sean Griffin 提交于
This is not as good a solution as actually hashing both values, but Ruby doesn't expose that capability other than allocating the array. Unless we were to do something silly like have a thread local array that is re-used, I don't see any other way to do this without allocation. This solution may not be perfect, but it should reasonably avoid collisions to the extent that we need.
-
由 Matthew Draper 提交于
[ci skip] Update PG adapter documentation
-
由 Alex Kitchens 提交于
Per discussion in pull request #26622: "Let's change it to PG::Error. The more specific classes mentioned are subclasses, and the fact the raised exception is a PG::UndefinedColumn doesn't change the fact that it's also a PG::Error." - matthewd
-
由 Jon Moss 提交于
[ci skip] Clarify Postgresql Documentation
-
由 Alex Kitchens 提交于
This clarifies the object that +ActiveRecord::Base.connection.execute+ will return when using Postgresql.
-
由 Kasper Timm Hansen 提交于
-
由 Kasper Timm Hansen 提交于
-
由 Kasper Timm Hansen 提交于
-
由 Kasper Timm Hansen 提交于
-
由 Kasper Timm Hansen 提交于
Wash out your old! These adhoc scripts are replaced by the new commands.
-
由 Kasper Timm Hansen 提交于
Prescribed some review fixes for myself!
-