1. 16 3月, 2020 1 次提交
    • I
      [ImgBot] Optimize images · 4f1472d4
      ImgBotApp 提交于
      /guides/assets/images/rails_guides_logo.gif -- 3.68kb -> 2.65kb (28.06%)
      /guides/assets/images/association_basics/belongs_to.png -- 34.22kb -> 26.71kb (21.96%)
      /guides/assets/images/getting_started/template_is_missing_articles_new.png -- 26.17kb -> 20.72kb (20.81%)
      /guides/assets/images/association_basics/has_many.png -- 35.38kb -> 29.84kb (15.66%)
      /guides/assets/images/association_basics/has_one.png -- 37.33kb -> 32.27kb (13.54%)
      /guides/assets/images/association_basics/polymorphic.png -- 82.75kb -> 72.70kb (12.15%)
      /guides/assets/images/association_basics/has_one_through.png -- 90.37kb -> 79.83kb (11.66%)
      /guides/assets/images/association_basics/habtm.png -- 60.00kb -> 53.02kb (11.63%)
      /guides/assets/images/getting_started/unknown_action_create_for_articles.png -- 15.36kb -> 13.82kb (10.04%)
      /guides/assets/images/association_basics/has_many_through.png -- 96.52kb -> 88.06kb (8.76%)
      Signed-off-by: NImgBotApp <ImgBotHelp@gmail.com>
      4f1472d4
  2. 15 3月, 2020 2 次提交
  3. 14 3月, 2020 9 次提交
  4. 13 3月, 2020 10 次提交
    • K
      Merge pull request #38708 from utilum/AS_concern_test_vars_not_initialized_warning · 0c715e59
      Kasper Timm Hansen 提交于
      Fix variable not initialized warnings
      0c715e59
    • U
      Fix variable not initialized warnings · 879918b5
      utilum 提交于
      ```
      activesupport/test/concern_test.rb:20: warning: instance variable
      @included_ran not initialized
      
      activesupport/test/concern_test.rb:28: warning: instance variable
      @prepended_ran not initialized
      ```
      879918b5
    • R
      Merge pull request #38713 from kirs/activerecord-build_result · 20f4a2fc
      Rafael França 提交于
      Extract building ActiveRecord::Result into a method
      20f4a2fc
    • K
      Extract building ActiveRecord::Result into a method · fd0a76b5
      Kir Shatrov 提交于
      fd0a76b5
    • R
      Merge pull request #38595 from dylnclrk/update-params-in-docs · 6020bf32
      Rafael França 提交于
      Update code snippets to suggest the use of strong parameters
      6020bf32
    • R
      Merge pull request #38689 from yashLadha/refactor/arel_fetch_attribute · 328ed171
      Rafael França 提交于
      refactor: arel fetch_attribute to get the atrribute node from binary module.
      328ed171
    • R
      Merge pull request #38676 from kwerle/correct_object_serializer_doc · f0048109
      Rafael França 提交于
      Correct the parameter name for deserialize
      f0048109
    • A
      Merge pull request #38712 from rails/fix-invoke-on-2-8 · 1eba54f5
      Aaron Patterson 提交于
      Rails::Command.invoke wants kwargs, so give it kwargs
      1eba54f5
    • A
      Rails::Command.invoke wants kwargs, so give it kwargs · 690d946d
      Aaron Patterson 提交于
      This fixes an exception when generating a new app on Ruby 2.8.  Before
      this commit, I get this exception:
      
      ```
      $ be ruby railties/exe/rails new ~/git/fix-bug --dev
      ...
      ...
      Traceback (most recent call last):
      	31: from railties/exe/rails:10:in `<main>'
      	30: from railties/exe/rails:10:in `require'
      	29: from /Users/aaron/git/rails/railties/lib/rails/cli.rb:18:in `<top (required)>'
      	28: from /Users/aaron/git/rails/railties/lib/rails/command.rb:45:in `invoke'
      	27: from /Users/aaron/git/rails/railties/lib/rails/command/base.rb:69:in `perform'
      	26: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor.rb:392:in `dispatch'
      	25: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/invocation.rb:127:in `invoke_command'
      	24: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/command.rb:27:in `run'
      	23: from /Users/aaron/git/rails/railties/lib/rails/commands/application/application_command.rb:26:in `perform'
      	22: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/base.rb:485:in `start'
      	21: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/group.rb:232:in `dispatch'
      	20: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/invocation.rb:134:in `invoke_all'
      	19: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/invocation.rb:134:in `map'
      	18: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/invocation.rb:134:in `each'
      	17: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/invocation.rb:134:in `block in invoke_all'
      	16: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/invocation.rb:127:in `invoke_command'
      	15: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/command.rb:27:in `run'
      	14: from (eval):1:in `run_webpack'
      	13: from /Users/aaron/git/rails/railties/lib/rails/generators/app_base.rb:419:in `run_webpack'
      	12: from /Users/aaron/git/rails/railties/lib/rails/generators/actions.rb:255:in `rails_command'
      	11: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/actions.rb:197:in `in_root'
      	10: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/actions.rb:187:in `inside'
      	 9: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/2.8.0/fileutils.rb:139:in `cd'
      	 8: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/2.8.0/fileutils.rb:139:in `chdir'
      	 7: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/actions.rb:187:in `block in inside'
      	 6: from /Users/aaron/.rbenv/versions/ruby-trunk/lib/ruby/gems/2.8.0/gems/thor-1.0.1/lib/thor/actions.rb:197:in `block in in_root'
      	 5: from /Users/aaron/git/rails/railties/lib/rails/generators/actions.rb:256:in `block in rails_command'
      	 4: from /Users/aaron/git/rails/activesupport/lib/active_support/core_ext/kernel/reporting.rb:15:in `silence_warnings'
      	 3: from /Users/aaron/git/rails/activesupport/lib/active_support/core_ext/kernel/reporting.rb:28:in `with_warnings'
      	 2: from /Users/aaron/git/rails/activesupport/lib/active_support/core_ext/kernel/reporting.rb:15:in `block in silence_warnings'
      	 1: from /Users/aaron/git/rails/railties/lib/rails/generators/actions.rb:257:in `block (2 levels) in rails_command'
      /Users/aaron/git/rails/railties/lib/rails/command.rb:31:in `invoke': wrong number of arguments (given 3, expected 1..2) (ArgumentError)
      ```
      
      After this commit, things seem to work.
      690d946d
    • R
      Merge pull request #38701 from OsamaSayegh/mp-in-rails · bb9c12b4
      Rafael França 提交于
      Include rack-mini-profiler gem by default
      bb9c12b4
  5. 12 3月, 2020 7 次提交
  6. 11 3月, 2020 6 次提交
  7. 10 3月, 2020 5 次提交