- 09 9月, 2012 2 次提交
-
-
由 Ernie Miller 提交于
When calling a query method on an attribute that was not selected by an ActiveRecord query, an ActiveModel::MissingAttributeError is not raised. Instead, a nil value is returned, which will return false once cast to boolean. This is undesirable, as we should not give the impression that we know the attribute's boolean value when we haven't loaded the attribute's (possibly) non-boolean value from the database. This issue is present on versions going back as far as 2.3, at least.
-
由 Francesco Rodriguez 提交于
-
- 08 9月, 2012 7 次提交
-
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
-
由 Konstantin Shabanov 提交于
-
由 Carlos Antonio da Silva 提交于
Merged in f41dba27 [ci skip]
-
由 Carlos Antonio da Silva 提交于
* There is no need to delete the primary key from cloned attributes, since it sets the same pk to nil afterwards. * Check for empty? instead of any? to run initialize callbacks.
-
由 Aaron Patterson 提交于
transaction.
-
由 Carlos Antonio da Silva 提交于
Check 0180e090 for more reasoning about that.
-
- 07 9月, 2012 5 次提交
-
-
由 Carlos Antonio da Silva 提交于
Since 810a50da, the new policy is to keep old changelogs in their own branches, to avoid manual syncing across different branches. Please check that commit for more reasoning about the new policy.
-
由 Carlos Antonio da Silva 提交于
-
由 Prem Sichanugrist 提交于
-
由 Jan Bernacki 提交于
move validation to AR
-
由 Yves Senn 提交于
-
- 06 9月, 2012 5 次提交
-
-
由 Rafael Mendonça França 提交于
This will solve the issue that abort the connection transaction when we skip the tests.
-
由 Dickson S. Guedes 提交于
This implements the support to encode/decode JSON data to/from database and creating columns of type JSON using a native type [1] supported by PostgreSQL from version 9.2. [1] http://www.postgresql.org/docs/9.2/static/datatype-json.html
-
由 Rafael Mendonça França 提交于
-
由 Ian Lesperance 提交于
-
由 Seamus Abshere 提交于
The previous implementation had the strange requirement that db/structure.sql contain only CREATE TABLE sql statements, one per table, separated by double newlines. SQLite3 and PostgreSQL database tasks, on the other hand, simply spawn 'sqlite3' and 'psql' binaries to load the file directly. The new implementation follows this and attempts to respect all current MySQL configuration settings.
-
- 05 9月, 2012 4 次提交
-
-
由 Matt Jones 提交于
-
由 Adam Meehan 提交于
-
由 Adam Meehan 提交于
The string_to_dummy_time method was blindly parsing the dummy time string with Date._parse which returns a hash for the date part regardless of whether the time part is an invalid time string.
-
由 Konstantin Shabanov 提交于
-
- 04 9月, 2012 2 次提交
-
-
由 Yves Senn 提交于
All tests with a custom inheritance_column use the `Vegtable` model. The field ruby_type on the Company models is no longer needed
-
由 Yves Senn 提交于
previously the tests with and without a custom `inheritance_column` used the same models. Since the model then has both fields this can lead to false positives.
-
- 03 9月, 2012 1 次提交
-
-
由 Yves Senn 提交于
I had to create a new table because I needed an STI table, which does not have both a "type" and a "custom_type" the test fails with: 1) Error: test_alt_becomes_works_with_sti(InheritanceTest): NoMethodError: undefined method `type=' for #<Cabbage id: 1, name: "my cucumber", custom_type: "Cucumber"> /Users/username/Projects/rails/activemodel/lib/active_model/attribute_methods.rb:432:in `method_missing' /Users/username/Projects/rails/activerecord/lib/active_record/attribute_methods.rb:100:in `method_missing' /Users/username/Projects/rails/activerecord/lib/active_record/persistence.rb:165:in `becomes' test/cases/inheritance_test.rb:134:in `test_becomes_works_with_sti' test/cases/inheritance_test.rb:140:in `test_alt_becomes_works_with_sti'
-
- 01 9月, 2012 1 次提交
-
-
由 Jon Leighton 提交于
This is purely a performance optimisation. See https://gist.github.com/3552829
-
- 31 8月, 2012 5 次提交
-
-
由 Jon Leighton 提交于
This is a performance/GC optimisation. In theory, this could be optimised by the implementation (last time I checked, this would have no effect on JRuby). But in practise, this make attribute access faster.
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
We don't need separate @class_to_pool and @connection_pool hashes.
-
由 Jon Leighton 提交于
-
由 Jon Leighton 提交于
* Loop rather than recurse in retrieve_connection_pool * Key the hash by class rather than class name. This avoids creating unnecessary strings.
-
- 30 8月, 2012 4 次提交
-
-
由 Xavier Noria 提交于
-
由 Jo Liss 提交于
-
由 Jo Liss 提交于
Per https://github.com/lifo/docrails/commit/e94e8d8c3fcac624466afcf61f6a118abe5a6af4#commitcomment-1784677 Thanks @randomecho! This reverts commit e94e8d8c.
-
由 Jo Liss 提交于
-
- 29 8月, 2012 2 次提交
-
-
由 Pratik Naik 提交于
-
由 Xavier Noria 提交于
Changes in old branches needed to be manually synched in CHANGELOGs of newer ones. This has proven to be brittle, sometimes one just forgets this manual step. With this commit we switch to CHANGELOGs per branch. When a new major version is cut from master, the CHANGELOGs in master start being blank. A link to the CHANGELOG of the previous branch allows anyone interested to follow the history.
-
- 28 8月, 2012 2 次提交
-
-
由 Francesco Rodriguez 提交于
-
由 Francesco Rodriguez 提交于
This test https://github.com/rails/rails/blob/master/activerecord/test/cases/base_test.rb#L381 is failing because is not setting `CreditCard.pluralize_table_name` to `false`. In this case, i prefer to change to another model that is not in the `GUESSED_CLASSES` array.
-