- 26 9月, 2019 3 次提交
-
-
由 John Crepezzi 提交于
We are moving to using `DatabaseConfig` objects everywhere inside of Rails instead of passing around Hash objects. This PR moves to using `DatabaseConfig` objects inside of the individual database tasks adapters. In the interest of not breaking existing adapters, we've introduced an upgrade path by which adapters can get a hold of database configuration objects instead of Hashes by implementing a method `self.using_database_configurations?` Co-authored-by: Neileencodes <eileencodes@gmail.com>
-
由 Ryuta Kamizono 提交于
Update test to avoid Puma output format change
-
由 John Crepezzi 提交于
We are seeing some test failures for this test in #37291. It looks like what's going on is that Puma has changed the output for this command between 4.1 and 4.2 Previously: ``` ... * Environment: development * Listening on tcp://localhost:3000 ... ``` Now: ``` ... * Environment: development * Listening on tcp://127.0.0.1:3000 * Listening on tcp://[::1]:3000 ... ``` So to get around this, instead of checking the binding address, just check for the presence of 'Listening' generally like we do on server start. Co-authored-by: Neileencodes <eileencodes@gmail.com>
-
- 25 9月, 2019 8 次提交
-
-
由 Xavier Noria 提交于
Fix typo, shoud -> should [ci skip]
-
由 Takayuki Nakata 提交于
-
由 Xavier Noria 提交于
Since the original message is something like this expected file ... to define constant A, but didn't the \S+ captured the comma. A constant name goes there, so [\w:]+ is enough and won't match the comma.
-
由 Xavier Noria 提交于
-
由 George Claghorn 提交于
-
由 Rafael França 提交于
Better double checked locking in load_schema
-
由 George Claghorn 提交于
Allow setting a different log level per request.
-
由 Jean Boussier 提交于
-
- 24 9月, 2019 29 次提交
-
-
由 Eileen M. Uchitelle 提交于
Instantiate ConnectionPool with a DatabaseConfig rather than a ConnectionSpecification
-
由 Jean Boussier 提交于
-
由 Carlos Antonio da Silva 提交于
-
由 Carlos Antonio da Silva 提交于
Fixed typo in comment in ActionCable::Connection::TestCase [ci skip]
-
由 Eileen M. Uchitelle 提交于
Make all reads on configuration_hash use methods
-
由 George Claghorn 提交于
-
由 George Claghorn 提交于
-
由 Julik Tarkhanov 提交于
-
由 Narendra Rajput 提交于
-
由 Xavier Noria 提交于
This may happen in engines loaded as gems, for example. Closes #37285.
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Akira Matsuda 提交于
-
由 Carlos Antonio da Silva 提交于
Using `self` works by essentially pointing to the included class, in this case `ActiveJob::Base`, so that'd end up delegating to `ActiveJob::Base.queue_adapter` instead.
-
由 Ryuta Kamizono 提交于
Follow up #37281.
-
由 Vipul A M 提交于
Fix typo in actionpack changelog, `a HTTP` -> `an HTTP` [ci skip]
-
由 Takayuki Nakata 提交于
-
由 George Claghorn 提交于
-
由 John Crepezzi 提交于
Convert all uses of `db_config.configuration_hash[*]` to use methods defined on an implementation of `DatabaseConfigurations::DatabaseConfig`. Since we want to get away from accessing properties directly on the underlying configuration hash, we'll move here to accessing those values via the implementations on `DatabaseConfig` (or more specifically, `HashConfig`). There are still codepaths that are passing around `configuration_hash`, and follow-on PRs will address those with the goal of using configuration objects everywhere up until the point we pass a resolved hash over to the underlying client. Co-authored-by: Neileencodes <eileencodes@gmail.com>
-
由 Eileen M. Uchitelle 提交于
Make UrlConfig a subclass of HashConfig
-
由 George Claghorn 提交于
-
由 John Crepezzi 提交于
A `UrlConfig` is a `HashConfig` that mixes in connection information based on a `url` passed from the constructor. Previously, for each new property we wanted to introduce an accessor for, we'd need to write an implementation for `HashConfig` _and_ for `UrlConfig`. Now we make `UrlConfig` descend from `HashConfig` so we can write a single implementation for both cases. Also while we're in here, take the `adapter` implementation into `HashConfig` so that `DatabaseConfig` isn't making any assumptions about the structure of its subclasses. Co-authored-by: Neileencodes <eileencodes@gmail.com>
-
由 Eileen M. Uchitelle 提交于
Remove UrlConfig#url_config?
-
由 Eileen M. Uchitelle 提交于
Resolve Hash with `url` key as a `UrlConfig`
-
由 John Crepezzi 提交于
This private method is only used in one place, to check whether an object we have is an instance of `UrlConfig`. Instead we can just check that we have the right type of object
-
由 John Crepezzi 提交于
In `DatabaseConfigurations#configs_for`, `Hash` configs that contain a `:url` key resolve to a `UrlConfig`. Since we weren't mirroring that behavior in `Resolver`, we had to add explicit handling for `url` keys to the `HashConfig` implementation. Now we're going to always resolve these hashes as `UrlConfig` and can remove the extra implementation of URL handling from `HashConfig`. Of course, this does introduce some duplication between `DatabaseConfigurations` and `Resolver` which we plan to address in a future PR. Co-authored-by: Neileencodes <eileencodes@gmail.com>
-