1. 12 3月, 2017 7 次提交
  2. 11 3月, 2017 11 次提交
  3. 10 3月, 2017 8 次提交
  4. 09 3月, 2017 7 次提交
    • E
      Call system test driver per-instance rather than globally · 7c9af60e
      eileencodes 提交于
      Previously the system test subclasses would call `driven_by` when the
      app booted and not again when the test was initialized which resulted in
      the driver from whichever class was called last to be used in tests.
      
      In rails/rails#28144 the `driven_by` method was changed to run `use` on
      setup and `reset` on teardown. While this was a viable fix this really
      pointed to the problem that system test `driven_by` was a global
      setting, rather than a per-class setting.
      
      To alieviate this problem calling the driver should be done on an
      instance level, rather than on the global level. I added an `initialize`
      method to `SystemTestCase` which will call `use` on the superclass
      driver. Running the server has been moved to `start_application` so that
      it only needs to be called once on boot and no options from `driven_by`
      were being passed to it.
      
      This required a largish rewrite of the tests. Each test needs to utilize
      the subclass so that it can properly test the drivers.
      `ActionDispatch::SystemTestCase` shouldn't be called directly anymore.
      7c9af60e
    • E
      Refactor system test driver/browser · 4dbebe48
      eileencodes 提交于
      Since using a browser is only for selenium it doesn't really make sense
      to have a separate class for handling it there. This brings a lot of the
      if/else out of the main SystemTestCase class and into the Driver class
      so we can abstract away all that extra work.
      4dbebe48
    • X
      force UTF-8 as external encoding in guides generation [ci skip] · 37770bc8
      Xavier Noria 提交于
      See the rationale in the comment found in the patch.
      37770bc8
    • R
      Fix select with block doesn't return newly built records in has_many association · ef3d6fc1
      Ryuta Kamizono 提交于
      The `select` in `QueryMethods` is also an enumerable method.
      Enumerable methods with block should delegate to `records` on
      `CollectionProxy`, not `scope`.
      
      Fixes #28348.
      ef3d6fc1
    • J
      Merge pull request #28340 from k3rni/document-am-default-url-options · c741b493
      Jon Moss 提交于
      Document using `default_url_options` in an ActionMailer class.
      c741b493
    • R
      Deprecate `Migrator.schema_migrations_table_name` · 96aa1897
      Ryuta Kamizono 提交于
      Since 67fba0cf `SchemaMigration` model was extracted.
      Use `SchemaMigration.table_name` instead.
      96aa1897
    • R
      Merge pull request #28336 from tjschuck/test_delegated_params_methods · 4eff8eaf
      Rafael França 提交于
      Tests for delegated public methods on AC::Parameters
      4eff8eaf
  5. 08 3月, 2017 7 次提交