- 20 2月, 2016 3 次提交
-
-
由 Rafael França 提交于
Fix button_to's params option to support nested names.
-
由 Rafael França 提交于
Dependencies clean up
-
由 James Coleman 提交于
In e6e0579d the `params` option was added to the `button_to` helper. However, the patch doesn't support nested hashes so `{a: {b: 'c'}}` for example gets turned into a hidden form input with the name 'a' and the value being the string representation of the `{b: 'c'}` nested hash. Since Rails supports nested hashes everywhere else (and even in the URL params of link_to and button_to), I believe this to be a bug/unfinished feature.
-
- 19 2月, 2016 17 次提交
-
-
由 David Heinemeier Hansson 提交于
Make ActionCable logging less verbose in development
-
由 Sruli Rapps 提交于
Cleans up four items I came across in ActiveSupport::Dependencies: - DependenciesTest# test_dependency_which_raises_exception_isnt_added_to_loaded_set: Fixes current implementation which will pass no matter what since the filepath is never added to "loaded" or "history" without being expanded first. - Remove DependenciesTest#test_unhook. Seems leftover from when alias_method_chain was used in Loadable and ModuleConstMissing. The test will always pass since Module never responds to those methods - WatchStack#new_constants documentation: update self to @stack. Looks like self was leftover from when WatchStack inherited from Hash - Remove ActiveSupport namespace from call to Dependencies.constant_watch_stack.watching? since the namespace is not needed, Dependencies is called two other times in the same method without it (even on the same line) and it brings the line to within 80 characters
-
由 Rafael França 提交于
Merge pull request #23773 from wisetara/wisetara/update-docs-ActiveSupport__TestCase#assert_nothing_raised-for-pr better docs for ActiveSupport::TestCase#assert_nothing_raised
-
-
由 Jon Moss 提交于
remove needless `debug_exception_response_format` config [ci skip]
-
由 yuuji.yaginuma 提交于
Since a0343d11, `debug_exception_response_format` config depends on `api_only`. Therefore, if set the `api_only`, need to specify `debug_exception_response_format` is not.
-
由 Sean Griffin 提交于
Remove unused require
-
由 Matthew Draper 提交于
Fix `unsubscribed` server side behavior
-
由 Xavier Noria 提交于
-
由 Jon Moss 提交于
Before this commit, the `unsubscribed` callbacks in Action Cable server side channels were never called. This is because when a WebSocket "goodbye" message was sent from the client, the Action Cable server didn't properly clean up after the now closed WebSocket. This means that memory could possibly skyrocket with this behavior, since part of this commit is to properly remove closed subscriptions from the global subscriptions hash. Say you have 10,000 users currently connected, and then all 10,000 disconnect -- before this patch, Action Cable would still hold onto information (and Ruby objects!) for all of these now dead connections.
-
由 Matthew Draper 提交于
The Event hack was too much of a hack: on actually thinking about it, there's a rather obvious race.
-
由 Aaron Patterson 提交于
Fix master build
-
由 Jon Moss 提交于
-
由 Rafael Mendonça França 提交于
All gems are released now so we don't need to ask the github repository for these gems anymore.
-
由 Aaron Patterson 提交于
move digest cache on to the DetailsKey object
-
由 Rafael França 提交于
set `skip_listen` option to dummy appplication
-
由 Aaron Patterson 提交于
This moves digest calculation cache on to the details key object. Before, the digest cache was a class level ivar, and one of the keys was the hash value of the details key object: https://github.com/rails/rails/blob/13c4cc3b5aea02716b7459c0da641438077f5236/actionview/lib/action_view/digestor.rb#L28 An object's hash value is not unique, so it's possible for this cache key to produce colliding keys with no resolution. This commit move cache on to the details key object itself, so we know that the digests are always unique per details key object.
-
- 18 2月, 2016 19 次提交
-
-
由 Aaron Patterson 提交于
I don't think caching this method makes any difference on Ruby 2.0: ``` require 'benchmark/ips' class Foo alias :object_hash :hash attr_reader :hash def initialize @hash = object_hash end end class Bar end hash = {} foo = Foo.new bar = Bar.new Benchmark.ips do |x| x.report("foo") { hash[foo] } x.report("bar") { hash[bar] } x.report("foo.hash") { foo.hash } x.report("bar.hash") { bar.hash } end __END__ [aaron@TC ruby (trunk)]$ ruby test.rb Warming up -------------------------------------- foo 118.361k i/100ms bar 118.637k i/100ms Calculating ------------------------------------- foo 7.944M (± 3.1%) i/s - 39.769M bar 7.931M (± 3.4%) i/s - 39.625M [aaron@TC ruby (trunk)]$ ruby test.rb Warming up -------------------------------------- foo 122.180k i/100ms bar 120.492k i/100ms foo.hash 123.397k i/100ms bar.hash 119.312k i/100ms Calculating ------------------------------------- foo 8.002M (± 4.2%) i/s - 39.953M bar 8.037M (± 4.5%) i/s - 40.124M foo.hash 8.819M (± 3.9%) i/s - 44.053M bar.hash 7.856M (± 4.1%) i/s - 39.254M ```
-
由 Jon Moss 提交于
fix the language for simple and proper understanding
-
由 kamal namdeo 提交于
-
由 Jankees van Woezik 提交于
When running the ActionCable server in development I get a lot of output in my logs, this commit sets a maximum length of 300 characters for a broadcast log message.
-
由 Vipul A M 提交于
Missing documentation about hash algorithm option for MessageVerifier
-
由 Mehmet Emin İNAÇ 提交于
-
由 yuuji.yaginuma 提交于
If you want to use `EventedFileUpdateChecker`, need to specify `listen` to plugin's gemspec. However, the default is not specified `listen` to plugin's gemspec, `EventedFileUpdateChecker` should be disabled.
-
由 kamal namdeo 提交于
-
由 Sean Griffin 提交于
Add accidentally removed `#` [ci skip]
-
由 Sean Griffin 提交于
Remove needless `case_insensitive_comparison` in mysql2 adapter
-
由 Ryuta Kamizono 提交于
`#` was removed at f57092ad but this `#` is intentional. e.g. https://github.com/rails/rails/blame/v5.0.0.beta2/activerecord/CHANGELOG.md#L1423-L1426
-
由 Aaron Patterson 提交于
While iterating an AC::Parameters object, the object will mutate itself and stick AC::Parameters objects where there used to be hashes: https://github.com/rails/rails/blob/f57092ad728fa1de06c4f5fd9d09dcc2c4738fd9/actionpack/lib/action_controller/metal/strong_parameters.rb#L632 If you use `permit` after this iteration, the `fields_for_style` method wouldn't return true because the child objects are now AC::Parameters objects rather than Hashes. fixes #23701
-
由 Eileen M. Uchitelle 提交于
This was showing up as an H1. Fixing the indentation here fixes the codeblock.
-
由 Eileen M. Uchitelle 提交于
Remove accidentally duplicated change log title [ci skip]
-
由 Mehmet Emin İNAÇ 提交于
-
由 Aaron Patterson 提交于
we need to continue setting the body on the request object because of Fiber based streaming templates. Fixes #23659
-
由 Sean Griffin 提交于
Fixed `where` for polymorphic associations when passed an array containing different types.
-
由 Matthew Draper 提交于
Addresses #23568, Incorrect error message with accepts_nested_attributes_for / has_many & has_one
-
由 Andrew White 提交于
modify to `error` also abort when specify fail fast option
-
- 17 2月, 2016 1 次提交
-
-
由 Yves Senn 提交于
Implement ActionController::Parameters#inspect
-